<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>135250</bug_id>
          
          <creation_ts>2006-10-07 15:21:37 +0000</creation_ts>
          <short_desc>desktop unusable due to flickering of windows if not &quot;focus follows click&quot;</short_desc>
          <delta_ts>2006-11-02 13:56:36 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>kwin</product>
          <component>general</component>
          <version>unspecified</version>
          <rep_platform>Debian testing</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Arthur Marsh">arthur.marsh</reporter>
          <assigned_to name="KWin default assignee">kwin-bugs-null</assigned_to>
          <cc>dc</cc>
    
    <cc>Harmon.Nine</cc>
    
    <cc>nicolasclement</cc>
    
    <cc>rdieter</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>475292</commentid>
    <comment_count>0</comment_count>
    <who name="Arthur Marsh">arthur.marsh</who>
    <bug_when>2006-10-07 15:21:38 +0000</bug_when>
    <thetext>Version:            (using KDE KDE 3.5.5)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Reported as Debian bug #391357. When using kwin 3.5.5-1 from Debian unstable, and in my case a focus setting of &quot;focus strictly under mouse&quot;, windows flicker, making the desktop unusable. One other user reports that if focus is set to &quot;click to focus&quot;, this problem does not occur.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475343</commentid>
    <comment_count>1</comment_count>
    <who name="Sune Vuorela">debian</who>
    <bug_when>2006-10-07 23:21:29 +0000</bug_when>
    <thetext>Hi!

I have been looking a bit into this. I have looked on the diff of kdebase-3.5.4/kwin and kdebase-3.5.5/kwin and slowly tried to eliminate the differences. It is the fix to http://bugs.kde.org/122425 that is the &apos;bad guy&apos; in this sense.
Reverting by using attached patch makes the flickering go away. (But it reopens 122425, which is a wishlist item)
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475344</commentid>
    <comment_count>2</comment_count>
      <attachid>18055</attachid>
    <who name="Sune Vuorela">debian</who>
    <bug_when>2006-10-07 23:22:42 +0000</bug_when>
    <thetext>Created attachment 18055
Patch as described.

The &apos;revert&apos; patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475395</commentid>
    <comment_count>3</comment_count>
    <who name="Sune Vuorela">debian</who>
    <bug_when>2006-10-08 10:56:22 +0000</bug_when>
    <thetext>I tried to minimize the patch even further down and the following makes the flickering go away. I havo no clue in what other effect this will have.

/Sune

$ cat kdebase-3.5.5/debian/patches/30_kwin.diff
diff -u kdebase-3.5.4.unpatched/kwin/client.cpp kdebase-3.5.4.unpatched/kwin/client.cpp
--- kdebase-3.5.4.unpatched/kwin/client.cpp     2006-05-22 20:13:01.000000000 +0200
+++ kdebase-3.5.4.unpatched/kwin/client.cpp     2006-05-22 20:13:01.000000000 +0200
@@ -506,7 +504,6 @@
             xrects, rects.count(), ShapeSet, mode );
         delete[] xrects;
         }
-    updateShape();
     }

 QRegion Client::mask() const
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475397</commentid>
    <comment_count>4</comment_count>
    <who name="Sune Vuorela">debian</who>
    <bug_when>2006-10-08 11:08:16 +0000</bug_when>
    <thetext>and just for the record, it is not related for the fix mentioned in my first message, this is from a later svn-commit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475588</commentid>
    <comment_count>5</comment_count>
      <attachid>18066</attachid>
    <who name="Lubos Lunak">l.lunak</who>
    <bug_when>2006-10-09 12:16:16 +0000</bug_when>
    <thetext>Created attachment 18066
kwin/client.cpp patch

Please confirm that this patch fixes the problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475827</commentid>
    <comment_count>6</comment_count>
    <who name="Lubos Lunak">l.lunak</who>
    <bug_when>2006-10-10 12:25:59 +0000</bug_when>
    <thetext>SVN commit 594159 by lunakl:

Build the input shape on a helper window instead of directly,
this avoids having a hole in the shape temporarily. This seems
to break non-click-to-focus mouse policies on some systems
(works fine here though).
BUG: 135250
CCMAIL: kde-packager@kde.org



 M  +19 -6     client.cpp  


--- branches/KDE/3.5/kdebase/kwin/client.cpp #594158:594159
@@ -477,17 +477,30 @@
     // calls it or when the decoration is created/destroyed
 
     if( Shape::version() &gt;= 0x11 ) // 1.1, has input shape support
-        { // there appears to be no way to find out if a window has input
-          // shape set or not, so always set propagate the input shape
-          // (it&apos;s the same like the bounding shape by default)
-        XShapeCombineShape( qt_xdisplay(), frameId(), ShapeInput, 0, 0,
+        { // There appears to be no way to find out if a window has input
+          // shape set or not, so always propagate the input shape
+          // (it&apos;s the same like the bounding shape by default).
+          // Also, build the shape using a helper window, not directly
+          // in the frame window, because the sequence set-shape-to-frame,
+          // remove-shape-of-client, add-input-shape-of-client has the problem
+          // that after the second step there&apos;s a hole in the input shape
+          // until the real shape of the client is added and that can make
+          // the window lose focus (which is a problem with mouse focus policies)
+        static Window helper_window = None;
+        if( helper_window == None )
+            helper_window = XCreateSimpleWindow( qt_xdisplay(), qt_xrootwin(),
+                0, 0, 1, 1, 0, 0, 0 );
+        XResizeWindow( qt_xdisplay(), helper_window, width(), height());
+        XShapeCombineShape( qt_xdisplay(), helper_window, ShapeInput, 0, 0,
                            frameId(), ShapeBounding, ShapeSet );
-        XShapeCombineShape( qt_xdisplay(), frameId(), ShapeInput,
+        XShapeCombineShape( qt_xdisplay(), helper_window, ShapeInput,
                            clientPos().x(), clientPos().y(),
                            window(), ShapeBounding, ShapeSubtract );
-        XShapeCombineShape( qt_xdisplay(), frameId(), ShapeInput,
+        XShapeCombineShape( qt_xdisplay(), helper_window, ShapeInput,
                            clientPos().x(), clientPos().y(),
                            window(), ShapeInput, ShapeUnion );
+        XShapeCombineShape( qt_xdisplay(), frameId(), ShapeInput, 0, 0,
+                           helper_window, ShapeInput, ShapeSet );
         }
     }
 
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>475894</commentid>
    <comment_count>7</comment_count>
    <who name="Lubos Lunak">l.lunak</who>
    <bug_when>2006-10-10 17:57:03 +0000</bug_when>
    <thetext>*** Bug 135400 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476624</commentid>
    <comment_count>8</comment_count>
    <who name="Lubos Lunak">l.lunak</who>
    <bug_when>2006-10-13 16:51:15 +0000</bug_when>
    <thetext>*** Bug 135568 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476626</commentid>
    <comment_count>9</comment_count>
    <who name="Lubos Lunak">l.lunak</who>
    <bug_when>2006-10-13 16:51:44 +0000</bug_when>
    <thetext>*** Bug 135562 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>481910</commentid>
    <comment_count>10</comment_count>
    <who name="John Relph">relph</who>
    <bug_when>2006-11-01 01:03:22 +0000</bug_when>
    <thetext>This bug has been shipped in Fedora Core 6.  And it really needs to be fixed.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>18055</attachid>
            <date>2006-10-07 23:22:42 +0000</date>
            <delta_ts>2006-10-09 12:16:16 +0000</delta_ts>
            <desc>Patch as described.</desc>
            <filename>30_kwin.diff</filename>
            <type>text/plain</type>
            <size>6692</size>
            <attacher name="Sune Vuorela">debian</attacher>
            
              <data encoding="base64">ZGlmZiAtdSBrZGViYXNlLTMuNS40LnVucGF0Y2hlZC9rd2luL2NsaWVudC5jcHAga2RlYmFzZS0z
LjUuNC51bnBhdGNoZWQva3dpbi9jbGllbnQuY3BwCi0tLSBrZGViYXNlLTMuNS40LnVucGF0Y2hl
ZC9rd2luL2NsaWVudC5jcHAJMjAwNi0wNS0yMiAyMDoxMzowMS4wMDAwMDAwMDAgKzAyMDAKKysr
IGtkZWJhc2UtMy41LjQudW5wYXRjaGVkL2t3aW4vY2xpZW50LmNwcAkyMDA2LTA1LTIyIDIwOjEz
OjAxLjAwMDAwMDAwMCArMDIwMApAQCAtMjcyLDcgKzI3MSw2IEBACiAgICAgICAgIGRlc3Ryb3lE
ZWNvcmF0aW9uKCk7CiAgICAgaWYoICFub0JvcmRlcigpKQogICAgICAgICB7Ci0gICAgICAgIHNl
dE1hc2soIFFSZWdpb24oKSk7IC8vIHJlc2V0IHNoYXBlIG1hc2sKICAgICAgICAgZGVjb3JhdGlv
biA9IHdvcmtzcGFjZSgpLT5jcmVhdGVEZWNvcmF0aW9uKCBicmlkZ2UgKTsKICAgICAgICAgLy8g
VE9ETyBjaGVjayBkZWNvcmF0aW9uJ3MgbWluaW11bSBzaXplPwogICAgICAgICBkZWNvcmF0aW9u
LT5pbml0KCk7CkBAIC01MDYsNyArNTA0LDYgQEAKICAgICAgICAgICAgIHhyZWN0cywgcmVjdHMu
Y291bnQoKSwgU2hhcGVTZXQsIG1vZGUgKTsKICAgICAgICAgZGVsZXRlW10geHJlY3RzOwogICAg
ICAgICB9Ci0gICAgdXBkYXRlU2hhcGUoKTsKICAgICB9CiAKIFFSZWdpb24gQ2xpZW50OjptYXNr
KCkgY29uc3QKZGlmZiAtTmF1ciBrZGViYXNlLTMuNS41L2t3aW4vY2xpZW50LmNwcCBrZGViYXNl
LTMuNS40LnVucGF0Y2hlZC9rd2luL2NsaWVudC5jcHAKLS0tIGtkZWJhc2UtMy41LjUva3dpbi9j
bGllbnQuY3BwCTIwMDYtMTAtMDEgMTk6MzI6MDcuMDAwMDAwMDAwICswMjAwCisrKyBrZGViYXNl
LTMuNS40LnVucGF0Y2hlZC9rd2luL2NsaWVudC5jcHAJMjAwNi0wNS0yMiAyMDoxMzowMS4wMDAw
MDAwMDAgKzAyMDAKQEAgLTQ2MCwzNSArNDU4LDI0IEBACiAKIHZvaWQgQ2xpZW50Ojp1cGRhdGVT
aGFwZSgpCiAgICAgeworICAgIHNldFNoYXBhYmxlKFRSVUUpOworICAgIGlmICggc2hhcGUoKSAp
CisgICAgeworICAgICAgICBYU2hhcGVDb21iaW5lU2hhcGUocXRfeGRpc3BsYXkoKSwgZnJhbWVJ
ZCgpLCBTaGFwZUJvdW5kaW5nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgY2xpZW50UG9z
KCkueCgpLCBjbGllbnRQb3MoKS55KCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICB3aW5k
b3coKSwgU2hhcGVCb3VuZGluZywgU2hhcGVTZXQpOworICAgIH0KKyAgICBlbHNlCisgICAgewor
ICAgICAgICBYU2hhcGVDb21iaW5lTWFzayggcXRfeGRpc3BsYXkoKSwgZnJhbWVJZCgpLCBTaGFw
ZUJvdW5kaW5nLCAwLCAwLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgTm9uZSwgU2hhcGVT
ZXQpOworICAgIH0KICAgICAvLyB3b3JrYXJvdW5kIGZvciAjMTk2NDQgLSBzaGFwZWQgd2luZG93
cyBzaG91bGRuJ3QgaGF2ZSBkZWNvcmF0aW9uCiAgICAgaWYoIHNoYXBlKCkgJiYgIW5vQm9yZGVy
KCkpIAogICAgICAgICB7CiAgICAgICAgIG5vYm9yZGVyID0gdHJ1ZTsKICAgICAgICAgdXBkYXRl
RGVjb3JhdGlvbiggdHJ1ZSApOwogICAgICAgICB9Ci0gICAgaWYgKCBzaGFwZSgpICkKLSAgICAg
ICAgewotICAgICAgICBYU2hhcGVDb21iaW5lU2hhcGUocXRfeGRpc3BsYXkoKSwgZnJhbWVJZCgp
LCBTaGFwZUJvdW5kaW5nLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgY2xpZW50UG9zKCku
eCgpLCBjbGllbnRQb3MoKS55KCksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICB3aW5kb3co
KSwgU2hhcGVCb3VuZGluZywgU2hhcGVTZXQpOwotICAgICAgICBzZXRTaGFwYWJsZShUUlVFKTsK
LSAgICAgICAgfQotICAgIC8vICFzaGFwZSgpIG1hc2sgc2V0dGluZyBpcyBkb25lIGluIHNldE1h
c2soKSB3aGVuIHRoZSBkZWNvcmF0aW9uCi0gICAgLy8gY2FsbHMgaXQgb3Igd2hlbiB0aGUgZGVj
b3JhdGlvbiBpcyBjcmVhdGVkL2Rlc3Ryb3llZAotCi0gICAgaWYoIFNoYXBlOjp2ZXJzaW9uKCkg
Pj0gMHgxMSApIC8vIDEuMSwgaGFzIGlucHV0IHNoYXBlIHN1cHBvcnQKLSAgICAgICAgeyAvLyB0
aGVyZSBhcHBlYXJzIHRvIGJlIG5vIHdheSB0byBmaW5kIG91dCBpZiBhIHdpbmRvdyBoYXMgaW5w
dXQKLSAgICAgICAgICAvLyBzaGFwZSBzZXQgb3Igbm90LCBzbyBhbHdheXMgc2V0IHByb3BhZ2F0
ZSB0aGUgaW5wdXQgc2hhcGUKLSAgICAgICAgICAvLyAoaXQncyB0aGUgc2FtZSBsaWtlIHRoZSBi
b3VuZGluZyBzaGFwZSBieSBkZWZhdWx0KQotICAgICAgICBYU2hhcGVDb21iaW5lU2hhcGUoIHF0
X3hkaXNwbGF5KCksIGZyYW1lSWQoKSwgU2hhcGVJbnB1dCwgMCwgMCwKLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGZyYW1lSWQoKSwgU2hhcGVCb3VuZGluZywgU2hhcGVTZXQgKTsKLSAgICAg
ICAgWFNoYXBlQ29tYmluZVNoYXBlKCBxdF94ZGlzcGxheSgpLCBmcmFtZUlkKCksIFNoYXBlSW5w
dXQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBjbGllbnRQb3MoKS54KCksIGNsaWVudFBv
cygpLnkoKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIHdpbmRvdygpLCBTaGFwZUJvdW5k
aW5nLCBTaGFwZVN1YnRyYWN0ICk7Ci0gICAgICAgIFhTaGFwZUNvbWJpbmVTaGFwZSggcXRfeGRp
c3BsYXkoKSwgZnJhbWVJZCgpLCBTaGFwZUlucHV0LAotICAgICAgICAgICAgICAgICAgICAgICAg
ICAgY2xpZW50UG9zKCkueCgpLCBjbGllbnRQb3MoKS55KCksCi0gICAgICAgICAgICAgICAgICAg
ICAgICAgICB3aW5kb3coKSwgU2hhcGVJbnB1dCwgU2hhcGVVbmlvbiApOwotICAgICAgICB9CiAg
ICAgfQogCiB2b2lkIENsaWVudDo6c2V0TWFzayggY29uc3QgUVJlZ2lvbiYgcmVnLCBpbnQgbW9k
ZSApCmRpZmYgLU5hdXIga2RlYmFzZS0zLjUuNS9rd2luL2dlb21ldHJ5LmNwcCBrZGViYXNlLTMu
NS40LnVucGF0Y2hlZC9rd2luL2dlb21ldHJ5LmNwcAotLS0ga2RlYmFzZS0zLjUuNS9rd2luL2dl
b21ldHJ5LmNwcAkyMDA2LTEwLTAxIDE5OjMyOjA3LjAwMDAwMDAwMCArMDIwMAorKysga2RlYmFz
ZS0zLjUuNC51bnBhdGNoZWQva3dpbi9nZW9tZXRyeS5jcHAJMjAwNi0wNy0yMiAxMDoxNTo1NC4w
MDAwMDAwMDAgKzAyMDAKQEAgLTE3MDksNyArMTcwOSw4IEBACiAgICAgICAgICAgICBjcy53aWR0
aCgpLCBjcy5oZWlnaHQoKSk7CiAgICAgICAgIFhNb3ZlUmVzaXplV2luZG93KCBxdF94ZGlzcGxh
eSgpLCB3aW5kb3coKSwgMCwgMCwgY3Mud2lkdGgoKSwgY3MuaGVpZ2h0KCkpOwogICAgICAgICB9
Ci0gICAgdXBkYXRlU2hhcGUoKTsKKyAgICBpZiggc2hhcGUoKSkKKyAgICAgICAgdXBkYXRlU2hh
cGUoKTsKICAgICAvLyBTRUxJIFRPRE8gd29uJ3QgdGhpcyBiZSB0b28gZXhwZW5zaXZlPwogICAg
IHVwZGF0ZVdvcmthcmVhRGlmZnMoKTsKICAgICBzZW5kU3ludGhldGljQ29uZmlndXJlTm90aWZ5
KCk7CkBAIC0xNzYzLDcgKzE3NjQsOCBAQAogICAgICAgICAgICAgY3Mud2lkdGgoKSwgY3MuaGVp
Z2h0KCkpOwogICAgICAgICBYTW92ZVJlc2l6ZVdpbmRvdyggcXRfeGRpc3BsYXkoKSwgd2luZG93
KCksIDAsIDAsIGNzLndpZHRoKCksIGNzLmhlaWdodCgpKTsKICAgICAgICAgfQotICAgIHVwZGF0
ZVNoYXBlKCk7CisgICAgaWYoIHNoYXBlKCkpCisgICAgICAgIHVwZGF0ZVNoYXBlKCk7CiAgICAg
dXBkYXRlV29ya2FyZWFEaWZmcygpOwogICAgIHNlbmRTeW50aGV0aWNDb25maWd1cmVOb3RpZnko
KTsKICAgICB1cGRhdGVXaW5kb3dSdWxlcygpOwpkaWZmIC1OYXVyIGtkZWJhc2UtMy41LjUva3dp
bi9tYW5hZ2UuY3BwIGtkZWJhc2UtMy41LjQudW5wYXRjaGVkL2t3aW4vbWFuYWdlLmNwcAotLS0g
a2RlYmFzZS0zLjUuNS9rd2luL21hbmFnZS5jcHAJMjAwNi0xMC0wMSAxOTozMjowNy4wMDAwMDAw
MDAgKzAyMDAKKysrIGtkZWJhc2UtMy41LjQudW5wYXRjaGVkL2t3aW4vbWFuYWdlLmNwcAkyMDA2
LTA3LTIyIDEwOjE1OjU0LjAwMDAwMDAwMCArMDIwMApAQCAtMzE2LDggKzMxNiwxMiBAQAogICAg
ICAgICBrZWVwSW5BcmVhKCBhcmVhLCBwYXJ0aWFsX2tlZXBfaW5fYXJlYSApOwogCiAgICAgWFNo
YXBlU2VsZWN0SW5wdXQoIHF0X3hkaXNwbGF5KCksIHdpbmRvdygpLCBTaGFwZU5vdGlmeU1hc2sg
KTsKLSAgICBpc19zaGFwZSA9IFNoYXBlOjpoYXNTaGFwZSggd2luZG93KCkpOwotICAgIHVwZGF0
ZVNoYXBlKCk7CisgICAgaWYgKCAoaXNfc2hhcGUgPSBTaGFwZTo6aGFzU2hhcGUoIHdpbmRvdygp
KSkgKSAKKyAgICAgICAgeworICAgICAgICB1cGRhdGVTaGFwZSgpOworICAgICAgICB9CisvLyAg
ICBlbHNlCisvLwlzZXRTaGFwYWJsZShGQUxTRSk7CiAJCiAgICAgLy9DVCBleHRyYSBjaGVjayBm
b3Igc3R1cGlkIGpkayAxLjMuMS4gQnV0IHNob3VsZCBtYWtlIHNlbnNlIGluIGdlbmVyYWwKICAg
ICAvLyBpZiBjbGllbnQgaGFzIGluaXRpYWwgc3RhdGUgc2V0IHRvIEljb25pYyBhbmQgaXMgdHJh
bnNpZW50IHdpdGggYSBwYXJlbnQKZGlmZiAtTmF1ciBrZGViYXNlLTMuNS41L2t3aW4vdXRpbHMu
Y3BwIGtkZWJhc2UtMy41LjQudW5wYXRjaGVkL2t3aW4vdXRpbHMuY3BwCi0tLSBrZGViYXNlLTMu
NS41L2t3aW4vdXRpbHMuY3BwCTIwMDYtMTAtMDEgMTk6MzI6MDcuMDAwMDAwMDAwICswMjAwCisr
KyBrZGViYXNlLTMuNS40LnVucGF0Y2hlZC9rd2luL3V0aWxzLmNwcAkyMDA2LTA1LTIyIDIwOjEz
OjAxLjAwMDAwMDAwMCArMDIwMApAQCAtNDQsNyArNDQsNyBAQAogLy8gdXNlZCB0byBzdG9yZSB0
aGUgcmV0dXJuIHZhbHVlcyBvZgogLy8gWFNoYXBlUXVlcnlFeHRlbnNpb24uCiAvLyBOZWNlc3Nh
cnkgc2luY2Ugc2hhcGVkIHdpbmRvdyBhcmUgYW4gZXh0ZW5zaW9uIHRvIFgKLWludCBTaGFwZTo6
a3dpbl9zaGFwZV92ZXJzaW9uID0gMDsKK2ludCBTaGFwZTo6a3dpbl9oYXNfc2hhcGUgPSAwOwog
aW50IFNoYXBlOjprd2luX3NoYXBlX2V2ZW50ID0gMDsKIAogLy8gZG9lcyB0aGUgd2luZG93IHcg
IG5lZWQgYSBzaGFwZSBjb21iaW5lIG1hc2sgYXJvdW5kIGl0PwpAQCAtNTMsNyArNTMsNyBAQAog
ICAgIGludCB4d3MsIHl3cywgeGJzLCB5YnM7CiAgICAgdW5zaWduZWQgaW50IHd3cywgaHdzLCB3
YnMsIGhiczsKICAgICBpbnQgYm91bmRpbmdTaGFwZWQgPSAwLCBjbGlwU2hhcGVkID0gMDsKLSAg
ICBpZiAoIWF2YWlsYWJsZSgpKQorICAgIGlmICgha3dpbl9oYXNfc2hhcGUpCiAgICAgICAgIHJl
dHVybiBGQUxTRTsKICAgICBYU2hhcGVRdWVyeUV4dGVudHMocXRfeGRpc3BsYXkoKSwgdywKICAg
ICAgICAgICAgICAgICAgICAgICAgJmJvdW5kaW5nU2hhcGVkLCAmeHdzLCAmeXdzLCAmd3dzLCAm
aHdzLApAQCAtNjgsMTQgKzY4LDkgQEAKIAogdm9pZCBTaGFwZTo6aW5pdCgpCiAgICAgewotICAg
IGt3aW5fc2hhcGVfdmVyc2lvbiA9IDA7CiAgICAgaW50IGR1bW15OwotICAgIGlmKCAhWFNoYXBl
UXVlcnlFeHRlbnNpb24ocXRfeGRpc3BsYXkoKSwgJmt3aW5fc2hhcGVfZXZlbnQsICZkdW1teSkp
Ci0gICAgICAgIHJldHVybjsKLSAgICBpbnQgbWFqb3IsIG1pbm9yOwotICAgIGlmKCAhWFNoYXBl
UXVlcnlWZXJzaW9uKCBxdF94ZGlzcGxheSgpLCAmbWFqb3IsICZtaW5vciApKQotICAgICAgICBy
ZXR1cm47Ci0gICAga3dpbl9zaGFwZV92ZXJzaW9uID0gbWFqb3IgKiAweDEwICsgbWlub3I7Cisg
ICAga3dpbl9oYXNfc2hhcGUgPQorICAgICAgWFNoYXBlUXVlcnlFeHRlbnNpb24ocXRfeGRpc3Bs
YXkoKSwgJmt3aW5fc2hhcGVfZXZlbnQsICZkdW1teSk7CiAgICAgfQogCiB2b2lkIE1vdGlmOjpy
ZWFkRmxhZ3MoIFdJZCB3LCBib29sJiBub2JvcmRlciwgYm9vbCYgcmVzaXplLCBib29sJiBtb3Zl
LApkaWZmIC1OYXVyIGtkZWJhc2UtMy41LjUva3dpbi91dGlscy5oIGtkZWJhc2UtMy41LjQudW5w
YXRjaGVkL2t3aW4vdXRpbHMuaAotLS0ga2RlYmFzZS0zLjUuNS9rd2luL3V0aWxzLmgJMjAwNi0x
MC0wMSAxOTozMjowNy4wMDAwMDAwMDAgKzAyMDAKKysrIGtkZWJhc2UtMy41LjQudW5wYXRjaGVk
L2t3aW4vdXRpbHMuaAkyMDA2LTA1LTIyIDIwOjEzOjAxLjAwMDAwMDAwMCArMDIwMApAQCAtMTEx
LDIxICsxMTEsMTUgQEAKIGNsYXNzIFNoYXBlIAogICAgIHsKICAgICBwdWJsaWM6Ci0gICAgICAg
IHN0YXRpYyBib29sIGF2YWlsYWJsZSgpIHsgcmV0dXJuIGt3aW5fc2hhcGVfdmVyc2lvbiA+IDA7
IH0KLSAgICAgICAgc3RhdGljIGludCB2ZXJzaW9uKCkgeyByZXR1cm4ga3dpbl9zaGFwZV92ZXJz
aW9uOyB9IC8vIGFzIDE2Km1ham9yK21pbm9yLCBpLmUuIHR3byBoZXggZGlnaXRzCisgICAgICAg
IHN0YXRpYyBib29sIGF2YWlsYWJsZSgpIHsgcmV0dXJuIGt3aW5faGFzX3NoYXBlOyB9CiAgICAg
ICAgIHN0YXRpYyBib29sIGhhc1NoYXBlKCBXSWQgdyk7CiAgICAgICAgIHN0YXRpYyBpbnQgc2hh
cGVFdmVudCgpOwogICAgICAgICBzdGF0aWMgdm9pZCBpbml0KCk7CiAgICAgcHJpdmF0ZToKLSAg
ICAgICAgc3RhdGljIGludCBrd2luX3NoYXBlX3ZlcnNpb247CisgICAgICAgIHN0YXRpYyBpbnQg
a3dpbl9oYXNfc2hhcGU7CiAgICAgICAgIHN0YXRpYyBpbnQga3dpbl9zaGFwZV9ldmVudDsKICAg
ICB9OwogCi0vLyBjb21waWxlIHdpdGggWFNoYXBlIG9sZGVyIHRoYW4gMS4wCi0jaWZuZGVmIFNo
YXBlSW5wdXQKLWNvbnN0IGludCBTaGFwZUlucHV0ID0gMjsKLSNlbmRpZgotCiBjbGFzcyBNb3Rp
ZiAKICAgICB7CiAgICAgcHVibGljOgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>18066</attachid>
            <date>2006-10-09 12:16:16 +0000</date>
            <delta_ts>2006-10-09 12:16:16 +0000</delta_ts>
            <desc>kwin/client.cpp patch</desc>
            <filename>client.cpp.patch</filename>
            <type>text/plain</type>
            <size>2355</size>
            <attacher name="Lubos Lunak">l.lunak</attacher>
            
              <data encoding="base64">LS0tIGNsaWVudC5jcHAuc2F2CTIwMDYtMTAtMDkgMTI6MDY6MDAuMDAwMDAwMDAwICswMjAwCisr
KyBjbGllbnQuY3BwCTIwMDYtMTAtMDkgMTI6MTQ6NDcuMDAwMDAwMDAwICswMjAwCkBAIC00Nzcs
MTcgKzQ3NywzMCBAQCB2b2lkIENsaWVudDo6dXBkYXRlU2hhcGUoKQogICAgIC8vIGNhbGxzIGl0
IG9yIHdoZW4gdGhlIGRlY29yYXRpb24gaXMgY3JlYXRlZC9kZXN0cm95ZWQKIAogICAgIGlmKCBT
aGFwZTo6dmVyc2lvbigpID49IDB4MTEgKSAvLyAxLjEsIGhhcyBpbnB1dCBzaGFwZSBzdXBwb3J0
Ci0gICAgICAgIHsgLy8gdGhlcmUgYXBwZWFycyB0byBiZSBubyB3YXkgdG8gZmluZCBvdXQgaWYg
YSB3aW5kb3cgaGFzIGlucHV0Ci0gICAgICAgICAgLy8gc2hhcGUgc2V0IG9yIG5vdCwgc28gYWx3
YXlzIHNldCBwcm9wYWdhdGUgdGhlIGlucHV0IHNoYXBlCi0gICAgICAgICAgLy8gKGl0J3MgdGhl
IHNhbWUgbGlrZSB0aGUgYm91bmRpbmcgc2hhcGUgYnkgZGVmYXVsdCkKLSAgICAgICAgWFNoYXBl
Q29tYmluZVNoYXBlKCBxdF94ZGlzcGxheSgpLCBmcmFtZUlkKCksIFNoYXBlSW5wdXQsIDAsIDAs
CisgICAgICAgIHsgLy8gVGhlcmUgYXBwZWFycyB0byBiZSBubyB3YXkgdG8gZmluZCBvdXQgaWYg
YSB3aW5kb3cgaGFzIGlucHV0CisgICAgICAgICAgLy8gc2hhcGUgc2V0IG9yIG5vdCwgc28gYWx3
YXlzIHByb3BhZ2F0ZSB0aGUgaW5wdXQgc2hhcGUKKyAgICAgICAgICAvLyAoaXQncyB0aGUgc2Ft
ZSBsaWtlIHRoZSBib3VuZGluZyBzaGFwZSBieSBkZWZhdWx0KS4KKyAgICAgICAgICAvLyBBbHNv
LCBidWlsZCB0aGUgc2hhcGUgdXNpbmcgYSBoZWxwZXIgd2luZG93LCBub3QgZGlyZWN0bHkKKyAg
ICAgICAgICAvLyBpbiB0aGUgZnJhbWUgd2luZG93LCBiZWNhdXNlIHRoZSBzZXF1ZW5jZSBzZXQt
c2hhcGUtdG8tZnJhbWUsCisgICAgICAgICAgLy8gcmVtb3ZlLXNoYXBlLW9mLWNsaWVudCwgYWRk
LWlucHV0LXNoYXBlLW9mLWNsaWVudCBoYXMgdGhlIHByb2JsZW0KKyAgICAgICAgICAvLyB0aGF0
IGFmdGVyIHRoZSBzZWNvbmQgc3RlcCB0aGVyZSdzIGEgaG9sZSBpbiB0aGUgaW5wdXQgc2hhcGUK
KyAgICAgICAgICAvLyB1bnRpbCB0aGUgcmVhbCBzaGFwZSBvZiB0aGUgY2xpZW50IGlzIGFkZGVk
IGFuZCB0aGF0IGNhbiBtYWtlCisgICAgICAgICAgLy8gdGhlIHdpbmRvdyBsb3NlIGZvY3VzICh3
aGljaCBpcyBhIHByb2JsZW0gd2l0aCBtb3VzZSBmb2N1cyBwb2xpY2llcykKKyAgICAgICAgc3Rh
dGljIFdpbmRvdyBoZWxwZXJfd2luZG93ID0gTm9uZTsKKyAgICAgICAgaWYoIGhlbHBlcl93aW5k
b3cgPT0gTm9uZSApCisgICAgICAgICAgICBoZWxwZXJfd2luZG93ID0gWENyZWF0ZVNpbXBsZVdp
bmRvdyggcXRfeGRpc3BsYXkoKSwgcXRfeHJvb3R3aW4oKSwKKyAgICAgICAgICAgICAgICAwLCAw
LCAxLCAxLCAwLCAwLCAwICk7CisgICAgICAgIFhSZXNpemVXaW5kb3coIHF0X3hkaXNwbGF5KCks
IGhlbHBlcl93aW5kb3csIHdpZHRoKCksIGhlaWdodCgpKTsKKyAgICAgICAgWFNoYXBlQ29tYmlu
ZVNoYXBlKCBxdF94ZGlzcGxheSgpLCBoZWxwZXJfd2luZG93LCBTaGFwZUlucHV0LCAwLCAwLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgZnJhbWVJZCgpLCBTaGFwZUJvdW5kaW5nLCBTaGFw
ZVNldCApOwotICAgICAgICBYU2hhcGVDb21iaW5lU2hhcGUoIHF0X3hkaXNwbGF5KCksIGZyYW1l
SWQoKSwgU2hhcGVJbnB1dCwKKyAgICAgICAgWFNoYXBlQ29tYmluZVNoYXBlKCBxdF94ZGlzcGxh
eSgpLCBoZWxwZXJfd2luZG93LCBTaGFwZUlucHV0LAogICAgICAgICAgICAgICAgICAgICAgICAg
ICAgY2xpZW50UG9zKCkueCgpLCBjbGllbnRQb3MoKS55KCksCiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB3aW5kb3coKSwgU2hhcGVCb3VuZGluZywgU2hhcGVTdWJ0cmFjdCApOwotICAgICAg
ICBYU2hhcGVDb21iaW5lU2hhcGUoIHF0X3hkaXNwbGF5KCksIGZyYW1lSWQoKSwgU2hhcGVJbnB1
dCwKKyAgICAgICAgWFNoYXBlQ29tYmluZVNoYXBlKCBxdF94ZGlzcGxheSgpLCBoZWxwZXJfd2lu
ZG93LCBTaGFwZUlucHV0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgY2xpZW50UG9zKCku
eCgpLCBjbGllbnRQb3MoKS55KCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICB3aW5kb3co
KSwgU2hhcGVJbnB1dCwgU2hhcGVVbmlvbiApOworICAgICAgICBYU2hhcGVDb21iaW5lU2hhcGUo
IHF0X3hkaXNwbGF5KCksIGZyYW1lSWQoKSwgU2hhcGVJbnB1dCwgMCwgMCwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGhlbHBlcl93aW5kb3csIFNoYXBlSW5wdXQsIFNoYXBlU2V0ICk7CiAg
ICAgICAgIH0KICAgICB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>