135160 2006-10-05 17:52:01 +0000 [test case] non standard CSS float: right rendering 2006-10-26 21:21:21 +0000 1 1 2 Applications konqueror khtml renderer unspecified Debian testing Linux RESOLVED FIXED NOR normal --- 1 nive konqueror-bugs-null ana 0 oldest_to_newest 474891 0 nive 2006-10-05 17:52:01 +0000 Version: (using KDE KDE 3.5.4) Installed from: Debian testing/unstable Packages On the test page (that will be submitted latter), the 2 boxes should share the same top and right edges (cf. CSS 2.1, 9.5.1: The left outer edge of a left-floating box may not be to the left of the left edge of its containing block. An analogous rule holds for right-floating elements.), in konqueror they don't. Mozilla renders this correctly. [imported from http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=357017] 474892 1 18022 nive 2006-10-05 17:54:37 +0000 Created attachment 18022 HTML test case page 474909 2 kde 2006-10-05 19:21:49 +0000 Confirmed. Might be something to do with adding or subtracting the border width incorrectly.. 478299 3 18194 kde 2006-10-19 20:35:34 +0000 Created attachment 18194 Patch This patch removes the constraints forcing floats not to make left overflow. 480002 4 kde 2006-10-26 21:21:20 +0000 SVN commit 599349 by carewolf: Let floats overflow the left border when they should. BUG:135160 M +7 -4 render_block.cpp --- branches/KDE/3.5/kdelibs/khtml/rendering/render_block.cpp #599348:599349 @@ -1896,7 +1896,6 @@ _height = o->height() + o->marginTop() + o->marginBottom(); f->width = o->width() + o->marginLeft() + o->marginRight(); } - if (fx<0) fx=0; f->left = fx; //kdDebug( 6040 ) << "positioning left aligned float at (" << fx + o->marginLeft() << "/" << y + o->marginTop() << ") fx=" << fx << endl; o->setPos(fx + o->marginLeft(), y + o->marginTop()); @@ -1921,14 +1920,18 @@ _height = o->height() + o->marginTop() + o->marginBottom(); f->width = o->width() + o->marginLeft() + o->marginRight(); } - if (fx<f->width) fx=f->width; f->left = fx - f->width; //kdDebug( 6040 ) << "positioning right aligned float at (" << fx - o->marginRight() - o->width() << "/" << y + o->marginTop() << ")" << endl; o->setPos(fx - o->marginRight() - o->width(), y + o->marginTop()); } - if ( m_layer && style()->hidesOverflow() && (o->xPos()+o->width() > m_overflowWidth) ) - m_overflowWidth = o->xPos()+o->width(); + if ( m_layer && style()->hidesOverflow()) { + if (o->xPos()+o->width() > m_overflowWidth) + m_overflowWidth = o->xPos()+o->width(); + else + if (o->xPos() < m_overflowLeft) + m_overflowLeft = o->xPos(); + } f->startY = y; f->endY = f->startY + _height; 18022 2006-10-05 17:54:37 +0000 2006-10-05 17:54:37 +0000 HTML test case page test.html text/html 302 nive PGh0bWw+Cgo8aGVhZD4KCTxzdHlsZT4KCQlkaXYuYm94MiB7CgkJCWJvcmRlcjogc29saWQgMnB4 IGdyZWVuOwoJCQl3aWR0aDoxMDBweDsKCQkJaGVpZ2h0Ojc1cHg7CgkJfQoJCWRpdi5ib3gzIHsK CQkJYm9yZGVyOiBzb2xpZCAycHggZ3JleTsKCQkJZmxvYXQ6IHJpZ2h0OwoJCQl3aWR0aDoxNTBw eDsKCQkJaGVpZ2h0OjUwcHg7CgkJfQoJPC9zdHlsZT4KPC9oZWFkPgoKPGJvZHk+Cgk8ZGl2IGNs YXNzPSJib3gyIj4KCQk8ZGl2IGNsYXNzPSJib3gzIj4KCQkJbWV1aAoJCTwvZGl2PgoJPC9kaXY+ CjwvYm9keT4KCjwvaHRtbD4= 18194 2006-10-19 20:35:34 +0000 2006-10-19 20:35:34 +0000 Patch float-patch.diff text/plain 1686 kde SW5kZXg6IHJlbmRlcmluZy9yZW5kZXJfYmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmlu Zy9yZW5kZXJfYmxvY2suY3BwCShyZXZpc2lvbiA1OTcyMTYpCisrKyByZW5kZXJpbmcvcmVuZGVy X2Jsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg5Niw3ICsxODk2LDYgQEAKICAgICAgICAg ICAgICAgICBfaGVpZ2h0ID0gby0+aGVpZ2h0KCkgKyBvLT5tYXJnaW5Ub3AoKSArIG8tPm1hcmdp bkJvdHRvbSgpOwogICAgICAgICAgICAgICAgIGYtPndpZHRoID0gby0+d2lkdGgoKSArIG8tPm1h cmdpbkxlZnQoKSArIG8tPm1hcmdpblJpZ2h0KCk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAg ICBpZiAoZng8MCkgZng9MDsKICAgICAgICAgICAgIGYtPmxlZnQgPSBmeDsKICAgICAgICAgICAg IC8va2REZWJ1ZyggNjA0MCApIDw8ICJwb3NpdGlvbmluZyBsZWZ0IGFsaWduZWQgZmxvYXQgYXQg KCIgPDwgZnggKyBvLT5tYXJnaW5MZWZ0KCkgIDw8ICIvIiA8PCB5ICsgby0+bWFyZ2luVG9wKCkg PDwgIikgZng9IiA8PCBmeCA8PCBlbmRsOwogICAgICAgICAgICAgby0+c2V0UG9zKGZ4ICsgby0+ bWFyZ2luTGVmdCgpLCB5ICsgby0+bWFyZ2luVG9wKCkpOwpAQCAtMTkyMSwxNCArMTkyMCwxOCBA QAogICAgICAgICAgICAgICAgIF9oZWlnaHQgPSBvLT5oZWlnaHQoKSArIG8tPm1hcmdpblRvcCgp ICsgby0+bWFyZ2luQm90dG9tKCk7CiAgICAgICAgICAgICAgICAgZi0+d2lkdGggPSBvLT53aWR0 aCgpICsgby0+bWFyZ2luTGVmdCgpICsgby0+bWFyZ2luUmlnaHQoKTsKICAgICAgICAgICAgIH0K LSAgICAgICAgICAgIGlmIChmeDxmLT53aWR0aCkgZng9Zi0+d2lkdGg7CiAgICAgICAgICAgICBm LT5sZWZ0ID0gZnggLSBmLT53aWR0aDsKICAgICAgICAgICAgIC8va2REZWJ1ZyggNjA0MCApIDw8 ICJwb3NpdGlvbmluZyByaWdodCBhbGlnbmVkIGZsb2F0IGF0ICgiIDw8IGZ4IC0gby0+bWFyZ2lu UmlnaHQoKSAtIG8tPndpZHRoKCkgPDwgIi8iIDw8IHkgKyBvLT5tYXJnaW5Ub3AoKSA8PCAiKSIg PDwgZW5kbDsKICAgICAgICAgICAgIG8tPnNldFBvcyhmeCAtIG8tPm1hcmdpblJpZ2h0KCkgLSBv LT53aWR0aCgpLCB5ICsgby0+bWFyZ2luVG9wKCkpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYg KCBtX2xheWVyICYmIHN0eWxlKCktPmhpZGVzT3ZlcmZsb3coKSAmJiAoby0+eFBvcygpK28tPndp ZHRoKCkgPiBtX292ZXJmbG93V2lkdGgpICkKLSAgICAgICAgICAgIG1fb3ZlcmZsb3dXaWR0aCA9 IG8tPnhQb3MoKStvLT53aWR0aCgpOworICAgICAgICBpZiAoIG1fbGF5ZXIgJiYgc3R5bGUoKS0+ aGlkZXNPdmVyZmxvdygpKSB7CisgICAgICAgICAgICBpZiAoby0+eFBvcygpK28tPndpZHRoKCkg PiBtX292ZXJmbG93V2lkdGgpCisgICAgICAgICAgICAgICAgbV9vdmVyZmxvd1dpZHRoID0gby0+ eFBvcygpK28tPndpZHRoKCk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICBpZiAoby0+ eFBvcygpIDwgbV9vdmVyZmxvd0xlZnQpCisgICAgICAgICAgICAgICAgbV9vdmVyZmxvd0xlZnQg PSBvLT54UG9zKCk7CisgICAgICAgIH0KIAogICAgICAgICBmLT5zdGFydFkgPSB5OwogICAgICAg ICBmLT5lbmRZID0gZi0+c3RhcnRZICsgX2hlaWdodDsK