135090 2006-10-04 15:31:57 +0000 Add a [Vector-First] automatic scalar 2006-11-27 10:21:30 +0000 1 1 2 Applications kst general 1.x unspecified Solaris RESOLVED FIXED NOR wishlist --- 1 nicolas.brisset kst 0 oldest_to_newest 474682 0 nicolas.brisset 2006-10-04 15:31:58 +0000 Version: 1.3.0 (using KDE 3.4.0, compiled sources) Compiler: gcc version 3.4.3 OS: SunOS (sun4u) release 5.8 As there is a [Vector-Last] scalar created for each loaded vector, a [Vector-First] scalar containing the first value would be handy. On a side note, what does the -MinPos scalar represent ? Is is supposed to be the index corresponding to the minimum value ? And why is there no MaxPos ? 474695 1 18009 nicolas.brisset 2006-10-04 16:07:52 +0000 Created attachment 18009 Proposed patch Since the request is very similar to bug #88120, I developed something very similar. It seems to work fine, I'll leave it to you to apply after review, though. Note: I'm not sure I understand the purpose of the first _scalars["first"]->setValue(first); line after the loop that checks whether there are NaNs in the vector.. Maybe the line I added there is not appropriate... 474698 2 nicolas.brisset 2006-10-04 16:13:41 +0000 By the way, MinPos is the smallest positive value. There may be other useful values we could add ? I'm thinking particularly about: - index of the min (to e.g. create a label containing the time at which the minimum occurs, provided that time is the X vector and has the same length) - index of the max 474699 3 staikos 2006-10-04 16:18:15 +0000 On Wednesday 04 October 2006 10:07, Nicolas Brisset wrote: > Since the request is very similar to bug #88120, I developed something very > similar. It seems to work fine, I'll leave it to you to apply after review, > though. Looks fine, feel free to commit to trunk if you like. > Note: I'm not sure I understand the purpose of the first > _scalars["first"]->setValue(first); > line after the loop that checks whether there are NaNs in the vector.. > Maybe the line I added there is not appropriate... It's a short-circuit to exit the update early. Notice that it returns if it goes there. 474702 4 nicolas.brisset 2006-10-04 16:25:15 +0000 OK, I'll commit to trunk. I suppose you'll backport it to the 1.3 branch ? Regarding the MinIndex and MaxIndex scalars, are there opinions as to whether we should also add them ? 474704 5 nicolas.brisset 2006-10-04 16:42:45 +0000 SVN commit 592357 by brisset: Add a -First scalar when loading vectors, with the first value of the vector. I think it would be useful to also add -MinIndex and -MaxIndex scalars, so I'll leave the bug open. I have just one question: what happens to these scalars when vectors are interpolated ? CCBUG: 135090 M +8 -2 kstvector.cpp --- trunk/extragear/graphics/kst/src/libkst/kstvector.cpp #592356:592357 @@ -250,6 +250,8 @@ sp->_KShared_ref(); _scalars.insert("last", sp = new KstScalar(tagName() + "-Last", this)); sp->_KShared_ref(); + _scalars.insert("first", sp = new KstScalar(tagName() + "-First", this)); + sp->_KShared_ref(); _scalars.insert("mean", sp = new KstScalar(tagName() + "-Mean", this)); sp->_KShared_ref(); _scalars.insert("sigma", sp = new KstScalar(tagName() + "-Sigma", this)); @@ -272,6 +274,7 @@ _scalars["max"]->setTagName(tagName() + "-Max"); _scalars["min"]->setTagName(tagName() + "-Min"); _scalars["last"]->setTagName(tagName() + "-Last"); + _scalars["first"]->setTagName(tagName() + "-First"); _scalars["mean"]->setTagName(tagName() + "-Mean"); _scalars["sigma"]->setTagName(tagName() + "-Sigma"); _scalars["rms"]->setTagName(tagName() + "-Rms"); @@ -375,11 +378,11 @@ KstObject::UpdateType KstVector::internalUpdate(KstObject::UpdateType providerRC) { int i, i0; - double sum, sum2, last, v; + double sum, sum2, last, first, v; double last_v; double dv2 = 0.0, dv, no_spike_max_dv; - _max = _min = sum = sum2 = _minPos = last = KST::NOPOINT; + _max = _min = sum = sum2 = _minPos = last = first = KST::NOPOINT; _nsum = 0; if (_size > 0) { @@ -398,6 +401,7 @@ _scalars["min"]->setValue(_min); _scalars["minpos"]->setValue(_minPos); _scalars["last"]->setValue(last); + _scalars["first"]->setValue(first); } _ns_max = _ns_min = 0; @@ -460,6 +464,7 @@ _ns_max = _ns_min = last_v = _v[i0]; last = _v[_size-1]; + first = _v[0]; for (i = i0; i < _size; i++) { v = _v[i]; // get rid of redirections @@ -490,6 +495,7 @@ _scalars["min"]->setValue(_min); _scalars["minpos"]->setValue(_minPos); _scalars["last"]->setValue(last); + _scalars["first"]->setValue(first); } updateScalars(); 474718 6 staikos 2006-10-04 17:13:13 +0000 No new features in 1.3.1. It will have to wait for 1.4. 474725 7 nicolas.brisset 2006-10-04 18:01:15 +0000 Looking at the code again, I notice there is a updateScalars method that seems to update some scalar values, e.g. when a vector is blanked or zeroed. It is not clear to me why other scalars are not updated like for instance -Last, and certainly others ? 474728 8 nicolas.brisset 2006-10-04 18:12:26 +0000 Thinking about the use cases for MinIndex and MaxIndex, I realize this is linked with indexed access into vectors (as discussed on the list in July 2005)? Have we eventually gone as far as adding that to the parser ? The idea would be to be able to generate a label like "Min temperature: [Temperature-Min] obtained at @Time[Temperature-MinIndex]" If indexed access into vectors hs been forgotten, I think we should create a new bugzilla entry for it... 474738 9 staikos 2006-10-04 18:37:29 +0000 If you think it is a bug, please test and report it here and we can fix it (and backport those fixes). 489528 10 netterfield 2006-11-25 03:59:46 +0000 The fix for this was committed by Nicholas in October. 489950 11 nicolas.brisset 2006-11-27 10:21:30 +0000 Right, but the first reason I left this open is that I had doubts that all scalars get updated correctly. Looking at the code, it was not obvious as some are handled in internalUpdate() and others in updateScalars(). But I have just had a (quick) look again and it seems to be OK. As far as I remember (non-exhaustive) testing also showed normal results. The second reason was that we could easily add other scalars (see comment #8) that will be very useful as soon as we have indexed access into vectors from labels. I was also wondering if we could benefit performance wise in the drawing code from these scalars ? In any case, the best would probably be to open a separate report for those new scalars. That's what I'll do... 18009 2006-10-04 16:07:52 +0000 2006-10-04 16:07:52 +0000 Proposed patch patch_add_first_scalar.txt text/plain 2261 nicolas.brisset LS0tIGtzdHZlY3Rvci5jcHAub3JpZwkyMDA2LTEwLTA0IDE1OjM4OjExLjMwNDU4MzAwMCArMDIw MAorKysga3N0dmVjdG9yLmNwcAkyMDA2LTEwLTA0IDE1OjQ2OjMwLjE4NTUzMDAwMCArMDIwMApA QCAtMjUwLDYgKzI1MCw4IEBAIHZvaWQgS3N0VmVjdG9yOjpDcmVhdGVTY2FsYXJzKCkgewogICAg IHNwLT5fS1NoYXJlZF9yZWYoKTsKICAgICBfc2NhbGFycy5pbnNlcnQoImxhc3QiLCBzcCA9IG5l dyBLc3RTY2FsYXIodGFnTmFtZSgpICsgIi1MYXN0IiwgdGhpcykpOwogICAgIHNwLT5fS1NoYXJl ZF9yZWYoKTsKKyAgICBfc2NhbGFycy5pbnNlcnQoImZpcnN0Iiwgc3AgPSBuZXcgS3N0U2NhbGFy KHRhZ05hbWUoKSArICItRmlyc3QiLCB0aGlzKSk7CisgICAgc3AtPl9LU2hhcmVkX3JlZigpOwog ICAgIF9zY2FsYXJzLmluc2VydCgibWVhbiIsIHNwID0gbmV3IEtzdFNjYWxhcih0YWdOYW1lKCkg KyAiLU1lYW4iLCB0aGlzKSk7CiAgICAgc3AtPl9LU2hhcmVkX3JlZigpOwogICAgIF9zY2FsYXJz Lmluc2VydCgic2lnbWEiLCBzcCA9IG5ldyBLc3RTY2FsYXIodGFnTmFtZSgpICsgIi1TaWdtYSIs IHRoaXMpKTsKQEAgLTI3Miw2ICsyNzQsNyBAQCB2b2lkIEtzdFZlY3Rvcjo6UmVuYW1lU2NhbGFy cygpIHsKICAgICBfc2NhbGFyc1sibWF4Il0tPnNldFRhZ05hbWUodGFnTmFtZSgpICsgIi1NYXgi KTsKICAgICBfc2NhbGFyc1sibWluIl0tPnNldFRhZ05hbWUodGFnTmFtZSgpICsgIi1NaW4iKTsK ICAgICBfc2NhbGFyc1sibGFzdCJdLT5zZXRUYWdOYW1lKHRhZ05hbWUoKSArICItTGFzdCIpOwor ICAgIF9zY2FsYXJzWyJmaXJzdCJdLT5zZXRUYWdOYW1lKHRhZ05hbWUoKSArICItRmlyc3QiKTsK ICAgICBfc2NhbGFyc1sibWVhbiJdLT5zZXRUYWdOYW1lKHRhZ05hbWUoKSArICItTWVhbiIpOwog ICAgIF9zY2FsYXJzWyJzaWdtYSJdLT5zZXRUYWdOYW1lKHRhZ05hbWUoKSArICItU2lnbWEiKTsK ICAgICBfc2NhbGFyc1sicm1zIl0tPnNldFRhZ05hbWUodGFnTmFtZSgpICsgIi1SbXMiKTsKQEAg LTM3NSwxMSArMzc4LDExIEBAIGJvb2wgS3N0VmVjdG9yOjpyZXNpemUoaW50IHN6LCBib29sIHJl aW4KIAogS3N0T2JqZWN0OjpVcGRhdGVUeXBlIEtzdFZlY3Rvcjo6aW50ZXJuYWxVcGRhdGUoS3N0 T2JqZWN0OjpVcGRhdGVUeXBlIHByb3ZpZGVyUkMpIHsKICAgaW50IGksIGkwOwotICBkb3VibGUg c3VtLCBzdW0yLCBsYXN0LCB2OworICBkb3VibGUgc3VtLCBzdW0yLCBsYXN0LCBmaXJzdCwgdjsK ICAgZG91YmxlIGxhc3RfdjsKICAgZG91YmxlIGR2MiA9IDAuMCwgZHYsIG5vX3NwaWtlX21heF9k djsKICAgCi0gIF9tYXggPSBfbWluID0gc3VtID0gc3VtMiA9IF9taW5Qb3MgPSBsYXN0ID0gS1NU OjpOT1BPSU5UOworICBfbWF4ID0gX21pbiA9IHN1bSA9IHN1bTIgPSBfbWluUG9zID0gbGFzdCA9 IGZpcnN0ID0gS1NUOjpOT1BPSU5UOwogICBfbnN1bSA9IDA7CiAgIAogICBpZiAoX3NpemUgPiAw KSB7CkBAIC0zOTgsNiArNDAxLDcgQEAgS3N0T2JqZWN0OjpVcGRhdGVUeXBlIEtzdFZlY3Rvcjo6 aW50ZXJuYQogICAgICAgICBfc2NhbGFyc1sibWluIl0tPnNldFZhbHVlKF9taW4pOwogICAgICAg ICBfc2NhbGFyc1sibWlucG9zIl0tPnNldFZhbHVlKF9taW5Qb3MpOwogICAgICAgICBfc2NhbGFy c1sibGFzdCJdLT5zZXRWYWx1ZShsYXN0KTsKKyAgICAgICAgX3NjYWxhcnNbImZpcnN0Il0tPnNl dFZhbHVlKGZpcnN0KTsKICAgICAgIH0KICAgICAgIF9uc19tYXggPSBfbnNfbWluID0gMDsKIApA QCAtNDYwLDYgKzQ2NCw3IEBAIEtzdE9iamVjdDo6VXBkYXRlVHlwZSBLc3RWZWN0b3I6OmludGVy bmEKICAgICBfbnNfbWF4ID0gX25zX21pbiA9IGxhc3RfdiA9IF92W2kwXTsKIAogICAgIGxhc3Qg PSBfdltfc2l6ZS0xXTsKKyAgICBmaXJzdCA9IF92WzBdOwogCiAgICAgZm9yIChpID0gaTA7IGkg PCBfc2l6ZTsgaSsrKSB7CiAgICAgICB2ID0gX3ZbaV07IC8vIGdldCByaWQgb2YgcmVkaXJlY3Rp b25zCkBAIC00OTAsNiArNDk1LDcgQEAgS3N0T2JqZWN0OjpVcGRhdGVUeXBlIEtzdFZlY3Rvcjo6 aW50ZXJuYQogICAgICAgX3NjYWxhcnNbIm1pbiJdLT5zZXRWYWx1ZShfbWluKTsKICAgICAgIF9z Y2FsYXJzWyJtaW5wb3MiXS0+c2V0VmFsdWUoX21pblBvcyk7CiAgICAgICBfc2NhbGFyc1sibGFz dCJdLT5zZXRWYWx1ZShsYXN0KTsKKyAgICAgIF9zY2FsYXJzWyJmaXJzdCJdLT5zZXRWYWx1ZShm aXJzdCk7CiAgICAgfQogCiAgICAgdXBkYXRlU2NhbGFycygpOwo=