<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>133584</bug_id>
          
          <creation_ts>2006-09-05 12:15:44 +0000</creation_ts>
          <short_desc>[PATCH] Talkers&apos; names lost in IRC channel logs</short_desc>
          <delta_ts>2008-07-06 11:47:53 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>kopete</product>
          <component>History Plugin</component>
          <version>unspecified</version>
          <rep_platform>Debian testing</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Endel Soolo">endel.soolo</reporter>
          <assigned_to name="Kopete Developers">kopete-bugs-null</assigned_to>
          <cc>aliakc</cc>
    
    <cc>bauerfichtner</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>80</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>466809</commentid>
    <comment_count>0</comment_count>
    <who name="Endel Soolo">endel.soolo</who>
    <bug_when>2006-09-05 12:15:44 +0000</bug_when>
    <thetext>Version:           0.11.3 (using KDE KDE 3.5.4)
Installed from:    Debian testing/unstable Packages
OS:                Linux

The log of a IRC channel shows something like this

(22:02:54) &lt; Hello, John! How are you?
(22:03:55) &lt; Fine, but you?
(22:05:00) &lt; What is going on here?

It does not show who said what.
Channel logs or conference call logs should be shown with names, like this:

(22:02:54) Jack: Hello, John! How are you?
(22:03:55) John: Fine, but you?
(22:05:00) George: What is going on here?

The saved xml log file does already contain talkers&apos; names, so this only affects the log showing part of the program.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>471260</commentid>
    <comment_count>1</comment_count>
    <who name="Bearcat M. Sandor">linux</who>
    <bug_when>2006-09-20 01:13:40 +0000</bug_when>
    <thetext>This has been a bug that has bothered me for quite a while now. I would love to see this fixed.

Id this just a property of the default theme used to view the chat logs?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507744</commentid>
    <comment_count>2</comment_count>
    <who name="Marcin Juszkiewicz">marcin</who>
    <bug_when>2007-02-08 20:08:20 +0000</bug_when>
    <thetext>124753 is probably the same</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>521365</commentid>
    <comment_count>3</comment_count>
    <who name="Pino Toscano">pino</who>
    <bug_when>2007-04-18 13:48:48 +0000</bug_when>
    <thetext>*** Bug 124753 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>521380</commentid>
    <comment_count>4</comment_count>
    <who name="Pino Toscano">pino</who>
    <bug_when>2007-04-18 14:36:36 +0000</bug_when>
    <thetext>*** Bug 87456 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>534126</commentid>
    <comment_count>5</comment_count>
    <who name="Marcin Juszkiewicz">marcin</who>
    <bug_when>2007-06-30 14:26:32 +0000</bug_when>
    <thetext>*** This bug has been confirmed by popular vote. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>575248</commentid>
    <comment_count>6</comment_count>
      <attachid>23275</attachid>
    <who name="Aaron">areichman.kde</who>
    <bug_when>2008-01-25 20:00:54 +0000</bug_when>
    <thetext>Created attachment 23275
Patch to display names in the history plugin viewer

Please let me know what happens to this. My email address is reldruh AT gmail
DOT com. Thank you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>575281</commentid>
    <comment_count>7</comment_count>
      <attachid>23281</attachid>
    <who name="Aaron">areichman.kde</who>
    <bug_when>2008-01-25 21:37:41 +0000</bug_when>
    <thetext>Created attachment 23281
Patch to display names in different colors in the history plugin viewer and no timestamps

This is an improved version of the patch I submitted earlier. It displays the
names in different colors so they can be more easily differentiated. It also
gets rid of the timestamps, although I think there should be a checkbox
somewhere to set that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>620853</commentid>
    <comment_count>8</comment_count>
    <who name="Dennis Nienhüser">nienhueser</who>
    <bug_when>2008-07-06 11:47:53 +0000</bug_when>
    <thetext>SVN commit 828632 by nienhueser:

Add talkers names in history view. Based on Aaron&apos;s patch, thanks for the patch! The fix will be in Kopete 0.60, which will be out with KDE 4.1.
CCMAIL: reldruh@gmail.com
BUG: 133584


 M  +23 -5     historydialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&amp;revision=828632
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>23275</attachid>
            <date>2008-01-25 20:00:54 +0000</date>
            <delta_ts>2008-01-25 20:00:54 +0000</delta_ts>
            <desc>Patch to display names in the history plugin viewer</desc>
            <filename>nicknamesinhistory.diff</filename>
            <type>text/plain</type>
            <size>1046</size>
            <attacher name="Aaron">areichman.kde</attacher>
            
              <data encoding="base64">LS0tIGhpc3RvcnlkaWFsb2cuY3BwCTIwMDgtMDEtMjUgMTA6NTA6MjYuMDAwMDAwMDAwIC0wODAw
CisrKyAvaG9tZS9rZGUtZGV2ZWwva2RlL3NyYy9LREUva2RlbmV0d29yay9rb3BldGUvcGx1Z2lu
cy9oaXN0b3J5L2hpc3RvcnlkaWFsb2cuY3BwCTIwMDgtMDEtMjUgMDA6MjY6MzEuMDAwMDAwMDAw
IC0wODAwCkBAIC0zNjQsOCArMzY0LDggQEAgdm9pZCBIaXN0b3J5RGlhbG9nOjpzZXRNZXNzYWdl
cyhRTGlzdDxLbwogCiAJCQlyZXN1bHRIVE1MICs9ICIoPGI+IiArIG1zZy50aW1lc3RhbXAoKS50
aW1lKCkudG9TdHJpbmcoKSArICI8L2I+KSAiCiAJCQkJKyAobXNnLmRpcmVjdGlvbigpID09IEtv
cGV0ZTo6TWVzc2FnZTo6T3V0Ym91bmQgPwotCQkJCSI8Zm9udCBjb2xvcj1cIiIgKyBLb3BldGU6
OkFwcGVhcmFuY2VTZXR0aW5nczo6c2VsZigpLT5jaGF0VGV4dENvbG9yKCkuZGFyaygpLm5hbWUo
KSArICJcIj48Yj4mZ3Q7PC9iPjwvZm9udD4gIgotCQkJCTogIjxmb250IGNvbG9yPVwiIiArIEtv
cGV0ZTo6QXBwZWFyYW5jZVNldHRpbmdzOjpzZWxmKCktPmNoYXRUZXh0Q29sb3IoKS5saWdodCgy
MDApLm5hbWUoKSArICJcIj48Yj4mbHQ7PC9iPjwvZm9udD4gIikKKwkJCQkiPGZvbnQgY29sb3I9
XCIiICsgS29wZXRlOjpBcHBlYXJhbmNlU2V0dGluZ3M6OnNlbGYoKS0+Y2hhdFRleHRDb2xvcigp
LmRhcmsoKS5uYW1lKCkgKyAiXCI+PGI+IiArIG1zZy5mcm9tKCktPm1ldGFDb250YWN0KCktPmRp
c3BsYXlOYW1lKCkgKyAiOjwvYj48L2ZvbnQ+ICIKKwkJCQk6ICI8Zm9udCBjb2xvcj1cIiIgKyBL
b3BldGU6OkFwcGVhcmFuY2VTZXR0aW5nczo6c2VsZigpLT5jaGF0VGV4dENvbG9yKCkubGlnaHQo
MjAwKS5uYW1lKCkgKyAiXCI+PGI+IiArIG1zZy5mcm9tKCktPm1ldGFDb250YWN0KCktPmRpc3Bs
YXlOYW1lKCkgICsgIjo8L2I+PC9mb250PiAiKQogCQkJCSsgYm9keSArICI8YnIvPiI7CiAKIAkJ
CW5ld05vZGUgPSBtSHRtbFBhcnQtPmRvY3VtZW50KCkuY3JlYXRlRWxlbWVudChRU3RyaW5nOjpm
cm9tTGF0aW4xKCJzcGFuIikpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>23281</attachid>
            <date>2008-01-25 21:37:41 +0000</date>
            <delta_ts>2008-01-25 21:37:41 +0000</delta_ts>
            <desc>Patch to display names in different colors in the history plugin viewer and no timestamps</desc>
            <filename>nicknamesinhistorynotimestampcolored.diff</filename>
            <type>text/plain</type>
            <size>1212</size>
            <attacher name="Aaron">areichman.kde</attacher>
            
              <data encoding="base64">LS0tIGhpc3RvcnlkaWFsb2cuY3BwCTIwMDgtMDEtMjUgMTA6NTA6MjYuMDAwMDAwMDAwIC0wODAw
CisrKyAvaG9tZS9rZGUtZGV2ZWwva2RlL3NyYy9LREUva2RlbmV0d29yay9rb3BldGUvcGx1Z2lu
cy9oaXN0b3J5L2hpc3RvcnlkaWFsb2cuY3BwCTIwMDgtMDEtMjUgMTI6Mjc6MjQuMDAwMDAwMDAw
IC0wODAwCkBAIC0zNjIsMTAgKzM2MiwxMCBAQCB2b2lkIEhpc3RvcnlEaWFsb2c6OnNldE1lc3Nh
Z2VzKFFMaXN0PEtvCiAJCQkJYm9keSA9IGJvZHkucmVwbGFjZShtTWFpbldpZGdldC0+c2VhcmNo
TGluZS0+dGV4dCgpLCAiPHNwYW4gc3R5bGU9XCJiYWNrZ3JvdW5kLWNvbG9yOnllbGxvd1wiPiIg
KyBtTWFpbldpZGdldC0+c2VhcmNoTGluZS0+dGV4dCgpICsgIjwvc3Bhbj4iLCBRdDo6Q2FzZUlu
c2Vuc2l0aXZlKTsKIAkJCX0KIAotCQkJcmVzdWx0SFRNTCArPSAiKDxiPiIgKyBtc2cudGltZXN0
YW1wKCkudGltZSgpLnRvU3RyaW5nKCkgKyAiPC9iPikgIgotCQkJCSsgKG1zZy5kaXJlY3Rpb24o
KSA9PSBLb3BldGU6Ok1lc3NhZ2U6Ok91dGJvdW5kID8KLQkJCQkiPGZvbnQgY29sb3I9XCIiICsg
S29wZXRlOjpBcHBlYXJhbmNlU2V0dGluZ3M6OnNlbGYoKS0+Y2hhdFRleHRDb2xvcigpLmRhcmso
KS5uYW1lKCkgKyAiXCI+PGI+Jmd0OzwvYj48L2ZvbnQ+ICIKLQkJCQk6ICI8Zm9udCBjb2xvcj1c
IiIgKyBLb3BldGU6OkFwcGVhcmFuY2VTZXR0aW5nczo6c2VsZigpLT5jaGF0VGV4dENvbG9yKCku
bGlnaHQoMjAwKS5uYW1lKCkgKyAiXCI+PGI+Jmx0OzwvYj48L2ZvbnQ+ICIpCisJCQlyZXN1bHRI
VE1MICs9IC8qIig8Yj4iICsgbXNnLnRpbWVzdGFtcCgpLnRpbWUoKS50b1N0cmluZygpICsgIjwv
Yj4pICIKKwkJCQkrICovKG1zZy5kaXJlY3Rpb24oKSA9PSBLb3BldGU6Ok1lc3NhZ2U6Ok91dGJv
dW5kID8KKwkJCQkiPGZvbnQgY29sb3I9XCJyZWRcIj48Yj4iICsgbXNnLmZyb20oKS0+bWV0YUNv
bnRhY3QoKS0+ZGlzcGxheU5hbWUoKSArICI6PC9iPjwvZm9udD4gIgorCQkJCTogIjxmb250IGNv
bG9yPVwiYmx1ZVwiPjxiPiIgKyBtc2cuZnJvbSgpLT5tZXRhQ29udGFjdCgpLT5kaXNwbGF5TmFt
ZSgpICArICI6PC9iPjwvZm9udD4gIikKIAkJCQkrIGJvZHkgKyAiPGJyLz4iOwogCiAJCQluZXdO
b2RlID0gbUh0bWxQYXJ0LT5kb2N1bWVudCgpLmNyZWF0ZUVsZW1lbnQoUVN0cmluZzo6ZnJvbUxh
dGluMSgic3BhbiIpKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>