<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>133548</bug_id>
          
          <creation_ts>2006-09-04 16:12:51 +0000</creation_ts>
          <short_desc>When there&apos;s no collection, Context Browser isn&apos;t shown even for streams</short_desc>
          <delta_ts>2006-09-07 01:16:27 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>amarok</product>
          <component>general</component>
          <version>1.4.2</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sebastian Buch">kdebug</reporter>
          <assigned_to name="Amarok Bugs">amarok-bugs-null</assigned_to>
          
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>466597</commentid>
    <comment_count>0</comment_count>
    <who name="Sebastian Buch">kdebug</who>
    <bug_when>2006-09-04 16:12:52 +0000</bug_when>
    <thetext>Version:           1.4.2 (using KDE 3.5.4, Kubuntu Package 4:3.5.4-0ubuntu2~dapper1 )
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-26-386

When using Last.FM it is needed to have a collection of music stored into the program to see . Since I am using Amarok only with a USB-Disk which I mount with the Media-Player-Browser, in my case the collection is not needed.

Please change it so that you are able to see the Kontext Menu even if there is no collection of music.

Thanks a lot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>466610</commentid>
    <comment_count>1</comment_count>
    <who name="Seb Ruiz">ruiz</who>
    <bug_when>2006-09-04 17:10:31 +0000</bug_when>
    <thetext>Amarok won&apos;t function properly without the context browser.

In 1.4.2, you can use the USB disk as a removable drive, as part of a dynamic collection.  When the device gets inserted/removed, then the collection will add/remove the appropriate songs as required automatically.

So, no need to use it as a media device.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>466615</commentid>
    <comment_count>2</comment_count>
    <who name="Sebastian Buch">kdebug</who>
    <bug_when>2006-09-04 17:34:01 +0000</bug_when>
    <thetext>What about users who are only using Amarok for Onlineradio and Last.FM?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>466617</commentid>
    <comment_count>3</comment_count>
    <who name="Sebastian Buch">kdebug</who>
    <bug_when>2006-09-04 17:38:59 +0000</bug_when>
    <thetext>I just removed the Disk and Amarok automatically removes the collection so the &quot;Create Collection Database&quot; is visable again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>466618</commentid>
    <comment_count>4</comment_count>
    <who name="Alexandre Oliveira">aoliveira</who>
    <bug_when>2006-09-04 17:41:01 +0000</bug_when>
    <thetext>Changing the summary... Again...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>467462</commentid>
    <comment_count>5</comment_count>
    <who name="Alexandre Oliveira">aoliveira</who>
    <bug_when>2006-09-07 01:16:27 +0000</bug_when>
    <thetext>SVN commit 581650 by aoliveira:

Let the context browser work with streams, for people without any collection.
BUG: 133548


 M  +12 -8     contextbrowser.cpp  


--- trunk/extragear/multimedia/amarok/src/contextbrowser.cpp #581649:581650
@@ -1076,16 +1076,20 @@
     }
 
     // TODO: Show CurrentTrack or Lyric tab if they were selected
-    if ( m_emptyDB &amp;&amp; CollectionDB::instance()-&gt;isValid() &amp;&amp; !MountPointManager::instance()-&gt;collectionFolders().isEmpty() )
+    // If it&apos;s not a streaming, check for a collection
+    if ( !EngineController::engine()-&gt;isStream() )
     {
-        showScanning();
-        return;
+        if ( m_emptyDB &amp;&amp; CollectionDB::instance()-&gt;isValid() &amp;&amp; !MountPointManager::instance()-&gt;collectionFolders().isEmpty() )
+        {
+            showScanning();
+            return;
+        }
+        else if ( CollectionDB::instance()-&gt;isEmpty() || !CollectionDB::instance()-&gt;isValid() )
+        {
+            showIntroduction();
+            return;
+        }
     }
-    else if ( CollectionDB::instance()-&gt;isEmpty() || !CollectionDB::instance()-&gt;isValid() )
-    {
-        showIntroduction();
-        return;
-    }
     if( !m_dirtyCurrentTrackPage )
         return;
     m_currentURL = EngineController::instance()-&gt;bundle().url();
</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>