133092 2006-08-27 22:30:01 +0000 "Move message to folder" dialog does not accept 'ä' and 'ö' 2008-05-04 17:27:11 +0000 1 1 10 Unmaintained kmail general 1.9.3 Debian testing Linux RESOLVED FIXED NOR normal --- 1 kluge pim-bugs-null larkang 0 oldest_to_newest 463784 0 kluge 2006-08-27 22:30:01 +0000 Version: 1.9.3 (using KDE KDE 3.5.4) Installed from: Debian testing/unstable Packages OS: Linux "Move message to folder" dialog is accessed with the keyboard shortcut 'M'. It allows one to filter folders by typing in a (start of) folder name. However, characters 'ä' and 'ö' are not accepted. These characters are normal and common characters in Finnish, not being able to use them reduces the usefulness of this dialog. While trying out, I found that 'å' is also not accepted. It's not really necessary for me, but some Swedes might appreciate allowing it, too. Of course this problem might affect other non-ASCII characters as well, but these are the ones present on my keyboard. 496231 1 larkang 2006-12-27 13:28:48 +0000 Confirmed here, the problem seems to be in kmfolderseldlg.cpp which only works for ascii characters: void SimpleFolderTree::keyPressEvent( QKeyEvent *e ) { int ch = e->ascii(); if ( ch >= 32 && ch <= 126 ) applyFilter( mFilter + ch ); else if ( ch == 8 || ch == 127 ) { if ( mFilter.length() > 0 ) { mFilter.truncate( mFilter.length()-1 ); applyFilter( mFilter ); } } else KListView::keyPressEvent( e ); } 496303 2 19048 larkang 2006-12-27 18:51:00 +0000 Created attachment 19048 Patch Here's a patch that should fix the problem. Ok to commit? 598613 3 mcguire 2008-05-04 17:27:11 +0000 SVN commit 803952 by tmcguire: Also allow to input umlauts and other printable characters. Based on patch by Richard Lärkäng, thanks! BUG: 133092 M +5 -5 folderselectiontreewidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=803952 19048 2006-12-27 18:51:00 +0000 2006-12-27 18:51:00 +0000 Patch kmail-foldersel.patch text/plain 1048 larkang SW5kZXg6IGttYWlsL2ttZm9sZGVyc2VsZGxnLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBrbWFpbC9rbWZv bGRlcnNlbGRsZy5jcHAJKHJldmlzaW9uIDYxNjk3MykKKysrIGttYWlsL2ttZm9sZGVyc2VsZGxn LmNwcAkoYXJiZXRza29waWEpCkBAIC00MjAsMTggKzQyMCwyMSBAQAogCiAvLy0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCiB2b2lkIFNpbXBsZUZvbGRlclRyZWU6OmtleVByZXNzRXZlbnQoIFFLZXlFdmVu dCAqZSApIHsKLSAgaW50IGNoID0gZS0+YXNjaWkoKTsKLQotICBpZiAoIGNoID49IDMyICYmIGNo IDw9IDEyNiApCi0gICAgYXBwbHlGaWx0ZXIoIG1GaWx0ZXIgKyBjaCApOwotCi0gIGVsc2UgaWYg KCBjaCA9PSA4IHx8IGNoID09IDEyNyApIHsKLSAgICBpZiAoIG1GaWx0ZXIubGVuZ3RoKCkgPiAw ICkgewotICAgICAgbUZpbHRlci50cnVuY2F0ZSggbUZpbHRlci5sZW5ndGgoKS0xICk7Ci0gICAg ICBhcHBseUZpbHRlciggbUZpbHRlciApOworICBRU3RyaW5nIHRleHQgPSBlLT50ZXh0KCk7Cisg IGlmICghdGV4dC5pc0VtcHR5KCkpIHsKKyAgICBjb25zdCBRQ2hhciogY2ggPSB0ZXh0LnVuaWNv ZGUoKTsKKworICAgIGlmICggY2gtPmlzUHJpbnQoKSApCisgICAgICBhcHBseUZpbHRlciggbUZp bHRlciArICpjaCApOworICAgIGVsc2UgaWYgKCAqY2ggPT0gUUNoYXIoOCkgfHwgKmNoID09IFFD aGFyKDEyNykgKSB7CisgICAgICBpZiAoIG1GaWx0ZXIubGVuZ3RoKCkgPiAwICkgeworICAgICAg ICBtRmlsdGVyLnRydW5jYXRlKCBtRmlsdGVyLmxlbmd0aCgpLTEgKTsKKyAgICAgICAgYXBwbHlG aWx0ZXIoIG1GaWx0ZXIgKTsKKyAgICAgIH0KICAgICB9CisgICAgZWxzZQorICAgICAgS0xpc3RW aWV3OjprZXlQcmVzc0V2ZW50KCBlICk7CiAgIH0KLQogICBlbHNlCiAgICAgS0xpc3RWaWV3Ojpr ZXlQcmVzc0V2ZW50KCBlICk7CiB9Cg==