131446 2006-07-27 20:32:44 +0000 using inpainting tool crashes DigiKam 2023-03-23 09:41:40 +0000 1 1 2 Applications digikam Plugin-Editor-GmicQt 0.8.0 Ubuntu Linux RESOLVED FIXED NOR crash --- 1 thomasbasset digikam-bugs-null caulier.gilles 5.8.0 0 oldest_to_newest 456256 0 thomasbasset 2006-07-27 20:32:44 +0000 Version: 0.8.0 (using KDE KDE 3.5.2) Installed from: Ubuntu Packages OS: Linux When I try to use the InPainting plugin for DigiKam, the toolbox opens well. But if I select OK, DigiKam crashes without warning. 456257 1 caulier.gilles 2006-07-27 20:37:00 +0000 Thomas, Give us a suitable backtrace using gdb. You need to re-compile digiKam and DigikamImagePlugins for that using ".configure --enable-debug=full" option. Thanks in advance Gilles Caulier 456373 2 thomasbasset 2006-07-28 15:33:51 +0000 I won't be able to take a look at this until next week but will definitely work on it. 458814 3 17274 thomasbasset 2006-08-07 21:16:59 +0000 Created attachment 17274 backtrace Here is the required backtrace. I recompiled digikam and digikamimageplugins using the following commands: apt-src install X ./configure --enable-debug=full make make install Hope this helps as I can't understand anything about this backtrace ;) 458835 4 marcel.wiesweg 2006-08-07 22:43:53 +0000 Ok, thanks. It seems we need to catch the CImgExceptions which can be thrown from the lib. Another question is why this exception is thrown here. 458854 5 thomasbasset 2006-08-07 23:22:07 +0000 The version that is packaged in Ubuntu is 0.8.2-rc1, not 0.8.0 514675 6 caulier.gilles 2007-03-12 16:38:25 +0000 SVN commit 641782 by cgilles: digikam from trunk : CImg library can generate a C++ exception. Just drive it to prevent digiKam crash. CCBUGS: 131446 M +16 -13 greycstorationiface.cpp --- trunk/extragear/graphics/digikamimageplugins/common/greycstoration/greycstorationiface.cpp #641781:641782 @@ -18,18 +18,9 @@ * * ============================================================ */ - // C Ansi includes - -extern "C" -{ -#include <unistd.h> -} - // C++ includes. -#include <cstdio> -#include <cmath> -#include <cstring> +#include <cassert> // Qt includes. @@ -209,10 +200,22 @@ DDebug() << "GreycstorationIface::Process Computation..." << endl; - //FIXME : add inpainting and resize mode. + try + { + //FIXME : add inpainting and resize mode. + + restoration(); + } + catch(...) // Everything went wrong. + { + DDebug() << "GreycstorationIface::Error during Greycstoration filter computation!" << endl; + + if (m_parent) + postProgress( 0, false, false ); + + return; + } - restoration(); - // Copy CImg onto destination. DDebug() << "GreycstorationIface::Finalization..." << endl; 514856 7 caulier.gilles 2007-03-13 13:12:53 +0000 SVN commit 642127 by cgilles: digiKam from trunk : new version of Photograph Inpainting tool using the new version of CImg library (1.1.9) CCMAIL: David.Tschumperle@greyc.ensicaen.fr CCMAIL: mvoorberg@yahoo.com CCMAIL: gerhard@kulzer.net CCMAIL: digikam-devel@kde.org CCBUG: 131446 M +2 -4 Makefile.am M +49 -230 imageeffect_inpainting.cpp M +19 -43 imageeffect_inpainting.h 514892 8 caulier.gilles 2007-03-13 17:26:48 +0000 SVN commit 642201 by cgilles: digiKam from trunk : Improvement of Photograph Inpainting tool : now this plugin give a preview of effect (like new Red Eyes correction tool). A fresh screenshot can be seen at this url : http://digikam3rdparty.free.fr/Screenshots/newinpaintingtool.png CCMAIL: David.Tschumperle@greyc.ensicaen.fr CCMAIL: mvoorberg@yahoo.com CCMAIL: gerhard@kulzer.net CCMAIL: digikam-devel@kde.org CCBUG: 131446 M +129 -151 imageeffect_inpainting.cpp M +22 -57 imageeffect_inpainting.h M +2 -2 imageplugin_inpainting.cpp 515266 9 caulier.gilles 2007-03-15 15:13:14 +0000 Thomas, With digiKam 0.9.2, the Greycstoration interface handle properlly the C++ Exception generated by Cimg library. I close this file now. Gilles Caulier 1699025 10 caulier.gilles 2017-09-05 05:09:57 +0000 With 5.8.0, in-painting image editor tool was been replaced by a Clone tool. More details here : https://community.kde.org/GSoC/2017/StatusReports/shazaismailkaoud Gilles Caulier 17274 2006-08-07 21:16:59 +0000 2006-08-07 21:16:59 +0000 backtrace output.txt text/plain 1759 thomasbasset UHJvZ3JhbSByZWNlaXZlZCBzaWduYWwgU0lHQUJSVCwgQWJvcnRlZC4KW1N3aXRjaGluZyB0byBU aHJlYWQgLTEyNDc3MDQxNDQgKExXUCAyMTY5NSldCjB4ZmZmZmU0MTAgaW4gX19rZXJuZWxfdnN5 c2NhbGwgKCkKKGdkYikgYnQKIzAgIDB4ZmZmZmU0MTAgaW4gX19rZXJuZWxfdnN5c2NhbGwgKCkK IzEgIDB4YjYzYmQ5YTEgaW4gcmFpc2UgKCkgZnJvbSAvL2xpYi90bHMvaTY4Ni9jbW92L2xpYmMu c28uNgojMiAgMHhiNjNiZjJiOSBpbiBhYm9ydCAoKSBmcm9tIC8vbGliL3Rscy9pNjg2L2Ntb3Yv bGliYy5zby42CiMzICAweGI2NTkxYzFlIGluIF9fZ251X2N4eDo6X192ZXJib3NlX3Rlcm1pbmF0 ZV9oYW5kbGVyICgpCiAgIGZyb20gL3Vzci9saWIvbGlic3RkYysrLnNvLjYKIzQgIDB4YjY1OGY5 MTUgaW4gX19neHhfcGVyc29uYWxpdHlfdjAgKCkgZnJvbSAvdXNyL2xpYi9saWJzdGRjKysuc28u NgojNSAgMHhiNjU4Zjk0YSBpbiBzdGQ6OnRlcm1pbmF0ZSAoKSBmcm9tIC91c3IvbGliL2xpYnN0 ZGMrKy5zby42CiM2ICAweGI2NThmYTdlIGluIF9fY3hhX3Rocm93ICgpIGZyb20gL3Vzci9saWIv bGlic3RkYysrLnNvLjYKIzcgIDB4YjRmNGU1ZmMgaW4gY2ltZ19saWJyYXJ5OjpDSW1nPHVuc2ln bmVkIGNoYXI+Ojpsb2FkX2NvbnZlcnQgKAogICAgZmlsZW5hbWU9MHg4M2QzZTQ4ICIvdG1wL2tk ZS1nb29uLzIxNjYxLnBuZyIpIGF0IENJbWcuaDo3OTMzCiM4ICAweGI0ZjRlM2U2IGluIGNpbWdf bGlicmFyeTo6Q0ltZzx1bnNpZ25lZCBjaGFyPjo6bG9hZCAoCiAgICBmaWxlbmFtZT0weDgzZDNl NDggIi90bXAva2RlLWdvb24vMjE2NjEucG5nIikgYXQgQ0ltZy5oOjczNTYKIzkgIDB4YjRmNGU0 NGIgaW4gQ0ltZyAodGhpcz0weGI1YTE4MDM4LCAKICAgIGZpbGVuYW1lPTB4ODNkM2U0OCAiL3Rt cC9rZGUtZ29vbi8yMTY2MS5wbmciKSBhdCBDSW1nLmg6Mjk3OAojMTAgMHhiNGYyMjc0NyBpbiBE aWdpa2FtSW1hZ2VQbHVnaW5zOjpDaW1nSWZhY2U6OnByZXBhcmVfaW5wYWludCAoCiAgICB0aGlz PTB4ODNlM2I3MCkgYXQgY2ltZ2lmYWNlLmNwcDozNDYKIzExIDB4YjRmMjNhN2YgaW4gRGlnaWth bUltYWdlUGx1Z2luczo6Q2ltZ0lmYWNlOjpwcmVwYXJlICh0aGlzPTB4ODNlM2I3MCkKICAgIGF0 IGNpbWdpZmFjZS5jcHA6Mjc0CiMxMiAweGI0ZjIzYzk0IGluIERpZ2lrYW1JbWFnZVBsdWdpbnM6 OkNpbWdJZmFjZTo6cHJvY2VzcyAodGhpcz0weDgzZTNiNzApCiAgICBhdCBjaW1naWZhY2UuY3Bw OjIxNwojMTMgMHhiNGYyNDJjNiBpbiBEaWdpa2FtSW1hZ2VQbHVnaW5zOjpDaW1nSWZhY2U6OmZp bHRlckltYWdlICh0aGlzPTB4ODNlM2I3MCkKICAgIGF0IGNpbWdpZmFjZS5jcHA6MTc5CiMxNCAw eGI3ZjE1NGZmIGluIERpZ2lrYW06OlRocmVhZGVkRmlsdGVyOjpzdGFydENvbXB1dGF0aW9uICgp CiAgIGZyb20gL3Vzci9saWIvbGliZGlnaWthbS5zby4wCiMxNSAweGI3ZjE1ODRkIGluIERpZ2lr YW06OlRocmVhZGVkRmlsdGVyOjpydW4gKCkgZnJvbSAvdXNyL2xpYi9saWJkaWdpa2FtLnNvLjAK IzE2IDB4YjZiOTlmOWEgaW4gUVRocmVhZEluc3RhbmNlOjpzdGFydCAoKSBmcm9tIC91c3IvbGli L2xpYnF0LW10LnNvLjMKIzE3IDB4YjY2NmMzNDEgaW4gc3RhcnRfdGhyZWFkICgpIGZyb20gLy9s aWIvdGxzL2k2ODYvY21vdi9saWJwdGhyZWFkLnNvLjAKIzE4IDB4YjY0NWU0ZWUgaW4gY2xvbmUg KCkgZnJvbSAvL2xpYi90bHMvaTY4Ni9jbW92L2xpYmMuc28uNgooZ2RiKSBxdWl0Cg==