131242 2006-07-23 16:24:01 +0000 xmlhttprequest breaks on utf-8 strings 2006-08-24 16:19:52 +0000 1 1 2 Applications konqueror kjs unspecified unspecified Linux RESOLVED FIXED NOR normal --- 1 webmaster konqueror-bugs-null 20 oldest_to_newest 455331 0 webmaster 2006-07-23 16:24:01 +0000 Version: 3.5.3 (using KDE 3.5.3, compiled sources) Compiler: gcc version 3.4.6 OS: Linux (i686) release 2.4.31 Might be related to #130234, not sure. XmlHttpRequests containing UTF-8 POST data are not sent correctly. A simple testcase is available here: http://www.robertjohnkaper.com/tmp/kio_utf8.html Works fine in Firefox, but Konqueror messes up and loses input data. 456579 1 jan_mentzel 2006-07-29 16:00:46 +0000 Version: 3.5.3 (using KDE 3.5.3) Compiler: gcc (GCC) 3.4.5 (Gentoo 3.4.5, ssp-3.4.5-1.0, pie-8.7.9) OS: Linux i686 2.6.17-ck1-r2 #1 PREEMPT Same problem here with german "Umlaute". Seems to me as there runs something wrong when konqueror calculates the string length of the utf-8 encoded string. Same problem occures in Safari-2.0.4 if in the request the content-type header is set to something different from "text/javascript". 458973 2 jiri.kaderavek 2006-08-08 11:26:15 +0000 Duplicate bug #119391 462791 3 17476 james_thorniley 2006-08-23 23:34:54 +0000 Created attachment 17476 Patch (fixes test case for me) Attached patch fixes the issue for me 462943 4 jan_mentzel 2006-08-24 14:51:44 +0000 Patch fixes issue for me too. 462955 5 germain 2006-08-24 15:36:38 +0000 SVN commit 576640 by ggarand: apply patch by James Thorniley<james_thorniley@yahoo.co.uk> for "xmlhttprequest breaks on utf-8 strings" BUG:131242 M +1 -1 xmlhttprequest.cpp --- branches/KDE/3.5/kdelibs/khtml/ecma/xmlhttprequest.cpp #576639:576640 @@ -335,7 +335,7 @@ // FIXME: determine post encoding correctly by looking in headers // for charset. QByteArray buf; - buf.duplicate(_body.utf8().data(), _body.length()); + buf.duplicate(_body.utf8().data(), _body.utf8().length()); job = KIO::http_post( url, buf, false ); if(contentType.isNull()) 462971 6 faure 2006-08-24 16:19:52 +0000 SVN commit 576656 by dfaure: Calling utf8() twice is expensive, calling length() on a QCString is expensive, so better not do either one :) CCBUG: 131242 M +2 -1 xmlhttprequest.cpp --- branches/KDE/3.5/kdelibs/khtml/ecma/xmlhttprequest.cpp #576655:576656 @@ -335,7 +335,8 @@ // FIXME: determine post encoding correctly by looking in headers // for charset. QByteArray buf; - buf.duplicate(_body.utf8().data(), _body.utf8().length()); + QCString str = _body.utf8(); + buf.duplicate(str.data(), str.size() - 1); job = KIO::http_post( url, buf, false ); if(contentType.isNull()) 17476 2006-08-23 23:34:54 +0000 2006-08-23 23:34:54 +0000 Patch (fixes test case for me) xmlhttprequest-post-utf8.diff text/plain 538 james_thorniley SW5kZXg6IGtodG1sL2VjbWEveG1saHR0cHJlcXVlc3QuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtodG1s L2VjbWEveG1saHR0cHJlcXVlc3QuY3BwCShyZXZpc2lvbiA1NzU5NzkpCisrKyBraHRtbC9lY21h L3htbGh0dHByZXF1ZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM1LDcgKzMzNSw3IEBACiAg ICAgLy8gRklYTUU6IGRldGVybWluZSBwb3N0IGVuY29kaW5nIGNvcnJlY3RseSBieSBsb29raW5n IGluIGhlYWRlcnMKICAgICAvLyBmb3IgY2hhcnNldC4KICAgICBRQnl0ZUFycmF5IGJ1ZjsKLSAg ICBidWYuZHVwbGljYXRlKF9ib2R5LnV0ZjgoKS5kYXRhKCksIF9ib2R5Lmxlbmd0aCgpKTsKKyAg ICBidWYuZHVwbGljYXRlKF9ib2R5LnV0ZjgoKS5kYXRhKCksIF9ib2R5LnV0ZjgoKS5sZW5ndGgo KSk7CiAKICAgICBqb2IgPSBLSU86Omh0dHBfcG9zdCggdXJsLCBidWYsIGZhbHNlICk7CiAgICAg aWYoY29udGVudFR5cGUuaXNOdWxsKCkpCg==