127696 2006-05-20 05:34:37 +0000 [PATCH] "Unable to complete LIST" operation with invalid messages on server 2008-08-24 18:31:18 +0000 1 1 10 Unmaintained kmail pop3 1.9.1 unspecified Linux RESOLVED FIXED NOR normal --- 1 jbb pim-bugs-null cvevans decibelshelp ilovekde jwork123nl kim mcmanus rdieter sac62 sysadmin 45 oldest_to_newest 440437 0 jbb 2006-05-20 05:34:38 +0000 Version: 1.9.1 (using KDE 3.5.2, compiled sources) Compiler: gcc version 3.4.5 (Gentoo 3.4.5-r1, ssp-3.4.5-1.0, pie-8.7.9) OS: Linux (i686) release 2.6.16-gentoo-r7 I've had a mail message added that causes kmail to fail to retreive any messages. This patch got around the problem but is not correct code. I include it to help pinpoint the problem. I realise that the message on the server was incorrect but I don't believe kmail should fail with this simple error in the data. Also the messagebox itself was a bit misleading as it wasn't failing in the LIST stage but in the UIDL stage. Firstly here's the output from the patch showing the incorrect message. It's message 77 and it doesn't contain a space and second part (message id and address?) kmail: PopAccount:: stage==Uidl <2> kmail: PopAccount:: data=<[37 36 20 3c 32 30 30 36 30 35 31 35 31 30 34 33 2e 35 33 31 39 30 2e 6a 70 65 74 73 6f 40 67 6d 78 2e 61 74 3e 00 0a ]> kmail: PopAccount::qdata=<76 <200605151043.53190.jpetso@gmx.at>> kmail: PopAccount::spc=2 kmail: PopAccount:: stage==Uidl <2> kmail: PopAccount:: data=<[37 37 20 20 00 0a ]> kmail: PopAccount::qdata=<77> kmail: PopAccount::spc=-1 kmail: PopAccount:: spc test failed - stage==2 When this patch is applied it ignores this error and keeps going. As I said not a correct patch, but at least I can read my mail again :-) Cheers, jbb Index: popaccount.cpp =================================================================== --- popaccount.cpp (revision 542622) +++ popaccount.cpp (working copy) @@ -903,8 +903,12 @@ QString qdata = data; qdata = qdata.simplifyWhiteSpace(); // Workaround for Maillennium POP3/UNIBOX int spc = qdata.find( ' ' ); + kdDebug(5006) << "PopAccount:: data=<" << data << ">" << endl; + kdDebug(5006) << "PopAccount::qdata=<" << qdata << ">" << endl; + kdDebug(5006) << "PopAccount::spc=" << spc << endl; if (spc > 0) { if (stage == List) { + kdDebug(5006) << "PopAccount:: stage==List <" << stage << ">" << endl; QString length = qdata.mid(spc+1); if (length.find(' ') != -1) length.truncate(length.find(' ')); int len = length.toInt(); @@ -914,6 +918,7 @@ mMsgsPendingDownload.insert( id, len ); } else { // stage == Uidl + kdDebug(5006) << "PopAccount:: stage==Uidl <" << stage << ">" << endl; const QString id = qdata.left(spc); const QString uid = qdata.mid(spc + 1); int *size = new int; //malloc(size_of(int)); @@ -942,13 +947,18 @@ } } else { - stage = Idle; - if (job) job->kill(); - job = 0; - mSlave = 0; - KMessageBox::error(0, i18n( "Unable to complete LIST operation." ), + kdDebug(5006) << "PopAccount:: spc test failed - stage==" << stage << endl; + if (stage == List) + { + kdDebug(5006) << "PopAccount:: stage==" << stage << endl; + stage = Idle; + if (job) job->kill(); + job = 0; + mSlave = 0; + KMessageBox::error(0, i18n( "Unable to complete LIST operation." ), i18n("Invalid Response From Server")); - return; + return; + } } } 530795 1 mcguire 2007-06-09 14:56:07 +0000 *** Bug 144273 has been marked as a duplicate of this bug. *** 531674 2 mcguire 2007-06-15 15:44:20 +0000 *** Bug 79569 has been marked as a duplicate of this bug. *** 538103 3 mcguire 2007-07-26 17:30:55 +0000 *** Bug 148225 has been marked as a duplicate of this bug. *** 538765 4 mcguire 2007-07-30 19:21:45 +0000 *** Bug 148368 has been marked as a duplicate of this bug. *** 556985 5 ulf.dambacher 2007-11-21 07:47:19 +0000 I have the same bug on 1.9.7. It's very anoying as I always have to delete the message without uidl first, kill the pop3 task and restart kmail before geetting my email!! 556986 6 ulf.dambacher 2007-11-21 07:48:34 +0000 I have the same bug on 1.9.7. It's very anoying as I always have to delete the message without uidl first, kill the pop3 task and restart kmail before geetting my email!! 559738 7 decibelshelp 2007-12-02 23:49:31 +0000 Same issue here. I had to setup Thunderbird until this get's figured out. 565965 8 z_mikowski 2007-12-24 03:43:27 +0000 Same issue here for the last 6 months. Switching to Thunderbird. 566068 9 z_mikowski 2007-12-25 03:43:11 +0000 I should mention my environment: kde3.5.8 on Kubuntu 7.10 (Gutsy Gibbon) Package kdepim-3.5.7enterprise20070926 566069 10 z_mikowski 2007-12-25 03:44:06 +0000 Rebuilding from source now; will report on success or failure 566156 11 z_mikowski 2007-12-26 03:00:45 +0000 Rebuilt packages on Kubuntu 7.10. Results so far excellent. Thunderbird conversion averted, at least for now. Here are the steps: Using: http://www.debian-administration.org/articles/20 apt-get source kmail apt-get build-dep kmail Then I edited kdepim-3.5.7enterprise20070926/kmail/popaccount.cpp as illustrated as above, removing debug output statements: 964 else { 965 if( stage == List ){ 966 stage = Idle; 967 if (job) job->kill(); 968 job = 0; 969 mSlave = 0; 970 KMessageBox::error(0, i18n( "Unable to complete LIST operation." ), 971 i18n("Invalid Response From Server")); 972 return; 973 } 974 } 975 } cd kdepim-3.5.7enterprise20070926 debuild -us -uc cd .. sudo dpkg --install kdepim-3.5.7enterprise20070926.deb 566158 12 z_mikowski 2007-12-26 03:03:08 +0000 make the last line in comment 11: sudo dpkg --install kmail_3.5.7enterprise20070926-0ubuntu2_i386.deb 566172 13 z_mikowski 2007-12-26 05:06:44 +0000 Added for local fix: sudo vi /etc/apt/preferences And add the lines: Package: kmail Pin: origin "" Pin-Priority: 999 This prevents kmail from being overridden by regular updates in debian / ubuntu / kubuntu systems 566864 14 cz 2007-12-29 10:21:12 +0000 thanks john for the patch; at least, it works (finally) again. is there any chance for that patch to make it into the next kmail release, say 1.9.8? i really like kontact, but thats more than just a slight annoyance... 572179 15 23087 mcmanus 2008-01-16 22:50:22 +0000 Created attachment 23087 patch for comment 15 572180 16 mcmanus 2008-01-16 22:51:18 +0000 The issue here is error handling when receiving a blank uid prortion of a UIDL response.. for instance: 1 1200413730.1[CRLF] 2 [CRLF] 3 1200414111.3[CRLF] . [CRLF] will trigger it. John's debug data from the original bug description shows this nicely. it seems some pop server will generate a bogus uidl response like the above based on the email containing an invalid message-id header. I only tested with Dovecot, and could not reproduce that behavior, but forcing the protocol trace with netcat using the above sequence did create a reproduction. If any of the reporters could identify the pop server that is doing that, we could potentially file a bug against the server which is really the root cause here too. In any event, without a valid UIDL identifier the message cannot be persisted on the server - otherwise, everytime a LIST operation occurred there would be no way to know whether or not there was a local copy of this message and we would keep downloading it over and over again. The attached patch * separates error handling for LIST and UIDL operations (removing the confusing error dialog here that casts doubt on LIST un-necessarily) * takes UIDL lines with an ID but without a valid UID portion and forces a download of those messages and a delete from the server * logs a debug message when it is doing this 574043 17 mcmanus 2008-01-22 17:39:00 +0000 I can confirm a server that announces itself as IMPLEMENTATION Openwave Email vM.7.08.02.00 201-2186-121-20061213 exhibits this bug.. and the patch from comment 15 works around it. The website seems to indicate this is legacy closed source, so not much chance it will get repaired on the server end. 574050 18 cz 2008-01-22 17:54:18 +0000 Whether it is a server side error or not, kmail should be able to fetch emails from the worst non standard compliant servers anyways. It cant be that a malformated header forces a mail client to manually delete the message (e.g. via webmail) and restart the client... just my humble opinion... 574161 19 decibelshelp 2008-01-22 22:16:59 +0000 I had not had this error for awhile until couple days ago and again this morning. Went to the server to check each email address and both times it was one or two spam emails. That were left on the servers. Like this morning, Kmail downloaded several emails and then gave me the LIST error. I found the same two spam in two email addresses, no ham present they had been downloaded via Kmail. Deleted both emails in each address and checked server with Kmail again and didn't get any errors. If/when this happens again I could get the email source of each one before deleting to see which one it is. Going to try that next time, will post it if anyone thinks it might help. 574187 20 mcmanus 2008-01-22 23:54:14 +0000 Christian, re comment 18: I agree it should be worked around in the client. That's what the patch in comment 15 does. In a perfect open source world, it would be fixed in the server too - that's why I noted the server. David, re comment 19: the patch in comment #15 should fix that. 575699 21 mcguire 2008-01-27 01:06:29 +0000 SVN commit 766946 by tmcguire: Don't fail when the server sends an invalid UIDL entry. Instead, generate a fake UID for and delete the mail from the server (after downloading it). Based on patch by Patrick McManus <mcmanus at ducksong dot com>. BUG: 127696 M +71 -31 popaccount.cpp M +6 -0 popaccount.h WebSVN link: http://websvn.kde.org/?view=rev&revision=766946 575700 22 mcguire 2008-01-27 01:10:11 +0000 Thanks all for tracking this down and for writing a patch. I've now committed this to trunk, and given that it works OK there, I'll backport it to the 3.5 branch. Please remind me if I haven't done so in two weeks. Sorry for the delay, but the few KMail developers that are there really have a lack of time. 575982 23 hankivy 2008-01-28 01:19:38 +0000 I was able to temporarily work around this problem by accessing my POP3 Server using a different email client, moving an offending message from the inbox folder to another folder created just to hold the message. Then Kmail was able to download all of the other messages. The specific message was not a spam message. I will try to report more later. My email is hankivy@hot.rr.com. 576389 24 hankivy 2008-01-29 18:25:27 +0000 I can log on to my POP3 Server using telnet, and see all of the operations that are normally hidden. I also have an email that can cause this problem to occur when ever desired. Does any experienced POP3 or mail client developer have any suggestions for me to try to duplicate the problem, and collect diagnosic information? 576629 25 mcguire 2008-01-30 17:29:15 +0000 > Does any experienced POP3 or mail client developer have any suggestions for me to try to duplicate the problem, and collect diagnosic information? There is no need to duplicate the problem, we know what the problem is and already fixed it (in trunk, but I'll backport it soon). 579958 26 kevin.kofler 2008-02-13 02:51:08 +0000 2 weeks have passed, how's the backporting going? 580314 27 mcguire 2008-02-14 18:31:37 +0000 >2 weeks have passed, how's the backporting going? Thanks for reminding my. I thought I had backported a week ago, but apparently the commit failed for some reason. I've now backported it to the enterprise branch in rev. 775015. It is to late for 3.5.9 though, which is already tagged. Sorry :( The diff should apply to the 3.5 branch without problems if you want to manually include it in the release. 580457 28 kevin.kofler 2008-02-15 08:23:00 +0000 Thanks, I'll apply this to the Fedora 3.5.9 packages. Shouldn't this be applied to the regular 3.5 branch too? 580545 29 mcguire 2008-02-15 16:00:30 +0000 > Thanks, I'll apply this to the Fedora 3.5.9 packages. Shouldn't this be > applied to the regular 3.5 branch too? Yes, it should. I'm hoping someone who has svnmerge+both branches checked out will do it for me, otherwise I'll do it myself. 580555 30 adam 2008-02-15 16:17:09 +0000 Enterprise changes go into 3.5 automatically, roughly once a week. 640600 31 sac62 2008-08-24 18:31:18 +0000 Interesting. I was trying to figure out why this problem seemed intermittent. I have KMail set not to DL messages from the server so if I make a mistake and delete a message I wanted to keep I can retrieve it. I now realize that my behavior of going directly to my mail server and going through my mail deleting unwanted crap it would solve the problem and KMail would work again. I do not have enough knowledge and understanding of how to apply the patch provided here. I have for many years wanted to use linux but could never understand it enough to make it work. With the development of PC-BSD though I am now allmost a full time user of that OS. I love it and all that comes with it. I must admit I still have to run Windows from time to time when needing print and scan because I still can't get those applications working. May I suggest that the patch be developed for PC-BSD as a PBI for us newbies? Thanks Steve 23087 2008-01-16 22:50:22 +0000 2008-01-16 22:50:22 +0000 patch for comment 15 kmail-patch-127696 text/plain 7272 mcmanus Y29tbWl0IDNjNzQ4ZmRlOWY3MGVlZWRhZjdhMWMxYjJmMjJkYzM1NTI3NjljNDEKQXV0aG9yOiBQ YXRyaWNrIE1jTWFudXMgPG1jbWFudXNAZHVja3NvbmcuY29tPgpEYXRlOiAgIFdlZCBKYW4gMTYg MTY6NDc6MzEgMjAwOCAtMDUwMAoKICAgIGZvciBodHRwOi8vYnVncy5rZGUub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjc2OTYKICAgIAogICAgVGhlIGlzc3VlIGhlcmUgaXMgZXJyb3IgaGFuZGxpbmcg d2hlbiByZWNlaXZpbmcgYSBibGFuayB1aWQgcHJvcnRpb24KICAgIG9mIGEgVUlETCByZXNwb25z ZS4uIGZvciBpbnN0YW5jZToKICAgIAogICAgMSAxMjAwNDEzNzMwLjFbQ1JMRl0KICAgIDIgW0NS TEZdCiAgICAzIDEyMDA0MTQxMTEuM1tDUkxGXQogICAgLiBbQ1JMRl0KICAgIAogICAgd2lsbCB0 cmlnZ2VyIGl0LiBKb2huJ3MgZGVidWcgZGF0YSBmcm9tIHRoZSBvcmlnaW5hbCBidWcgZGVzY3Jp cHRpb24KICAgIHNob3dzIHRoaXMgbmljZWx5LgogICAgCiAgICBpdCBzZWVtcyBzb21lIHBvcCBz ZXJ2ZXIgd2lsbCBnZW5lcmF0ZSBhIGJvZ3VzIHVpZGwgcmVzcG9uc2UgbGlrZSB0aGUKICAgIGFi b3ZlIGJhc2VkIG9uIHRoZSBlbWFpbCBjb250YWluaW5nIGFuIGludmFsaWQgbWVzc2FnZS1pZCBo ZWFkZXIuCiAgICAKICAgIEkgb25seSB0ZXN0ZWQgd2l0aCBEb3ZlY290LCBhbmQgY291bGQgbm90 IHJlcHJvZHVjZSB0aGF0IGJlaGF2aW9yLCBidXQKICAgIGZvcmNpbmcgdGhlIHByb3RvY29sIHRy YWNlIHdpdGggbmV0Y2F0IHVzaW5nIHRoZSBhYm92ZSBzZXF1ZW5jZSBkaWQKICAgIGNyZWF0ZSBh IHJlcHJvZHVjdGlvbi4KICAgIAogICAgSWYgYW55IG9mIHRoZSByZXBvcnRlcnMgY291bGQgaWRl bnRpZnkgdGhlIHBvcCBzZXJ2ZXIgdGhhdCBpcyBkb2luZwogICAgdGhhdCwgd2UgY291bGQgcG90 ZW50aWFsbHkgZmlsZSBhIGJ1ZyBhZ2FpbnN0IHRoZSBzZXJ2ZXIgd2hpY2ggaXMKICAgIHJlYWxs eSB0aGUgcm9vdCBjYXVzZSBoZXJlIHRvby4KICAgIAogICAgSW4gYW55IGV2ZW50LCB3aXRob3V0 IGEgdmFsaWQgVUlETCBpZGVudGlmaWVyIHRoZSBtZXNzYWdlIGNhbm5vdCBiZQogICAgcGVyc2lz dGVkIG9uIHRoZSBzZXJ2ZXIgLSBvdGhlcndpc2UsIGV2ZXJ5dGltZSBhIExJU1Qgb3BlcmF0aW9u CiAgICBvY2N1cnJlZCB0aGVyZSB3b3VsZCBiZSBubyB3YXkgdG8ga25vdyB3aGV0aGVyIG9yIG5v dCB0aGVyZSB3YXMgYQogICAgbG9jYWwgY29weSBvZiB0aGlzIG1lc3NhZ2UgYW5kIHdlIHdvdWxk IGtlZXAgZG93bmxvYWRpbmcgaXQgb3ZlciBhbmQKICAgIG92ZXIgYWdhaW4uCiAgICAKICAgIFRo ZSBhdHRhY2hlZCBwYXRjaAogICAgCiAgICAgKiBzZXBhcmF0ZXMgZXJyb3IgaGFuZGxpbmcgZm9y IExJU1QgYW5kIFVJREwgb3BlcmF0aW9ucyAocmVtb3ZpbmcgdGhlCiAgICAgICBjb25mdXNpbmcg ZXJyb3IgZGlhbG9nIGhlcmUgdGhhdCBjYXN0cyBkb3VidCBvbiBMSVNUCiAgICAgICB1bi1uZWNl c3NhcmlseSkKICAgICAqIHRha2VzIFVJREwgbGluZXMgd2l0aCBhbiBJRCBidXQgd2l0aG91dCBh IHZhbGlkIFVJRCBwb3J0aW9uIGFuZAogICAgICAgZm9yY2VzIGEgZG93bmxvYWQgb2YgdGhvc2Ug bWVzc2FnZXMgYW5kIGEgZGVsZXRlIGZyb20gdGhlIHNlcnZlcgogICAgICogbG9ncyBhIGRlYnVn IG1lc3NhZ2Ugd2hlbiBpdCBpcyBkb2luZyB0aGlzCgpkaWZmIC0tZ2l0IGEva21haWwvcG9wYWNj b3VudC5jcHAgYi9rbWFpbC9wb3BhY2NvdW50LmNwcAppbmRleCAyZjBiMjZjLi42ODkxMTNiIDEw MDY0NAotLS0gYS9rbWFpbC9wb3BhY2NvdW50LmNwcAorKysgYi9rbWFpbC9wb3BhY2NvdW50LmNw cApAQCAtMzg5LDYgKzM4OSw4IEBAIHZvaWQgUG9wQWNjb3VudDo6c3RhcnRKb2IoKQogICBpZHNP Zk1zZ3MuY2xlYXIoKTsKICAgbVVpZEZvcklkTWFwLmNsZWFyKCk7CiAgIGlkc09mTXNnc1RvRGVs ZXRlLmNsZWFyKCk7CisgIGlkc09mRm9yY2VkRGVsZXRlcy5jbGVhcigpOworICAKICAgLy9kZWxl dGUgYW55IGhlYWRlcnMgaWYgdGhlcmUgYXJlIHNvbWUgdGhpcyBoYXZlIHRvIGJlIGRvbmUgYmVj YXVzZSBvZiBjaGVjayBhZ2FpbgogICBoZWFkZXJzT25TZXJ2ZXIuY2xlYXIoKTsKICAgaGVhZGVy cyA9IGZhbHNlOwpAQCAtNzM1LDYgKzczNywxNCBAQCB2b2lkIFBvcEFjY291bnQ6OnNsb3RKb2JG aW5pc2hlZCgpIHsKICAgICAgICAgaWRzT2ZNc2dzVG9EZWxldGUucmVtb3ZlKCBpdC5rZXkoKS5z ZWNvbmQgKTsKICAgICAgIH0KICAgICB9CisgICAgCisgICAgaWYgKCFpZHNPZkZvcmNlZERlbGV0 ZXMuaXNFbXB0eSgpKQorICAgICAgeworCWlkc09mTXNnc1RvRGVsZXRlICs9IGlkc09mRm9yY2Vk RGVsZXRlczsKKwlpZHNPZkZvcmNlZERlbGV0ZXMuY2xlYXIoKTsKKyAgICAgIH0KKyAgICAgIAor CiAgICAgLy8gSWYgdGhlcmUgYXJlIG1lc3NhZ2VzIHRvIGRlbGV0ZSB0aGVuIGRlbGV0ZSB0aGVt CiAgICAgaWYgKCAhaWRzT2ZNc2dzVG9EZWxldGUuaXNFbXB0eSgpICkgewogICAgICAgc3RhZ2Ug PSBEZWxlOwpAQCAtOTIzLDggKzkzMyw5IEBAIHZvaWQgUG9wQWNjb3VudDo6c2xvdERhdGEoIEtJ Tzo6Sm9iKiBqb2IsIGNvbnN0IFFCeXRlQXJyYXkgJmRhdGEpCiAgIFFTdHJpbmcgcWRhdGEgPSBk YXRhOwogICBxZGF0YSA9IHFkYXRhLnNpbXBsaWZ5V2hpdGVTcGFjZSgpOyAvLyBXb3JrYXJvdW5k IGZvciBNYWlsbGVubml1bSBQT1AzL1VOSUJPWAogICBpbnQgc3BjID0gcWRhdGEuZmluZCggJyAn ICk7Ci0gIGlmIChzcGMgPiAwKSB7Ci0gICAgaWYgKHN0YWdlID09IExpc3QpIHsKKyAgCisgIGlm IChzdGFnZSA9PSBMaXN0KSB7CisgICAgaWYgKHNwYyA+IDApIHsKICAgICAgIFFTdHJpbmcgbGVu Z3RoID0gcWRhdGEubWlkKHNwYysxKTsKICAgICAgIGlmIChsZW5ndGguZmluZCgnICcpICE9IC0x KSBsZW5ndGgudHJ1bmNhdGUobGVuZ3RoLmZpbmQoJyAnKSk7CiAgICAgICBpbnQgbGVuID0gbGVu Z3RoLnRvSW50KCk7CkBAIC05MzMsNDYgKzk0NCw4NSBAQCB2b2lkIFBvcEFjY291bnQ6OnNsb3RE YXRhKCBLSU86OkpvYiogam9iLCBjb25zdCBRQnl0ZUFycmF5ICZkYXRhKQogICAgICAgaWRzT2ZN c2dzLmFwcGVuZCggaWQgKTsKICAgICAgIG1Nc2dzUGVuZGluZ0Rvd25sb2FkLmluc2VydCggaWQs IGxlbiApOwogICAgIH0KLSAgICBlbHNlIHsgLy8gc3RhZ2UgPT0gVWlkbAotICAgICAgY29uc3Qg UVN0cmluZyBpZCA9IHFkYXRhLmxlZnQoc3BjKTsKLSAgICAgIGNvbnN0IFFTdHJpbmcgdWlkID0g cWRhdGEubWlkKHNwYyArIDEpOwotICAgICAgaW50ICpzaXplID0gbmV3IGludDsgLy9tYWxsb2Mo c2l6ZV9vZihpbnQpKTsKLSAgICAgICpzaXplID0gbU1zZ3NQZW5kaW5nRG93bmxvYWRbaWRdOwot ICAgICAgbVNpemVPZk5leHRTZWVuTXNnc0RpY3QuaW5zZXJ0KCB1aWQsIHNpemUgKTsKLSAgICAg IGlmICggbVVpZHNPZlNlZW5Nc2dzRGljdC5maW5kKCB1aWQgKSAhPSAwICkgewotCi0gICAgICAg IGlmICggbU1zZ3NQZW5kaW5nRG93bmxvYWQuY29udGFpbnMoIGlkICkgKSB7Ci0gICAgICAgICAg bU1zZ3NQZW5kaW5nRG93bmxvYWQucmVtb3ZlKCBpZCApOwotICAgICAgICB9Ci0gICAgICAgIGVs c2UKLSAgICAgICAgICBrZERlYnVnKDUwMDYpIDw8ICJQb3BBY2NvdW50OjpzbG90RGF0YSBzeW5j aHJvbml6YXRpb24gZmFpbHVyZS4iIDw8IGVuZGw7Ci0gICAgICAgIGlkc09mTXNnc1RvRGVsZXRl LmFwcGVuZCggaWQgKTsKLSAgICAgICAgbVVpZHNPZk5leHRTZWVuTXNnc0RpY3QuaW5zZXJ0KCB1 aWQsIChjb25zdCBpbnQgKikxICk7Ci0gICAgICAgIGlmICggbVRpbWVPZlNlZW5Nc2dzVmVjdG9y LmVtcHR5KCkgKSB7Ci0gICAgICAgICAgbVRpbWVPZk5leHRTZWVuTXNnc01hcC5pbnNlcnQoIHVp ZCwgdGltZSgwKSApOwotICAgICAgICB9Ci0gICAgICAgIGVsc2UgewotICAgICAgICAgIC8vIGNh c3QgdGhlIGludCogd2l0aCBhIGxvbmcgdG8gY2FuIGNvbnZlcnQgaXQgdG8gYSBpbnQsIEJUVwot ICAgICAgICAgIC8vIHdvcmtzIHdpdGggZysrLTQuMCBhbmQgYW1kNjQKLSAgICAgICAgICBtVGlt ZU9mTmV4dFNlZW5Nc2dzTWFwLmluc2VydCggdWlkLAotICAgICAgICAgICAgbVRpbWVPZlNlZW5N c2dzVmVjdG9yWyhpbnQpKCBsb25nICltVWlkc09mU2Vlbk1zZ3NEaWN0W3VpZF0gLSAxXSApOwot ICAgICAgICB9Ci0gICAgICB9Ci0gICAgICBtVWlkRm9ySWRNYXAuaW5zZXJ0KCBpZCwgdWlkICk7 CisgICAgZWxzZSB7CisgICAgICBzdGFnZSA9IElkbGU7CisgICAgICBpZiAoam9iKSBqb2ItPmtp bGwoKTsKKyAgICAgIGpvYiA9IDA7CisgICAgICBtU2xhdmUgPSAwOworICAgIAorICAgICAgS01l c3NhZ2VCb3g6OmVycm9yKDAsIGkxOG4oICJVbmFibGUgdG8gY29tcGxldGUgTElTVCBvcGVyYXRp b24uIiApLAorCQkJIGkxOG4oIkludmFsaWQgUmVzcG9uc2UgRnJvbSBTZXJ2ZXIiKSk7CisgICAg ICByZXR1cm47CQkJCQkKICAgICB9CiAgIH0KLSAgZWxzZSB7Ci0gICAgc3RhZ2UgPSBJZGxlOwot ICAgIGlmIChqb2IpIGpvYi0+a2lsbCgpOwotICAgIGpvYiA9IDA7Ci0gICAgbVNsYXZlID0gMDsK LSAgICBLTWVzc2FnZUJveDo6ZXJyb3IoMCwgaTE4biggIlVuYWJsZSB0byBjb21wbGV0ZSBMSVNU IG9wZXJhdGlvbi4iICksCi0gICAgICAgICAgICAgICAgICAgICAgICAgIGkxOG4oIkludmFsaWQg UmVzcG9uc2UgRnJvbSBTZXJ2ZXIiKSk7Ci0gICAgcmV0dXJuOworICBlbHNlIHsgLy8gc3RhZ2Ug PT0gVWlkbAorICAgIAorICAgIFFfQVNTRVJUICggc3RhZ2UgPT0gVWlkbCk7CisKKyAgICBRU3Ry aW5nIGlkOworICAgIFFTdHJpbmcgdWlkOworICAgIAorICAgIGlmIChzcGMgPD0wKQorICAgICAg eworCS8vIGFuIGludmFsaWQgdWlkbCBsaW5lLi4gd2UgbWlnaHQganVzdCBuZWVkIHRvIHNraXAg aXQsIGJ1dAorCS8vIHNvbWUgc2VydmVycyBnZW5lcmF0ZSBpbnZhbGlkIHVpZHMgd2l0aCB2YWxp ZCBpZHMuLiBpbiB0aGF0CisJLy8gY2FzZSB3ZSB3aWxsIGp1c3QgbWFrZSB1cCBhIHVpZCAtIHdo aWNoIHdpbGwgY2F1c2UgdXMgdG8KKwkvLyBub3QgY2FjaGUgdGhlIGRvY3VtZW50LCBidXQgd2Ug d2lsbCBiZSBhYmxlIHRvIGludGVyb3BlcmF0ZQorCisJaW50IHRlc3RpZCA9IGF0b2kgKHFkYXRh LmFzY2lpKCkpOworCQorCWlmICh0ZXN0aWQgPCAxKQorCSAgeworCSAgICAvLyB3ZSdsbCBqdXN0 IGhhdmUgdG8gc2tpcCB0aGlzCisJICAgIGtkRGVidWcoNTAwNikgPDwgIlBvcEFjY291bnQ6OnNs b3REYXRhIHNraXBwaW5nIFVJREwgZW50cnkgZHVlIHRvIHBhcnNlIGVycm9yICIgPDwgZW5kbCA8 PCBxZGF0YS5hc2NpaSgpIDw8IGVuZGw7CisJICAgIHJldHVybjsKKwkgIH0KKwkKKwlpZC5zZXRO dW0gKHRlc3RpZCwgMTApOworCisJUVN0cmluZyBkYXRlc3RyaW5nLCBzZXJpYWxzdHJpbmc7CisJ CisJc2VyaWFsc3RyaW5nLnNldE51bSAoKytkYXRhQ291bnRlciwxMCk7CisJZGF0ZXN0cmluZy5z ZXROdW0gKHRpbWUoTlVMTCksMTApOworCXVpZCA9IFFTdHJpbmcoInVpZGxnZW4iKSArIGRhdGVz dHJpbmcgKyBRU3RyaW5nKCIuIikgKyBzZXJpYWxzdHJpbmc7CisJCisJa2REZWJ1Zyg1MDA2KSA8 PCAiUG9wQWNjb3VudDo6c2xvdERhdGEgbWVzc2FnZSAiIDw8IGlkLmFzY2lpKCkgPDwgICIlZCBo YXMgYmFkIFVJREwsIGNhbm5vdCBrZWVwIGEgY29weSBvbiBzZXJ2ZXIiIDw8IGVuZGw7CisJaWRz T2ZGb3JjZWREZWxldGVzLmFwcGVuZCggaWQgKTsKKyAgICAgIH0KKyAgICBlbHNlCisgICAgICB7 CisJaWQgPSBxZGF0YS5sZWZ0KHNwYyk7CisJdWlkID0gcWRhdGEubWlkKHNwYyArIDEpOworICAg ICAgfQorICAgIAorICAgIGludCAqc2l6ZSA9IG5ldyBpbnQ7IC8vbWFsbG9jKHNpemVfb2YoaW50 KSk7CisgICAgKnNpemUgPSBtTXNnc1BlbmRpbmdEb3dubG9hZFtpZF07CisgICAgbVNpemVPZk5l eHRTZWVuTXNnc0RpY3QuaW5zZXJ0KCB1aWQsIHNpemUgKTsKKyAgICBpZiAoIG1VaWRzT2ZTZWVu TXNnc0RpY3QuZmluZCggdWlkICkgIT0gMCApIHsKKyAgICAgIAorICAgICAgaWYgKCBtTXNnc1Bl bmRpbmdEb3dubG9hZC5jb250YWlucyggaWQgKSApIHsKKwltTXNnc1BlbmRpbmdEb3dubG9hZC5y ZW1vdmUoIGlkICk7CisgICAgICB9CisgICAgICBlbHNlCisJa2REZWJ1Zyg1MDA2KSA8PCAiUG9w QWNjb3VudDo6c2xvdERhdGEgc3luY2hyb25pemF0aW9uIGZhaWx1cmUuIiA8PCBlbmRsOworICAg ICAgaWRzT2ZNc2dzVG9EZWxldGUuYXBwZW5kKCBpZCApOworICAgICAgbVVpZHNPZk5leHRTZWVu TXNnc0RpY3QuaW5zZXJ0KCB1aWQsIChjb25zdCBpbnQgKikxICk7CisgICAgICBpZiAoIG1UaW1l T2ZTZWVuTXNnc1ZlY3Rvci5lbXB0eSgpICkgeworCW1UaW1lT2ZOZXh0U2Vlbk1zZ3NNYXAuaW5z ZXJ0KCB1aWQsIHRpbWUoMCkgKTsKKyAgICAgIH0KKyAgICAgIGVsc2UgeworCS8vIGNhc3QgdGhl IGludCogd2l0aCBhIGxvbmcgdG8gY2FuIGNvbnZlcnQgaXQgdG8gYSBpbnQsIEJUVworCS8vIHdv cmtzIHdpdGggZysrLTQuMCBhbmQgYW1kNjQKKwltVGltZU9mTmV4dFNlZW5Nc2dzTWFwLmluc2Vy dCggdWlkLAorCQkJCSAgICAgICBtVGltZU9mU2Vlbk1zZ3NWZWN0b3JbKGludCkoIGxvbmcgKW1V aWRzT2ZTZWVuTXNnc0RpY3RbdWlkXSAtIDFdICk7CisgICAgICB9CisgICAgfQorICAgIG1VaWRG b3JJZE1hcC5pbnNlcnQoIGlkLCB1aWQgKTsKICAgfQogfQogCiAKKwogLy8tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQogdm9pZCBQb3BBY2NvdW50OjpzbG90UmVzdWx0KCBLSU86OkpvYiogKQogewpkaWZm IC0tZ2l0IGEva21haWwvcG9wYWNjb3VudC5oIGIva21haWwvcG9wYWNjb3VudC5oCmluZGV4IDg4 NzQzNmEuLjcxOGFjMzEgMTAwNjQ0Ci0tLSBhL2ttYWlsL3BvcGFjY291bnQuaAorKysgYi9rbWFp bC9wb3BhY2NvdW50LmgKQEAgLTE1MCw2ICsxNTAsNyBAQCBwcm90ZWN0ZWQ6CiAgIFFNYXA8UVN0 cmluZywgaW50PiBtVGltZU9mTmV4dFNlZW5Nc2dzTWFwOyAvLyBtYXAgb2YgdWlkIHRvIHRpbWVz IG9mIHNlZW4gbWVzc2FnZXMKICAgUURpY3Q8aW50PiBtU2l6ZU9mTmV4dFNlZW5Nc2dzRGljdDsK ICAgUVN0cmluZ0xpc3QgaWRzT2ZNc2dzVG9EZWxldGU7CisgIFFTdHJpbmdMaXN0IGlkc09mRm9y Y2VkRGVsZXRlczsKICAgaW50IGluZGV4T2ZDdXJyZW50TXNnOwogCiAgIFFWYWx1ZUxpc3Q8S01N ZXNzYWdlKj4gbXNnc0F3YWl0aW5nUHJvY2Vzc2luZzsK