121806 2006-02-12 01:17:52 +0000 special characters in file names reported by slocate are not converted to valid urls 2006-11-25 23:04:35 +0000 1 1 2 Applications kfind general unspecified Compiled Sources Linux RESOLVED FIXED NOR normal --- 0 georg298 coquelle 0 oldest_to_newest 413435 0 georg298 2006-02-12 01:17:52 +0000 Version: (using KDE KDE 3.5.1) Installed from: Compiled From Sources OS: Linux Problem: - have a file name containing a special character like "#" or even worse "/" - have it in your current slocate db (updatedb) - search the directory with kfind where the file is inside using the file index (slocate) - the kfind result contains this file with invalid url Example: "test#%20asdf" is reported as "test" with 0 bytes file size and 0 modification time (=1.1.1970). This comes from incorrect usage of KURL in kquery.cpp KURLs are created directly from the slocate search result (which shows the special characters, e.g. "#"). For example KURL( "/path/to/test#asdf" ) is an invalid url. It should rather be KURL::fromPathOrURL( "/path/to/test#asdf" ). Quotation from KURL reference: KURL KURL::fromPathOrURL ( const QString & text )[static] Creates a KURL object from a QString representing either an absolute path or a real URL. Use this method instead of QString someDir = ... KURL url = someDir; Otherwise some characters (e.g. the '#') won't be encoded properly. 413436 1 14648 georg298 2006-02-12 01:19:10 +0000 Created attachment 14648 fixes the bug for kde 3.5.1 the problem doesn't seem to be solved on current svn. 489674 2 martin 2006-11-25 23:04:34 +0000 SVN commit 607835 by mkoller: BUG: 121806 fix KURL usage with filenames including special chars Patch provided by Georg Hennig M +1 -1 kquery.cpp --- branches/KDE/3.5/kdebase/kfind/kquery.cpp #607834:607835 @@ -153,7 +153,7 @@ for (; it != end; ++it) { - file = new KFileItem( KFileItem::Unknown, KFileItem::Unknown, KURL(*it)); + file = new KFileItem( KFileItem::Unknown, KFileItem::Unknown, KURL::fromPathOrURL(*it)); processQuery(file); delete file; } 14648 2006-02-12 01:19:10 +0000 2006-02-12 01:19:10 +0000 fixes the bug for kde 3.5.1 slocate_special_characters.patch text/plain 442 georg298 ZGlmZiAtdXIga2ZpbmRfb2xkL2txdWVyeS5jcHAga2ZpbmQva3F1ZXJ5LmNwcAotLS0ga2ZpbmRf b2xkL2txdWVyeS5jcHAJMjAwNi0wMi0xMiAwMDozMzo0NS4wMDAwMDAwMDAgKzAxMDAKKysrIGtm aW5kL2txdWVyeS5jcHAJMjAwNi0wMi0xMiAwMDo0NTo0Ni4wMDAwMDAwMDAgKzAxMDAKQEAgLTE1 Miw3ICsxNTIsNyBAQAogCiAgIGZvciAoOyBpdCAhPSBlbmQ7ICsraXQpCiAgIHsKLSAgICBmaWxl ID0gbmV3IEtGaWxlSXRlbSggS0ZpbGVJdGVtOjpVbmtub3duLCAgS0ZpbGVJdGVtOjpVbmtub3du LCBLVVJMKCppdCkpOworICAgIGZpbGUgPSBuZXcgS0ZpbGVJdGVtKCBLRmlsZUl0ZW06OlVua25v d24sICBLRmlsZUl0ZW06OlVua25vd24sIEtVUkw6OmZyb21QYXRoT3JVUkwoKml0KSk7CiAgICAg cHJvY2Vzc1F1ZXJ5KGZpbGUpOwogICAgIGRlbGV0ZSBmaWxlOwogICB9Cg==