120890 2006-01-27 23:44:31 +0000 KMail fails when @ is used in recipient's name 2009-12-24 23:23:20 +0000 1 1 10 Unmaintained kmail general unspecified Gentoo Packages Linux RESOLVED FIXED NOR normal --- 1 flameeyes pim-bugs-null bjoern carlos-spam 0 oldest_to_newest 409409 0 flameeyes 2006-01-27 23:44:31 +0000 Version: (using KDE KDE 3.5.1) Installed from: Gentoo Packages OS: Linux KMail disallow sending mails when the recipient's name contains an "@" character, thinking that is the address that contains two "@". It's easy to reproduce, just try to send a mail setting the To field to "flameeyes\@gentoo.org" <flameeyes@gentoo.org> . While it's rare to be done in actual mail's but it's unfortunately common for an italian webmail to set the default from value to the above example (with the real address of the sender, obviously), thus blocking on reply. 409909 1 14449 flameeyes 2006-01-30 01:25:14 +0000 Created attachment 14449 Proposed patch Okay tonight I found some time and I wrote the attached patch, it's a rewrite of the KPIM::isValidEmailAddress() function, replacing the stateful parser with some regexps. It doesn't seem to decrease performance noticeably, and it does not fail in the situation it was failing before, and mails are sent fine. 426218 2 kouzinopoulos 2006-03-30 21:51:22 +0000 *** Bug 124572 has been marked as a duplicate of this bug. *** 426219 3 kouzinopoulos 2006-03-30 21:52:36 +0000 Hi, can someone please review this patch? 426594 4 kloecker 2006-04-01 00:49:34 +0000 Sorry, but your patch is not acceptable. If you want to know how a regular expression for checking the validity of RFC822 addresses looks like take a look at http://www.ex-parrot.com/~pdw/Mail-RFC822-Address.html. And no, we don't want to have this regular expression in KMail. Please try to fix the parser instead of trying to replace it by something else. 886187 5 bjoern 2009-12-24 23:23:20 +0000 I checked with KDE 4.3. I can send a mail with "flameeyes@gentoo.org" <adress> , so I consider the main problem solved. I cannot send an mail like "flameeyes\@gentoo.org" <adress> , but that's a problem with the backslash. 14449 2006-01-30 01:25:14 +0000 2006-01-30 01:25:14 +0000 Proposed patch kmail-3.5.1-email-addresses.patch text/plain 7094 flameeyes SW5kZXg6IGtkZXBpbS0zLjUuMS9saWJlbWFpbGZ1bmN0aW9ucy9lbWFpbC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0ga2RlcGltLTMuNS4xLm9yaWcvbGliZW1haWxmdW5jdGlvbnMvZW1haWwuY3BwCisrKyBr ZGVwaW0tMy41LjEvbGliZW1haWxmdW5jdGlvbnMvZW1haWwuY3BwCkBAIC0yODEsMTY0ICsyODEs NjggQEAgS1BJTTo6RW1haWxQYXJzZVJlc3VsdCBLUElNOjppc1ZhbGlkRW1haQogICAgIHJldHVy biBBZGRyZXNzRW1wdHk7CiAgIH0KIAotICAvLyBjb3VudCBob3cgbWFueSBAJ3MgYXJlIGluIHRo ZSBzdHJpbmcgdGhhdCBpcyBwYXNzZWQgdG8gdXMKLSAgLy8gaWYgMCBvciA+IDEgdGFrZSBhY3Rp b24KLSAgLy8gYXQgdGhpcyBwb2ludCB0byBtYW55IEAncyBjYW5ub3QgYmFpbCBvdXQgcmlnaHQg YXdheSBzaW5jZQotICAvLyBAIGlzIGFsbG93ZWQgaW4gcW91dGVzLCBzbyB3ZSB1c2UgYSBib29s IHRvIGtlZXAgdHJhY2sKLSAgLy8gYW5kIHRoZW4gbWFrZSBhIGp1ZGdlbWVudCBmdXJ0aGVyIGRv d24gaW4gdGhlIHBhcnNlcgotICAvLyBGSVhNRSBjb3VudCBvbmx5IEAgbm90IGluIGRvdWJsZSBx dW90ZXMKKyAgLy8gRmlyc3Qgb2YgYWxsLCBzY29tcG9zZSB0aGUgc3RyaW5nIHRvIGdldCBhZGRy ZXNzIGFuZCBuYW1lIHBhcnRzLgorICAvLyAtIG5hbWUgcGFydCBjYW4gYmUgYmFzaWNhbGx5IGV2 ZXJ5dGhpbmc7CisgIC8vIC0gYWRkcmVzc2VzIGhhcyB0byBjb250YWluIGV4YWN0bHkgb25lIEAg Y2hhcmFjdGVyCisgIC8vIC0gYWRkcmVzc2VzIGhhcyB0byBjb250YWluIGEgbG9jYWwgcGFydCBh bmQgYSBkb21haW4gcGFydAorICAvLyBUaGUgYWNjZXB0ZWQgZm9ybWF0cyBhcmUgJ2FkZHJlc3Mg KG5hbWUpJywgJ25hbWUgPGFkZHJlc3M+JyBhbmQgJ2FkZHJlc3MnCisgIC8vIGV2ZXJ5dGhpbmcg ZWxzZSBpcyBjb25zaWRlcmVkIGludmFsaWQsIHNvIGluIHRoYXQgY2FzZSB0cnkgdG8gZ3Vlc3Mg c29tZSBvZgorICAvLyB0aGUgY2F1c2VzCisgIFFTdHJpbmcgYWRkcmVzcywgZGlzcGxheU5hbWU7 CisgIAorICBRUmVnRXhwIGZvcm0xKCJeXFxzKihbQS1aYS16MC05QC5fLV0rKVxccysoXFwoLipc XCkpXFxzKiQiKTsKKyAgUVJlZ0V4cCBmb3JtMigiXlxccyooLiopXFxzKzwoW0EtWmEtejAtOUAu Xy1dKyk+XFxzKiQiKTsKKyAgUVJlZ0V4cCBmb3JtMygiXlxccyooW0EtWmEtejAtOUAuXy1dKylc XHMqJCIpOworICBRUmVnRXhwIHF1b3RlZCgiXCIuKlwiIik7IHF1b3RlZC5zZXRNaW5pbWFsKHRy dWUpOworICBpZiAoIGZvcm0xLmV4YWN0TWF0Y2goYVN0cikgKSB7CisgICAgYWRkcmVzcyA9IGZv cm0xLmNhcCgxKS5zdHJpcFdoaXRlU3BhY2UoKTsgZGlzcGxheU5hbWUgPSBmb3JtMS5jYXAoMiku c3RyaXBXaGl0ZVNwYWNlKCk7CisgIH0gZWxzZSBpZiAoIGZvcm0yLmV4YWN0TWF0Y2goYVN0cikg KSB7CisgICAgYWRkcmVzcyA9IGZvcm0yLmNhcCgyKS5zdHJpcFdoaXRlU3BhY2UoKTsgZGlzcGxh eU5hbWUgPSBmb3JtMi5jYXAoMSkuc3RyaXBXaGl0ZVNwYWNlKCk7CisgIH0gZWxzZSBpZiAoIGZv cm0zLmV4YWN0TWF0Y2goYVN0cikgKSB7CisgICAgYWRkcmVzcyA9IGZvcm0zLmNhcCgxKS5zdHJp cFdoaXRlU3BhY2UoKTsKKyAgfSBlbHNlIHsgLy8gVW5hYmxlIHRvIGZpbmQgb25lIG9mIHRoZSB0 aHJlZSBmb3JtIG9mIGVtYWlsIGFkZHJlc3NlcyAuLi4KKyAgICAKKyAgICAvLyBDaGVjayBmb3Ig cXVvdGVzIGJhbGFuY2luZyBlcnJvcnMKKyAgICBpZiAoIChhU3RyLmNvbnRhaW5zKCciJykgLSBh U3RyLmNvbnRhaW5zKCJcXFwiIikpICUgMiAhPSAwICkKKyAgICAgIHJldHVybiBVbmJhbGFuY2Vk UXVvdGU7CisgICAgCisgICAgLy8gTm93IGdldCByaWQgb2YgdGhlIHBhcnRzIHF1b3RlZCBhcyB3 ZSBkb24ndCBjaGVjayB0aGVtIGZvciB2YWxpZGl0eS4uCisgICAgUVN0cmluZyBuZXdTdHIgPSBh U3RyOworICAgIG5ld1N0ci5yZW1vdmUoIlxcXCIiKTsgLy8gVGhpcyBnZXQgcmlkIG9mIGVzY2Fw ZWQgcXVvdGVzCisgICAgbmV3U3RyLnJlbW92ZShxdW90ZWQpOworICAgIAorICAgIG5ld1N0ci5y ZW1vdmUoUVJlZ0V4cCgiXFxcXC4iKSk7IC8vIEdldCByaWQgb2YgZXNjYXBlZCBjaGFyYWN0ZXJz CisgICAgCisgICAgLy8gTm93IGNoZWNrIGZvciBiYWxhbmNpbmdzLi4uCisgICAgaWYgKCAobmV3 U3RyLmNvbnRhaW5zKCcoJykgLSBuZXdTdHIuY29udGFpbnMoJyknKSkgJSAyICE9IDAgKQorICAg ICAgcmV0dXJuIFVuYmFsYW5jZWRQYXJlbnM7CisgICAgaWYgKCBuZXdTdHIuY29udGFpbnMoJzwn KSA+IG5ld1N0ci5jb250YWlucygnPicpICkKKyAgICAgIHJldHVybiBVbmNsb3NlZEFuZ2xlQWRk cjsKKyAgICBlbHNlIGlmICggbmV3U3RyLmNvbnRhaW5zKCc8JykgPCBuZXdTdHIuY29udGFpbnMo Jz4nKSApCisgICAgICByZXR1cm4gVW5jbG9zZWRBbmdsZUFkZHI7CisgICAgCisgICAgcmV0dXJu IE5vQWRkcmVzc1NwZWM7CisgIH0KKyAgCisgIGludCBhdENvdW50OworICBpZiAoIChhdENvdW50 ID0gYWRkcmVzcy5jb250YWlucygnQCcpKSAhPSAxICkKKyAgICByZXR1cm4gYXRDb3VudCA+IDEg PyBUb29NYW55QXRzIDogVG9vRmV3QXRzOworCisgIC8vIE5vdyBjaGVjayBpZiB0aGUgYWRkcmVz cyBpcyBub3QgbWlzc2luZyB2aXRhbHMgcGFydHMKKyAgaWYgKCBhZGRyZXNzLnN0YXJ0c1dpdGgo IkAiKSApCisgICAgcmV0dXJuIE1pc3NpbmdMb2NhbFBhcnQ7CisgIGlmICggYWRkcmVzcy5lbmRz V2l0aCgiQCIpICkKKyAgICByZXR1cm4gTWlzc2luZ0RvbWFpblBhcnQ7CisgIAorICAvLyBUaW1l IHRvIGNoZWNrIGZvciBpbnZhbGlkIG5vbi1xdW90ZWQsIG5vbi1lc2NhcGVkIGNoYXJhY3RlcnMg aW4gZGlzcGxheU5hbWUKKyAgZGlzcGxheU5hbWUucmVtb3ZlKCJcXFwiIik7IC8vIFRoaXMgZ2V0 IHJpZCBvZiBlc2NhcGVkIHF1b3RlcworICBkaXNwbGF5TmFtZS5yZW1vdmUocXVvdGVkKTsKKwor ICBkaXNwbGF5TmFtZS5yZW1vdmUoUVJlZ0V4cCgiXFxcXC4iKSk7IC8vIEdldCByaWQgb2YgZXNj YXBlZCBjaGFyYWN0ZXJzCisgIAorICBpZiAoIGRpc3BsYXlOYW1lLmNvbnRhaW5zKFFSZWdFeHAo IltcXFtcXF06LF0iKSkgKQorICAgIHJldHVybiBJbnZhbGlkRGlzcGxheU5hbWU7CiAKLSAgYm9v bCB0b29NYW55QXRzRmxhZyA9IGZhbHNlOwotCi0gIGludCBhdENvdW50ID0gYVN0ci5jb250YWlu cygnQCcpOwotICBpZiAoIGF0Q291bnQgPiAxICkgewotICAgIHRvb01hbnlBdHNGbGFnID0gdHJ1 ZTs7Ci0gIH0gZWxzZSBpZiAoIGF0Q291bnQgPT0gMCApIHsKLQkgIHJldHVybiBUb29GZXdBdHM7 Ci0gIH0KLQotICAvLyBUaGUgbWFpbiBwYXJzZXIsIHRyeSBhbmQgY2F0Y2ggYWxsIHdlaXJkIGFu ZCB3b25kZXJmdWwKLSAgLy8gbWlzdGFrZXMgdXNlcnMgYW5kL29yIG1hY2hpbmVzIGNhbiBjcmVh dGUKLQotICBlbnVtIHsgVG9wTGV2ZWwsIEluQ29tbWVudCwgSW5BbmdsZUFkZHJlc3MgfSBjb250 ZXh0ID0gVG9wTGV2ZWw7Ci0gIGJvb2wgaW5RdW90ZWRTdHJpbmcgPSBmYWxzZTsKLSAgaW50IGNv bW1lbnRMZXZlbCA9IDA7Ci0KLSAgdW5zaWduZWQgaW50IHN0cmxlbiA9IGFTdHIubGVuZ3RoKCk7 Ci0KLSAgZm9yICggdW5zaWduZWQgaW50IGluZGV4PTA7IGluZGV4IDwgc3RybGVuOyBpbmRleCsr ICkgewotICAgIHN3aXRjaCAoIGNvbnRleHQgKSB7Ci0gICAgY2FzZSBUb3BMZXZlbCA6IHsKLSAg ICAgIHN3aXRjaCAoIGFTdHJbaW5kZXhdLmxhdGluMSgpICkgewotICAgICAgICBjYXNlICciJyA6 IGluUXVvdGVkU3RyaW5nID0gIWluUXVvdGVkU3RyaW5nOwotICAgICAgICAgIGJyZWFrOwotICAg ICAgICBjYXNlICcoJyA6Ci0gICAgICAgICAgaWYgKCAhaW5RdW90ZWRTdHJpbmcgKSB7Ci0gICAg ICAgICAgICBjb250ZXh0ID0gSW5Db21tZW50OwotICAgICAgICAgICAgY29tbWVudExldmVsID0g MTsKLSAgICAgICAgICB9Ci0gICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgJ1snIDoKLSAg ICAgICAgICBpZiAoICFpblF1b3RlZFN0cmluZyApIHsKLSAgICAgICAgICAgIHJldHVybiBJbnZh bGlkRGlzcGxheU5hbWU7Ci0gICAgICAgICAgfQotICAgICAgICBjYXNlICddJyA6Ci0gICAgICAg ICAgaWYgKCAhaW5RdW90ZWRTdHJpbmcgKSB7Ci0gICAgICAgICAgICByZXR1cm4gSW52YWxpZERp c3BsYXlOYW1lOwotICAgICAgICAgIH0KLSAgICAgICAgY2FzZSAnOicgOgotICAgICAgICAgIGlm ICggIWluUXVvdGVkU3RyaW5nICkgewotICAgICAgICAgICAgcmV0dXJuIERpc2FsbG93ZWRDaGFy OwotICAgICAgICAgIH0KLSAgICAgICAgY2FzZSAnPCcgOgotICAgICAgICAgIGlmICggIWluUXVv dGVkU3RyaW5nICkgewotICAgICAgICAgICAgY29udGV4dCA9IEluQW5nbGVBZGRyZXNzOwotICAg ICAgICAgIH0KLSAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSAnXFwnIDogLy8gcXVvdGVk IGNoYXJhY3RlcgotICAgICAgICAgICsraW5kZXg7IC8vIHNraXAgdGhlICdcJwotICAgICAgICAg IGlmICgoIGluZGV4ICsgMSApPiBzdHJsZW4gKSB7Ci0gICAgICAgICAgICByZXR1cm4gVW5leHBl Y3RlZEVuZDsKLSAgICAgICAgICB9Ci0gICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgJywn IDoKLSAgICAgICAgICBpZiAoICFpblF1b3RlZFN0cmluZyApCi0gICAgICAgICAgICByZXR1cm4g VW5leHBlY3RlZENvbW1hOwotICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlICcpJyA6Ci0g ICAgICAgICAgaWYgKCAhaW5RdW90ZWRTdHJpbmcgKQotICAgICAgICAgICAgcmV0dXJuIFVuYmFs YW5jZWRQYXJlbnM7Ci0gICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgJz4nIDoKLSAgICAg ICAgICBpZiAoICFpblF1b3RlZFN0cmluZyApCi0gICAgICAgICAgICByZXR1cm4gVW5vcGVuZWRB bmdsZUFkZHI7Ci0gICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgJ0AnIDoKLSAgICAgICAg ICBpZiAoICFpblF1b3RlZFN0cmluZyApIHsKLSAgICAgICAgICAgIGlmICggaW5kZXggPT0gMCAp IHsgIC8vIE1pc3NpbmcgbG9jYWwgcGFydAotICAgICAgICAgICAgICByZXR1cm4gTWlzc2luZ0xv Y2FsUGFydDsKLSAgICAgICAgICAgIH0gZWxzZSBpZiggaW5kZXggPT0gc3RybGVuLTEgKSB7Ci0g ICAgICAgICAgICAgIHJldHVybiBNaXNzaW5nRG9tYWluUGFydDsKLSAgICAgICAgICAgIH0KLSAg ICAgICAgICB9IGVsc2UgaWYgKCBpblF1b3RlZFN0cmluZyApIHsKLSAgICAgICAgICAgIC0tYXRD b3VudDsKLSAgICAgICAgICAgIGlmICggYXRDb3VudCA9PSAxICkgewotICAgICAgICAgICAgICB0 b29NYW55QXRzRmxhZyA9IGZhbHNlOwotICAgICAgICAgICAgfQotICAgICAgICAgIH0KLSAgICAg ICAgICBicmVhazsKLSAgICAgIH0KLSAgICAgIGJyZWFrOwotICAgIH0KLSAgICBjYXNlIEluQ29t bWVudCA6IHsKLSAgICAgIHN3aXRjaCAoIGFTdHJbaW5kZXhdICkgewotICAgICAgICBjYXNlICco JyA6ICsrY29tbWVudExldmVsOwotICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlICcpJyA6 IC0tY29tbWVudExldmVsOwotICAgICAgICAgIGlmICggY29tbWVudExldmVsID09IDAgKSB7Ci0g ICAgICAgICAgICBjb250ZXh0ID0gVG9wTGV2ZWw7Ci0gICAgICAgICAgfQotICAgICAgICAgIGJy ZWFrOwotICAgICAgICBjYXNlICdcXCcgOiAvLyBxdW90ZWQgY2hhcmFjdGVyCi0gICAgICAgICAg KytpbmRleDsgLy8gc2tpcCB0aGUgJ1wnCi0gICAgICAgICAgaWYgKCggaW5kZXggKyAxICk+IHN0 cmxlbiApIHsKLSAgICAgICAgICAgIHJldHVybiBVbmV4cGVjdGVkRW5kOwotICAgICAgICAgIH0K LSAgICAgICAgICBicmVhazsKLSAgICAgICAgfQotICAgICAgICBicmVhazsKLSAgICB9Ci0KLSAg ICBjYXNlIEluQW5nbGVBZGRyZXNzIDogewotICAgICAgc3dpdGNoICggYVN0cltpbmRleF0gKSB7 Ci0gICAgICAgIGNhc2UgJywnIDoKLSAgICAgICAgICBpZiAoICFpblF1b3RlZFN0cmluZyApIHsK LSAgICAgICAgICAgIHJldHVybiBVbmV4cGVjdGVkQ29tbWE7Ci0gICAgICAgICAgfQotICAgICAg ICAgIGJyZWFrOwotICAgICAgICBjYXNlICciJyA6IGluUXVvdGVkU3RyaW5nID0gIWluUXVvdGVk U3RyaW5nOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgJ0AnIDoKLSAgICAgICAg ICBpZiAoIGluUXVvdGVkU3RyaW5nICkgewotICAgICAgICAgICAgLS1hdENvdW50OwotICAgICAg ICAgICAgaWYgKCBhdENvdW50ID09IDEgKSB7Ci0gICAgICAgICAgICAgIHRvb01hbnlBdHNGbGFn ID0gZmFsc2U7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgfQotICAgICAgICAgIGJyZWFrOwot ICAgICAgICBjYXNlICc+JyA6Ci0gICAgICAgICAgaWYgKCAhaW5RdW90ZWRTdHJpbmcgKSB7Ci0g ICAgICAgICAgICBjb250ZXh0ID0gVG9wTGV2ZWw7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAg ICAgICB9Ci0gICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgJ1xcJyA6IC8vIHF1b3RlZCBj aGFyYWN0ZXIKLSAgICAgICAgICArK2luZGV4OyAvLyBza2lwIHRoZSAnXCcKLSAgICAgICAgICBp ZiAoKCBpbmRleCArIDEgKT4gc3RybGVuICkgewotICAgICAgICAgICAgcmV0dXJuIFVuZXhwZWN0 ZWRFbmQ7Ci0gICAgICAgICAgfQotICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgICAg IGJyZWFrOwotICAgICAgfQotICAgIH0KLSAgfQotCi0gIGlmICggYXRDb3VudCA9PSAwICYmICFp blF1b3RlZFN0cmluZyApCi0gICAgcmV0dXJuIFRvb0Zld0F0czsKLQotICBpZiAoIGluUXVvdGVk U3RyaW5nICkKLSAgICByZXR1cm4gVW5iYWxhbmNlZFF1b3RlOwotCi0gIGlmICggY29udGV4dCA9 PSBJbkNvbW1lbnQgKQotICAgIHJldHVybiBVbmJhbGFuY2VkUGFyZW5zOwotCi0gIGlmICggY29u dGV4dCA9PSBJbkFuZ2xlQWRkcmVzcyApCi0gICAgcmV0dXJuIFVuY2xvc2VkQW5nbGVBZGRyOwot Ci0gIGlmICggdG9vTWFueUF0c0ZsYWcgKSB7Ci0gICAgcmV0dXJuIFRvb01hbnlBdHM7Ci0gIH0K ICAgcmV0dXJuIEFkZHJlc3NPazsKIH0KIAo=