119352 2006-01-02 01:17:37 +0000 [PATCH] [testcase] Formatting of large roman numbers leads to undefined behavior 2006-01-19 18:59:01 +0000 1 1 2 Applications konqueror khtml unspecified NetBSD pkgsrc Linux RESOLVED FIXED NOR normal --- 1 roland.illig konqueror-bugs-null maksim 0 oldest_to_newest 402984 0 roland.illig 2006-01-02 01:17:37 +0000 Version: (using KDE KDE 3.5.0) Installed from: NetBSD pkgsrc Compiler: any This patch fixes the undefined behavior when formatting big numbers in roman. --- khtml/rendering/enumerate.cpp.orig Mon Oct 10 17:06:06 2005 +++ khtml/rendering/enumerate.cpp Sun Jan 1 22:07:12 2006 @@ -34,7 +34,7 @@ namespace Enumerate { QString toRoman( int number, bool upper ) { - if (number < 1) return QString::number(number); + if (number < 1 || number > 3999) return QString::number(number); QString roman; static const QChar ldigits[] = { 'i', 'v', 'x', 'l', 'c', 'd', 'm' }; static const QChar udigits[] = { 'I', 'V', 'X', 'L', 'C', 'D', 'M' }; 402985 1 maksim 2006-01-02 01:21:58 +0000 Thanks for the patch. Any place on the web actually use that, or should I stop being lazy and make a testcase? ;-) 402988 2 14102 thiago 2006-01-02 01:35:07 +0000 Created attachment 14102 testcase 402989 3 thiago 2006-01-02 01:35:40 +0000 Forgot to confirm. 407470 4 maksim 2006-01-19 18:53:06 +0000 SVN commit 500228 by orlovich: Apply patch from Roland Illig (roland dot illig at the host gmx with tld de) to behave sanely for Roman counters > 4000 BUG:119352 M +1 -1 enumerate.cpp --- branches/KDE/3.5/kdelibs/khtml/rendering/enumerate.cpp #500227:500228 @@ -34,7 +34,7 @@ QString toRoman( int number, bool upper ) { - if (number < 1) return QString::number(number); + if (number < 1 || number > 3999) return QString::number(number); QString roman; static const QChar ldigits[] = { 'i', 'v', 'x', 'l', 'c', 'd', 'm' }; static const QChar udigits[] = { 'I', 'V', 'X', 'L', 'C', 'D', 'M' }; 407472 5 maksim 2006-01-19 18:59:00 +0000 SVN commit 500230 by orlovich: Regression test for #119352 CCBUG:119352 A baseline/unsorted/119352.html-dom AM baseline/unsorted/119352.html-dump.png A baseline/unsorted/119352.html-render A tests/unsorted/119352.html ** trunk/tests/khtmltests/regression/baseline/unsorted/119352.html-dump.png #property svn:mime-type + application/octet-stream 14102 2006-01-02 01:35:07 +0000 2006-01-02 01:35:07 +0000 testcase test.html text/html 427 thiago PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPCFET0NUWVBFIGh0bWwgCiAg ICAgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFsLy9FTiIKICAgICAi RFREL3hodG1sMS10cmFuc2l0aW9uYWwuZHRkIj4KPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMu b3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJlbiIgbGFuZz0iZW4iPgogIDxoZWFkPgogICAgPHRp dGxlPnRlc3RjYXNlPC90aXRsZT4KICA8L2hlYWQ+CiAgPGJvZHk+CiAgICA8b2wgc3RhcnQ9IjM5 OTgiIHR5cGU9IkkiPgogICAgICA8bGk+Mzk5ODwvbGk+CiAgICAgIDxsaT4zOTk5PC9saT4KICAg ICAgPGxpPjQwMDA8L2xpPgogICAgICA8bGk+NDAwMTwvbGk+CiAgICAgIDxsaT40MDAyPC9saT4K ICAgIDwvb2w+CiAgPC9ib2R5Pgo8L2h0bWw+Cg==