117658 2005-12-04 13:57:44 +0000 Constant disk I/O when resizing Navigation panel 2005-12-04 14:04:17 +0000 1 1 10 Unmaintained kpdf general unspecified Gentoo Packages Linux RESOLVED WORKSFORME NOR wishlist --- 0 borisdusek aacid 0 oldest_to_newest 395478 0 borisdusek 2005-12-04 13:57:45 +0000 Version: (using KDE KDE 3.5.0) Installed from: Gentoo Packages Compiler: gcc 3.4.4 OS: Linux Hi, running KPDF 0.5 (KDE 3.5) here and want to report an excessive I/O issue. When resizing the navigation panel (located on the left), there is a constant I/O (and is very noisy on my machine). I found by sysprof that it is related to KPDF::Part::saveSplitterSize(), which is called even *during* resizing (e.g. dragging with mouse) *and* immediately writes the settings to config file on harddisk by means of function KConfigSkeleton::writeConfig(); this writing consumes about 20% of CPU time spent in kpdf, so this will be not only I/O optimization. Suggestion: write to config on disk (and maybe also internally save) the splitter size only at application exit. Regards, Boris Dusek 395480 1 13765 borisdusek 2005-12-04 14:03:13 +0000 Created attachment 13765 Patch by Albert Astals Cid This is a patch made by Albert Astals Cid and it resolves the issue (=no constant I/O and splitter size is correctly restored after aplication restart). Thank you, Albert! 395481 2 borisdusek 2005-12-04 14:04:17 +0000 The patch above solves the problem. 13765 2005-12-04 14:03:13 +0000 2005-12-04 14:03:13 +0000 Patch by Albert Astals Cid PATCH text/plain 1395 borisdusek SW5kZXg6IHBhcnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhcnQuY3BwCShyZXZpc2nDs246IDQ4MTA3 OCkKKysrIHBhcnQuY3BwCShjb3BpYSBkZSB0cmFiYWpvKQpAQCAtMjc0LDYgKzI3NCw4IEBACiAJ Y29ubmVjdCggbV93YXRjaGVyLCBTSUdOQUwoIGRpcnR5KCBjb25zdCBRU3RyaW5nJiApICksIHRo aXMsIFNMT1QoIHNsb3RGaWxlRGlydHkoIGNvbnN0IFFTdHJpbmcmICkgKSApOwogCW1fZGlydHlI YW5kbGVyID0gbmV3IFFUaW1lciggdGhpcyApOwogCWNvbm5lY3QoIG1fZGlydHlIYW5kbGVyLCBT SUdOQUwoIHRpbWVvdXQoKSApLHRoaXMsIFNMT1QoIHNsb3REb0ZpbGVEaXJ0eSgpICkgKTsKKwlt X3NhdmVTcGxpdHRlclNpemVUaW1lciA9IG5ldyBRVGltZXIoIHRoaXMgKTsKKwljb25uZWN0KCBt X3NhdmVTcGxpdHRlclNpemVUaW1lciwgU0lHTkFMKCB0aW1lb3V0KCkgKSx0aGlzLCBTTE9UKCBz YXZlU3BsaXR0ZXJTaXplKCkgKSApOwogCiAJc2xvdE5ld0NvbmZpZygpOwogCkBAIC00NzgsNyAr NDgwLDcgQEAKIHsKICAgICAvLyBpZiBwYWdlVmlldyBoYXMgYmVlbiByZXNpemVkLCBzYXZlIHNw bGl0dGVyIHNpemVzCiAgICAgaWYgKCB3YXRjaGVkID09IG1fcGFnZVZpZXcgJiYgZS0+dHlwZSgp ID09IFFFdmVudDo6UmVzaXplICkKLSAgICAgICAgc2F2ZVNwbGl0dGVyU2l6ZSgpOworICAgICAg ICBtX3NhdmVTcGxpdHRlclNpemVUaW1lci0+c3RhcnQoNTAwLCB0cnVlKTsKIAogICAgIC8vIG9u bHkgaW50ZXJjZXB0IGV2ZW50cywgZG9uJ3QgYmxvY2sgdGhlbQogICAgIHJldHVybiBmYWxzZTsK SW5kZXg6IHBhcnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwYXJ0LmgJKHJldmlzacOzbjogNDgxMDc4KQor KysgcGFydC5oCShjb3BpYSBkZSB0cmFiYWpvKQpAQCAtMTQ2LDYgKzE0NiwxMSBAQAogCS8vIHN0 YXRpYyBpbnN0YW5jZXMgY291bnRlcgogCXN0YXRpYyB1bnNpZ25lZCBpbnQgbV9jb3VudDsKIAor ICAvLyB0aGlzIGlzIGEgaGFjayBiZWNhdXNlIHdlIGNhbiBub3QgdXNlIHdyaXRlQ29uZmlnIG9u IHBhcnQgZGVzdHJ1Y3RvcgorICAvLyBhbmQgd2UgZG9uJ3Qgd2FudCB0byB3cml0ZWNvbmZpZyBl dmVyeSB0aW1lIHNvbWVvbmUgbW92ZXMgdGhlIHNwbGl0dGVyCisgIC8vIHNvIHdlIHVzZSBhIFFU aW1lciBlYWNoIDUwMCBtcworICBRVGltZXIgKm1fc2F2ZVNwbGl0dGVyU2l6ZVRpbWVyOworCiAJ S0RpcldhdGNoICptX3dhdGNoZXI7CiAJUVRpbWVyICptX2RpcnR5SGFuZGxlcjsKIAlEb2N1bWVu dFZpZXdwb3J0IG1fdmlld3BvcnREaXJ0eTsK