116790 2005-11-20 21:59:44 +0000 Hidden field is not sent 2006-07-18 15:34:53 +0000 1 1 2 Applications konqueror khtml forms unspecified unspecified Linux RESOLVED FIXED NOR normal --- 1 cmueller konqueror-bugs-null 0 oldest_to_newest 391769 0 cmueller 2005-11-20 21:59:44 +0000 Version: (using KDE KDE 3.5.0) Installed from: Unlisted Binary Package OS: Linux Browsing the site http://www.osnews.com/ I noticed that comments posted with Konqueror are not associated with a thread while when posted with Firefox they are. It turned out that Konqi doesn't send a hidden field that carries the parent post info. I stripped down the HTML as much as possible and the problem lies here (see also attached page): <tr> <td> <font> <p> <input type="hidden" name="ref" value="62637"> </font> </td> </tr> If I remove either the <font>, the </font> or the <p> tag the hidden field reappears in the request. --- Here is my version info (I'm using the experimental Debian 3.5 packages): > konqueror -v Qt: 3.3.5 KDE: 3.5 (RC1) Konqueror: 3.5 391771 1 13572 cmueller 2005-11-20 22:01:38 +0000 Created attachment 13572 Stripped HTML page that reproduces the problem 391804 2 kde 2005-11-20 23:49:59 +0000 Sorry, how do I configure something to use that test? 391805 3 13573 niels.misc 2005-11-20 23:57:31 +0000 Created attachment 13573 simpler testcase Here's a simpler testcase. Note that there's no table tag. 391807 4 cmueller 2005-11-21 00:02:40 +0000 Ah yes, sorry, I had written a little php script that dumped the passed parameters. But I guess Niels' test case using method='get' will be sufficient, won't it? 391811 5 13575 kde 2005-11-21 00:10:40 +0000 Created attachment 13575 Patch This patch fixes it by improving fall-back behaviour I am not sure it is the right way(TM). The real problem is that the htmlparser.cpp chokes on the broken HTML forms from osnews and forgets which form input element should refer to. 391853 6 cmueller 2005-11-21 07:25:06 +0000 Yes, that patch fixes the problem both with my local test case and the real world example. Your speed is amazing. :) What will happen next? 405714 7 kde 2006-01-13 11:10:56 +0000 SVN commit 497603 by carewolf: Fix OSNews replies BUG: 116790 M +5 -1 html_formimpl.cpp --- branches/KDE/3.5/kdelibs/khtml/html/html_formimpl.cpp #497602:497603 @@ -885,7 +885,11 @@ { if( p->id() == ID_FORM ) return static_cast<HTMLFormElementImpl *>(p); - p = p->parentNode(); + NodeImpl *s = p->previousSibling(); + if (!s) + p = p->parentNode(); + else + p = s; } #ifdef FORMS_DEBUG kdDebug( 6030 ) << "couldn't find form!" << endl; 420581 8 ivor 2006-03-09 16:00:05 +0000 SVN commit 517005 by ivor: Replace one form reattach hack with another, pending a better fix. BUG: 122968 BUG: 122273 CCBUG: 116790 M +1 -5 html_formimpl.cpp M +9 -0 htmlparser.cpp --- branches/KDE/3.5/kdelibs/khtml/html/html_formimpl.cpp #517004:517005 @@ -886,11 +886,7 @@ { if( p->id() == ID_FORM ) return static_cast<HTMLFormElementImpl *>(p); - NodeImpl *s = p->previousSibling(); - if (!s) - p = p->parentNode(); - else - p = s; + p = p->parentNode(); } #ifdef FORMS_DEBUG kdDebug( 6030 ) << "couldn't find form!" << endl; --- branches/KDE/3.5/kdelibs/khtml/html/htmlparser.cpp #517004:517005 @@ -1388,6 +1388,15 @@ blockElem->removeChild(currNode, exceptionCode); newNode->appendChild(currNode, exceptionCode); currNode = nextNode; + + // TODO - To be replaced. + // Re-register form elements with currently active form, step 1 will have removed them + if (form) + { + HTMLGenericFormElementImpl *e = static_cast<HTMLGenericFormElementImpl *>(currNode); + if (e) + form->registerFormElement(e); + } } // Step 4: Place |newNode| under |blockElem|. |blockElem| is still out of the document, so no 447759 9 cmueller 2006-06-19 02:44:02 +0000 It seems that the original bug is back. :-( The test cases still work, but the reference is lost again when posting on osnews.com. Tested with: Qt: 3.3.6 KDE: 3.5.3 Konqueror: 3.5.3 447811 10 kde 2006-06-19 11:43:24 +0000 The DOM is unchanged, and the test case show we send the hidden field... It almost sounds like OSNews PHP code is breaking us. 447812 11 16693 kde 2006-06-19 11:54:54 +0000 Created attachment 16693 Test case This is the newest code from OSNews grapped today. Only thing changed is changing form-action from post to get. As demonstrated, Konqueror sends the ref value just fine. It must be OSNews that specifically ignores the 'ref' when UA is Konqueror. 447815 12 16694 kde 2006-06-19 12:03:14 +0000 Created attachment 16694 Patch Ahh :) My original patch still works. Here's a modified version. 448001 13 cmueller 2006-06-19 22:28:39 +0000 Unfortunately I no longer have any svn version of the 3.5 branch around so I cannot test the patch. Will it make it into the next point release? 454474 14 kde 2006-07-18 15:34:52 +0000 SVN commit 563771 by carewolf: Fix for yet again broken replies in osnews.com. This implements the behavior on DOM level instead of at parsing. This also means that a reparsed DOM should work. BUG: 116790 M +5 -0 html_formimpl.cpp --- branches/KDE/3.5/kdelibs/khtml/html/html_formimpl.cpp #563770:563771 @@ -890,6 +890,11 @@ { if( p->id() == ID_FORM ) return static_cast<HTMLFormElementImpl *>(p); + if( p->parentNode() && p->parentNode()->id() == ID_TABLE && p->previousSibling() ) + { + p = p->previousSibling(); + continue; + } p = p->parentNode(); } #ifdef FORMS_DEBUG 13572 2005-11-20 22:01:38 +0000 2005-11-20 22:01:38 +0000 Stripped HTML page that reproduces the problem reply.html text/html 361 cmueller PGh0bWw+CgoKPGhlYWQ+CjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PWlzby04ODU5LTEiPgo8L2hlYWQ+CgoKPGJvZHk+Cgo8Zm9ybSBh Y3Rpb249Imh0dHA6Ly9sb2NhbGhvc3QvZHVtcF9yZXF1ZXN0LnBocCIgbWV0aG9kPSJwb3N0Ij4K Cjx0cj4KPHRkPgo8Zm9udD4KPHA+CjxpbnB1dCB0eXBlPSJoaWRkZW4iIG5hbWU9InJlZiIgdmFs dWU9IjYyNjM3Ij4KPC9mb250Pgo8L3RkPgo8L3RyPgoKPHRyPgo8dGQ+CjxpbnB1dCBuYW1lPSJz dWJtaXQiIHR5cGU9InN1Ym1pdCIgdmFsdWU9IlN1Ym1pdCI+CjwvdGQ+CjwvdHI+CjwvZm9ybT4K CjwvYm9keT4KCgo8L2h0bWw+Cg== 13573 2005-11-20 23:57:31 +0000 2005-11-20 23:57:31 +0000 simpler testcase test.htm text/html 226 niels.misc PGh0bWw+Cgo8Ym9keT4KCjxmb3JtIG1ldGhvZD0nZ2V0Jz4KCjx0cj4KPHRkPgo8Zm9udD4KPHA+ CjxpbnB1dCB0eXBlPSJoaWRkZW4iIG5hbWU9InJlZiIgdmFsdWU9IjYyNjM3Ij4KPC9mb250Pgo8 L3RkPgo8L3RyPgoKPHRyPgo8dGQ+CjxpbnB1dCBuYW1lPSJzdWJtaXQiIHR5cGU9InN1Ym1pdCIg dmFsdWU9IlN1Ym1pdCI+CjwvdGQ+CjwvdHI+Cgo8L2Zvcm0+Cgo8L2JvZHk+Cgo8L2h0bWw+Cg== 13575 2005-11-21 00:10:40 +0000 2006-06-19 12:03:14 +0000 Patch patch.diff text/plain 533 kde SW5kZXg6IGh0bWxfZm9ybWltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGh0bWxfZm9ybWltcGwuY3Bw CShyZXZpc2lvbiA0ODA0NTYpCisrKyBodG1sX2Zvcm1pbXBsLmNwcAkod29ya2luZyBjb3B5KQpA QCAtODc3LDcgKzg3NywxMSBAQAogICAgIHsKICAgICAgICAgaWYoIHAtPmlkKCkgPT0gSURfRk9S TSApCiAgICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8SFRNTEZvcm1FbGVtZW50SW1wbCAq PihwKTsKLSAgICAgICAgcCA9IHAtPnBhcmVudE5vZGUoKTsKKyAgICAgICAgTm9kZUltcGwgKnMg PSBwLT5wcmV2aW91c1NpYmxpbmcoKTsKKyAgICAgICAgaWYgKCFzKQorICAgICAgICAgICAgcCA9 IHAtPnBhcmVudE5vZGUoKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgcCA9IHM7CiAgICAg fQogI2lmZGVmIEZPUk1TX0RFQlVHCiAgICAga2REZWJ1ZyggNjAzMCApIDw8ICJjb3VsZG4ndCBm aW5kIGZvcm0hIiA8PCBlbmRsOwo= 16693 2006-06-19 11:54:54 +0000 2006-06-19 11:54:54 +0000 Test case osnews.html text/html 7069 kde PHA+PHRhYmxlIGNlbGxwYWRkaW5nPTIgY2VsbHNwYWNpbmc9MCBib3JkZXI9MSB3aWR0aD02MTAg Y2xhc3M9InRhYmxlIiBhbGlnbj0iY2VudGVyIj4KPGZvcm0gIGFjdGlvbj0iY29tbWVudHYzLnBo cCIgbWV0aG9kPSJnZXQiIG5hbWU9Im9zbmV3c2Zvcm0iIG9uc3VibWl0PSJyZXR1cm4gY2xvc2Vf cHJldmlldygpOyI+Cjx0cj4KPHRkIHZhbGlnbj0idG9wIiBiZ2NvbG9yPSIjY2NjY2NjIiBhbGln bj0iY2VudGVyIiBjbGFzcz0idGQiPgo8Zm9udCBzaXplPTMgZmFjZT0iYXJpYWwiIGNvbG9yPSIj MDAwMDAwIj48Yj48YSBuYW1lPSJjb21tZW50Ij5Qb3N0IGEgbmV3IGNvbW1lbnQ8L0E+PC9CPjwv Rk9OVD48L1REPjwvVFI+Cjx0cj4KPHRkIHZhbGlnbj0idG9wIiBiZ2NvbG9yPSIjZGRkZGRkIiBh bGlnbj0iY2VudGVyIiBjbGFzcz0idGQiPgo8Zm9udCBzaXplPTIgZmFjZT0iYXJpYWwiIGNvbG9y PSIjMzM0NDMzIj4KPGlucHV0IG5hbWU9Im5ld3NfaWQiIHR5cGU9ImhpZGRlbiIgdmFsdWU9IjE0 OTI3Ij4KWW91IGFyZSBwb3N0aW5nIGFzICI8Yj5DYXJld29sZjwvYj4iCmFuZCByZXBseWluZyB0 byAiPGEgaHJlZj0idXNlci5waHA/dWlkPTExNTkiPmNtX188L2E+IjxwPjxpbnB1dCB0eXBlPSJo aWRkZW4iIG5hbWU9InJlZiIgdmFsdWU9IjEzNDk1MiI+PEI+U3ViamVjdDwvQj4gPC9GT05UPjog PEJSPjxJTlBVVCBUWVBFPSJURVhUIiBTSVpFPTU1IE1BWFNJWkU9NTUgbWF4bGVuZ3RoPTgwIE5B TUU9ImZvcnVtX2hlYWRlciIgVkFMVUU9IlJFWzZdOiBLLU5hbWVzIj48QlI+PGZvbnQgc2l6ZT0y IGZhY2U9ImFyaWFsIiBjb2xvcj0iIzMzNDQzMyI+PGI+WW91ciBjb21tZW50PC9iPjxicj48L2Zv bnQ+Cjxmb250IHNpemU9MiBmYWNlPSJhcmlhbCIgY29sb3I9IiMzMzQ0MzMiPgo8dGV4dGFyZWEg bmFtZT0iZm9ydW1fdGV4dCIgcm93cz0xMiBjb2xzPTU1IHdyYXA9InZpcnR1YWwiPjwvdGV4dGFy ZWE+CjwvZm9udD4KPEJSPgo8Rk9OVCBTSVpFPTEgRkFDRT0iVmVyZGFuYSxBcmlhbCIgY29sb3I9 IiMwMDAwMDAiPgo8Qj48Rk9OVCBTSVpFPTEgY29sb3I9IiNGRjAwMDAiPkxFQVZFIFNQQUNFUzwv Rk9OVD48L0I+IGFyb3VuZCBVUkxzIHRvIGF1dG9wYXJzZS4gPEI+Tm88L0I+IG1vcmUgdGhhbiA4 LDAwMCBjaGFyYWN0ZXJzIGFyZSBhbGxvd2VkLjxCUj4KVGhlIDxCPm9ubHk8L0I+IEhUTUwvVUJC IHRhZ3MgYWxsb3dlZCBhcmUgZm9yIGJvbGQgYW5kIGl0YWxpY3MuPEJSPgo8Rk9OVCBTSVpFPTEg RkFDRT0iVmVyZGFuYSwgQXJpYWwiIGNvbG9yPSIjRkYwMDAwIj48Qj5TdWJtaXNzaW9uIG9mIGEg Y29tbWVudCBvbiBPU05ld3MgaW1wbGllcyB0aGF0PEJSPnlvdSBoYXZlIDxVPmFja25vd2xlZGdl ZCBhbmQgZnVsbHkgYWdyZWVkPC9VPiB3aXRoIDxBIEhSRUY9InJ1bGVzLnBocCIgVEFSR0VUPSJf YmxhbmsiPlRIRVNFIFRFUk1TPC9hPjwvQj4uPC9GT05UPgo8L1REPjwvVFI+CjxUUj4KPFREIGJn Y29sb3I9IiNDQ0NDQ0MiIEFMSUdOPSJDRU5URVIiIGNsYXNzPSJ0ZCI+CjxpbnB1dCB0eXBlPSJi dXR0b24iIG5hbWU9InByZXZpZXciIHZhbHVlPSJQcmV2aWV3IChKYXZhc2NyaXB0LW9ubHkpIiBv bkNsaWNrPSJzaG93X3ByZXZpZXcoKTsgdGhpcy52YWx1ZT0nUHJldmlldyBBZ2Fpbic7Ij4KPGlu cHV0IG5hbWU9InN1Ym1pdCIgdHlwZT0ic3VibWl0IiB2YWx1ZT0iU3VibWl0IGNvbW1lbnQiPgo8 L3RkPgo8L3RyPgo8L2Zvcm0+CjwvdGFibGU+CjwhLS0gVGhpcyBqYXZhc2NyaXB0IHdvdWxkIGdv IGFueXdoZXJlIGJlZm9yZSB0aGUgbWFpbiB0YWJsZS4uLiAtLT4KCjxzY3JpcHQgbGFuZ3VhZ2U9 IkphdmFzY3JpcHQiIHR5cGU9InRleHQvamF2YXNjcmlwdCI+CjwhLS0KdmFyIHByZXZpZXdfd2lu ZG93OwoKLy8gVGhpcyB3aWxsIGVtdWxhdGUgdGhlIGJlaGF2aW91ciBvZiBubDJiciBidXQgZm9y IEpTLgpmdW5jdGlvbiBubDJicihzdHIpIHsKICAgIHJldHVybiBzdHIucmVwbGFjZSgvXG4vZywi PGJyPiIpOwp9CgovLyBhZGRlZCBieSBBLiBTY2hlaW5iZXJnLCBvc25ld3MuY29tIDIwMDUtMDct MDIKLy8gcGxlYXNlLCBzb21lb25lIGhlbHAgbWUgZ2V0IHRob3NlIGxhc3QgdHdvIGxpbmVzIHJp Z2h0IQpmdW5jdGlvbiB1YmIyaHRtbChzdHIpIHsKCXZhciB4ID0gc3RyLnJlcGxhY2UoL1xbYlxd L2dpLCI8Yj4iKTsKCXggPSB4LnJlcGxhY2UoL1xbaVxdL2dpLCI8aT4iKTsKCXggPSB4LnJlcGxh Y2UoL1xbXC9iXF0vZ2ksIjwvYj4iKTsKCXJldHVybiB4LnJlcGxhY2UoL1xbXC9pXF0vZ2ksIjwv aT4iKTsKCS8vcmV0dXJuIHN0ci5yZXBsYWNlKC9cW1tiaV0qXF0vZ2ksIjxcMT4iKTsKCS8vcmV0 dXJuIHN0ci5yZXBsYWNlKC9cW1wvW2JpXSpcXS9naSwiPFwvXDE+Iik7Cgp9CgpmdW5jdGlvbiBm aWx0ZXJfSFRNTChzdHIpIHsKICByZXR1cm4gc3RyLnJlcGxhY2UoLzxbXmJCaUk+XSo+L2csICI8 Qj48Rk9OVCBjb2xvcj1yZWQ+IC8vT25seSAqQm9sZCogYW5kICpJdGFsaWNzKiB0YWdzIGFyZSBh bGxvd2VkLy8gXDE8L0ZPTlQ+PC9CPiIpOwp9CgpmdW5jdGlvbiBzaG93X3ByZXZpZXcoKSB7Cgog ICAgLy8gVGhpcyB3aWxsIGhlbHAgdXMgcGxhY2UgdGhlIHdpbmRvdy4KICAgIC8vIFdlIHB1dCBp dCBvbiB0aGUgbGVmdCBzaWRlIG9mIHRoZSBzY3JlZW4sIHdoaWNoIHdvcmtzIGZpbmUgZm9yIGV2 ZXJ5Ym9keQogICAgLy8gQW5kIGhhdmUgdGhlIGJlbmVmaXQgb2YgYmVpbmcgb24gdGhlIG1haW4g bW9uaXRvciBmb3IgcGVvcGxlIHVzaW5nIGR1YWwtaGVhZCBsaWtlIG1lICA6UAogICAgdmFyIHdp ZHRoICA9IDYxMDsKICAgIHZhciBoZWlnaHQgPSAzNTA7CgogICAgeCA9ICh3aW5kb3cuc2NyZWVu LmF2YWlsV2lkdGggLSB3aWR0aCkvNDsKCXkgPSAod2luZG93LnNjcmVlbi5hdmFpbEhlaWdodCAt IGhlaWdodCkvMjsKCnBhcmFtcyA9J3dpZHRoPScrd2lkdGgrJyxoZWlnaHQ9JytoZWlnaHQrJyxs ZWZ0PScreCsnLHRvcD0nK3krJyxzY3JlZW5YPScreCsnLHNjcmVlblk9Jyt5KycsdG9vbGJhcj1u byxtZW51YmFyPW5vLGRpcmVjdG9yaWVzPW5vLHJlc2l6YWJsZT15ZXMsc3RhdHVzPW5vLHNjcm9s bGJhcnM9eWVzJzsKCglvc25ld3Nfd2luZG93ID0gd2luZG93Lm9wZW4oJycsICdvc25ld3MnLCBw YXJhbXMpOwoJaWYgKCFvc25ld3Nfd2luZG93KSB7CgkJYWxlcnQoIlJlcXVlc3RlZCBwb3AtdXAg d2luZG93cyBtdXN0IGJlIGFsbG93ZWQgaW4gb3JkZXIgdG8gcGVyZm9ybSB0aGlzIGFjdGlvbi4g UGxlYXNlIHR1cm4gb2ZmIHBvcC11cCBibG9ja2luZyBpbiB5b3VyIHdlYi1icm93c2VyLiIpOwoJ fSBlbHNlIHsKICAgb3NuZXdzX3dpbmRvdy5mb2N1cygpOwogICBvc25ld3Nfd2luZG93LmRvY3Vt ZW50Lm9wZW4oKTsKICAgICAgICBvc25ld3Nfd2luZG93LmRvY3VtZW50LndyaXRlKCI8aHRtbD48 aGVhZD48dGl0bGU+UHJldmlldzwvdGl0bGU+PC9oZWFkPjxib2R5IGJnY29sb3I9JyNGRkZGRkYn ICBMSU5LPScjNjU4NDA4JyBWTElOSz0nIzY1ODQwOCcgVE9QTUFSR0lOPTAgTUFSR0lOSEVJR0hU PTAgTUFSR0lOV0lEVEg9MCBMRUZUTUFSR0lOPTAgUklHSFRNQVJHSU49MD48dGFibGUgd2lkdGg9 JzEwMCUnIGFsaWduPSdjZW50ZXInIGJvcmRlcj0nMCcgc3R5bGU9J2JvcmRlcjogMXB4IHNvbGlk ICMwMDAwMDAnPiIpOwogICAgICAgIG9zbmV3c193aW5kb3cuZG9jdW1lbnQud3JpdGUoIjx0cj48 dGQgYWxpZ249J2NlbnRlcic+PGZvbnQgZmFjZT1BcmlhbCBzaXplPTM+PGI+Q29tbWVudCBQcmV2 aWV3PC9iPjwvZm9udD48L3RkPjwvdHI+PHRyPjx0ZD4iKTsKICAgICAgICBvc25ld3Nfd2luZG93 LmRvY3VtZW50LndyaXRlKCI8cD4iKTsKICAgICAgICBvc25ld3Nfd2luZG93LmRvY3VtZW50Lndy aXRlKCI8Zm9udCBmYWNlPSdBcmlhbCcgc2l6ZT0yIGNvbG9yPScjMDA2NjAwJz48Yj5OT1RFOjwv Yj4gT25seSA8Qj5ib2xkPC9CPiBhbmQgPEk+aXRhbGljczwvST4gSFRNTCB0YWdzIGFyZSBhbGxv d2VkLiBUbyBjcmVhdGUgY2xpY2thYmxlIGxpbmtzLCBzaW1wbHkgY29weSB0aGUgVVJMIGFzIHRl eHQgaW4gaXRzIG93biBsaW5lIGFuZCBvdXIgZW5naW5lIHdpbGwgZ2VuZXJhdGUgdGhlbSBhdXRv bWF0aWNhbGx5LjwvZm9udD4iKTsKCmlmIChkb2N1bWVudC5vc25ld3Nmb3JtLmZvcnVtX2hlYWRl ci52YWx1ZT09IiIgfHwgZG9jdW1lbnQub3NuZXdzZm9ybS5mb3J1bV9oZWFkZXIudmFsdWU9PSIg IikKeyAgICAgIG9zbmV3c193aW5kb3cuZG9jdW1lbnQud3JpdGUoIjxCUj48Zm9udCBmYWNlPSdB cmlhbCcgc2l6ZT0yIGNvbG9yPScjRkYwMDAwJz48Yj5FUlJPUiAxOjwvYj4gU3ViamVjdCBpcyBy ZXF1aXJlZC48L2ZvbnQ+Iik7IH0KCmlmIChkb2N1bWVudC5vc25ld3Nmb3JtLmZvcnVtX3RleHQu dmFsdWU9PSIiIHx8IGRvY3VtZW50Lm9zbmV3c2Zvcm0uZm9ydW1fdGV4dC52YWx1ZT09IiAiKQp7 ICAgICAgICAgb3NuZXdzX3dpbmRvdy5kb2N1bWVudC53cml0ZSgiPEJSPjxmb250IGZhY2U9J0Fy aWFsJyBzaXplPTIgY29sb3I9JyNGRjAwMDAnPjxiPkVSUk9SIDI6PC9iPiBTb21lIGFjdHVhbCB0 ZXh0IGlzIHJlcXVpcmVkLjwvZm9udD4iKTsgfQoKICAgICAgICAvLyBQYXN0IHRoaXMgcG9pbnRz LCB3ZSB1c2Ugc2luZ2xlIHF1b3RhdGlvbiBtYXJrcy4KCQkvL1VzZSBteXNxbF9lc2NhcGVfc3Ry aW5nIHRvIGZpbHRlciBBTlkgZHluYW1pYyBjb250ZW50IGZyb20gUEhQIG9yIHRoZSBqYXZhc2Ny aXB0IGNvdWxkIGJyZWFrLgogICAgICAgIG9zbmV3c193aW5kb3cuZG9jdW1lbnQud3JpdGUoJzx0 YWJsZSBjZWxscGFkZGluZz0iMiIgY2VsbHNwYWNpbmc9IjAiIGJvcmRlcj0iMSIgd2lkdGg9IjEw MCUiIGNsYXNzPSJ0YWJsZSI+Jyk7CiAgICAgICAgb3NuZXdzX3dpbmRvdy5kb2N1bWVudC53cml0 ZSgnPHRib2R5Pjx0cj4nKTsKCiAgICAgICAgLy8gSSByZW1vdmVkIHRoZSBsaW5rLCBzaW5jZSB0 aGVyZSdzIG5vIGxpbmsgdG8gdGhpcyBjb21tZW50IHlldAogICAgICAgIC8vIEkgYWxzbyBjaGFu Z2VkIHRoZSBpbWFnZSdzIEFMVCB0byBUSVRMRSwgd2hpY2ggaXMgbW9yZSBzdGFuZGFyZCBjb21w bGlhbnQgKGZpcmVmb3gpCiAgICAgICAgb3NuZXdzX3dpbmRvdy5kb2N1bWVudC53cml0ZSgnPHRk IGJnY29sb3I9IiNkM2QzZDMiIHJvd3NwYW49IjIiIHdpZHRoPSIyOCIgYWxpZ249ImNlbnRlciIg Y2xhc3M9InRkIj4nKTsKCQlvc25ld3Nfd2luZG93LmRvY3VtZW50LndyaXRlKCc8aW1nIHNyYz0i aHR0cDovL2ltZy5vc25ld3MuY29tL2ltYWdlcy9saW5rLmdpZiIgd2lkdGg9IjIxIiBoZWlnaHQ9 IjIxIiBib3JkZXI9IjEiJykKCQlvc25ld3Nfd2luZG93LmRvY3VtZW50LndyaXRlKCd0aXRsZT0i RGlyZWN0IExpbmsgZm9yIHRoaXMgY29tbWVudCI+PC9hPjwvdGQ+Jyk7CgogICAgICAgIC8vIFRo aXMgdXNlcyBmb3JtIHZhbHVlcy4KICAgICAgICBvc25ld3Nfd2luZG93LmRvY3VtZW50LndyaXRl KCc8dGQgYmdjb2xvcj0iI2QzZDNkMyIgd2lkdGg9IjU4MCIgY2xhc3M9InRkIj48Zm9udCBmYWNl PSJBcmlhbCIgc2l6ZT0iMiIgY29sb3I9IiMzMzQ0MzMiPjxpPjxiPiZuYnNwOycpOwoJCW9zbmV3 c193aW5kb3cuZG9jdW1lbnQud3JpdGUoZmlsdGVyX0hUTUwoZG9jdW1lbnQub3NuZXdzZm9ybS5m b3J1bV9oZWFkZXIudmFsdWUpICsnPC9iPjwvaT48L2ZvbnQ+PC90ZD4nKTsKICAgICAgICBvc25l d3Nfd2luZG93LmRvY3VtZW50LndyaXRlKCc8L3RyPicpOwogICAgICAgIG9zbmV3c193aW5kb3cu ZG9jdW1lbnQud3JpdGUoJzx0cj48dGQgYmdjb2xvcj0iI2RlZGVkZSIgd2lkdGg9IjU4MCIgY2xh c3M9InRkIj4gPGZvbnQgZmFjZT0iVmVyZGFuYSwgQXJpYWwiIHNpemU9IjEiPiZuYnNwO0J5IDxi PicpOwoJCW9zbmV3c193aW5kb3cuZG9jdW1lbnQud3JpdGUoJ0NhcmV3b2xmPC9iPiAnKTsKICAg ICAgICBvc25ld3Nfd2luZG93LmRvY3VtZW50LndyaXRlKCcoSVA6IDxpPjgwLjcyLjE1Mi4xNTU8 L2k+KSAnKTsKCQlvc25ld3Nfd2luZG93LmRvY3VtZW50LndyaXRlKCctIFBvc3RlZCBvbiAyMDA2 LTA2LTE5IDA5OjQ5OjQxPC9mb250PjwvdGQ+PC90cj4nKTsKICAgICAgICBvc25ld3Nfd2luZG93 LmRvY3VtZW50LndyaXRlKCc8dHI+PHRkIHZhbGlnbj0idG9wIiB3aWR0aD0iNjEwIiBjb2xzcGFu PSIyIiBiZ2NvbG9yPSIjZWVlZWVlIiBjbGFzcz0idGQiPicpOwoJCW9zbmV3c193aW5kb3cuZG9j dW1lbnQud3JpdGUoJzxmb250IGZhY2U9IkFyaWFsLCBTYW5zLXNlcmlmLCBUcmVidWNoZXQgTVMi IHNpemU9IjIiIGNvbG9yPSIjMDAwMDAwIj4nKTsKICAgICAgICBvc25ld3Nfd2luZG93LmRvY3Vt ZW50LndyaXRlKG5sMmJyKGZpbHRlcl9IVE1MKHViYjJodG1sKGRvY3VtZW50Lm9zbmV3c2Zvcm0u Zm9ydW1fdGV4dC52YWx1ZSkpKSk7CiAgICAgICAgb3NuZXdzX3dpbmRvdy5kb2N1bWVudC53cml0 ZSgnPC9mb250PjwvdGQ+PC90cj4nKTsKICAgICAgICBvc25ld3Nfd2luZG93LmRvY3VtZW50Lndy aXRlKCc8L3Rib2R5PjwvdGFibGU+Jyk7CiAgICAgICAgb3NuZXdzX3dpbmRvdy5kb2N1bWVudC53 cml0ZSgnPC9wPicpOwogICAgICAgIG9zbmV3c193aW5kb3cuZG9jdW1lbnQud3JpdGUoJzwvdGQ+ PC90cj48dHI+PHRkIGFsaWduPSJjZW50ZXIiPjxQPjxiPjxmb250IGZhY2U9ImFyaWFsIiBzaXpl PTI+Jyk7CgkJb3NuZXdzX3dpbmRvdy5kb2N1bWVudC53cml0ZSgnPGEgaHJlZj0iIyIgb25DbGlj az0ic2VsZi5jbG9zZSgpOyI+Q2xvc2UgV2luZG93PC9hPjwvYj48L2ZvbnQ+PC90ZD48L3RyPjwv dGFibGU+PC9ib2R5PjwvaHRtbD4nKTsKCQlvc25ld3Nfd2luZG93LmRvY3VtZW50LmNsb3NlKCk7 CiAgICAgICAgcHJldmlld193aW5kb3cgPSBvc25ld3Nfd2luZG93OwogICAgfQp9CgpmdW5jdGlv biBjbG9zZV9wcmV2aWV3KCkgewogICAgaWYgKCFwcmV2aWV3X3dpbmRvdy5jbG9zZWQpIHsKICAg ICAgICBwcmV2aWV3X3dpbmRvdy5jbG9zZSgpOwogICAgfQogICAgcmV0dXJuIHRydWU7Cn0KLS0+ Cjwvc2NyaXB0Pgo8IS0tIEVuZCBvZiBKYXZhc2NyaXB0IC0tPjwvVEQ+CjwvVFI+CjwvVEFCTEU+ Cg== 16694 2006-06-19 12:03:14 +0000 2006-06-19 12:03:14 +0000 Patch osnews.diff text/plain 1117 kde SW5kZXg6IGh0bWwvaHRtbF9mb3JtaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaHRtbC9odG1sX2Zv cm1pbXBsLmNwcAkocmV2aXNpb24gNTUxNjcyKQorKysgaHRtbC9odG1sX2Zvcm1pbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtODczLDYgKzg3Myw5IEBACiAJICAgIG1fZm9ybS0+cmVnaXN0ZXJG b3JtRWxlbWVudCh0aGlzKTsKICAgICB9CiAKKyAgICBpZiAoIW1fZm9ybSkKKyAgICAgICAga2RE ZWJ1ZyggNjAzMCApIDw8ICJObyBmb3JtIGZvdW5kIGZvciBmb3JtLWVsZW1lbnQhIiA8PCBlbmRs OworCiAgICAgTm9kZUJhc2VJbXBsOjphdHRhY2goKTsKIAogICAgIC8vIFRoZSBjYWxsIHRvIHVw ZGF0ZUZyb21FbGVtZW50KCkgbmVlZHMgdG8gZ28gYWZ0ZXIgdGhlIGNhbGwgdGhyb3VnaApAQCAt ODkwLDYgKzg5MywxMSBAQAogICAgIHsKICAgICAgICAgaWYoIHAtPmlkKCkgPT0gSURfRk9STSAp CiAgICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8SFRNTEZvcm1FbGVtZW50SW1wbCAqPihw KTsKKyAgICAgICAgaWYoIHAtPnBhcmVudE5vZGUoKSAmJiBwLT5wYXJlbnROb2RlKCktPmlkKCkg PT0gSURfVEFCTEUgJiYgcC0+cHJldmlvdXNTaWJsaW5nKCkgKQorICAgICAgICB7CisgICAgICAg ICAgICBwID0gcC0+cHJldmlvdXNTaWJsaW5nKCk7CisgICAgICAgICAgICBjb250aW51ZTsKKyAg ICAgICAgfQogICAgICAgICBwID0gcC0+cGFyZW50Tm9kZSgpOwogICAgIH0KICNpZmRlZiBGT1JN U19ERUJVRwpAQCAtMTkxNSw3ICsxOTIzLDcgQEAKIAkgICAgaWYgKGZvcm1Ob2RlKSB7CiAJCWdl dERvY3VtZW50KCktPnNldEZvY3VzTm9kZShmb3JtTm9kZSk7CiAJCWlmIChmb3JtTm9kZS0+aWQo KT09SURfSU5QVVQpCi0JCSAgICBzdGF0aWNfY2FzdDxET006OkhUTUxJbnB1dEVsZW1lbnRJbXBs Kj4oZm9ybU5vZGUpLT5jbGljaygpOworCQkgICAgc3RhdGljX2Nhc3Q8RE9NOjpIVE1MSW5wdXRF bGVtZW50SW1wbCo+KGZvcm1Ob2RlKS0+ZGVmYXVsdEV2ZW50SGFuZGxlcihldnQpOwogCQlldnQt PnNldERlZmF1bHRIYW5kbGVkKCk7CiAJICAgIH0KIAl9Cg==