112118 2005-09-06 14:52:03 +0000 Juk no longer finds covers 2005-10-25 22:35:53 +0000 1 1 2 Applications juk general unspecified Debian testing Linux RESOLVED FIXED NOR normal --- 1 aledj wheeler sleepkreep 0 oldest_to_newest 371123 0 aledj 2005-09-06 14:52:03 +0000 Version: 2.2.2 (using KDE KDE 3.4.2) Installed from: Debian testing/unstable Packages Compiler: Gcc 4.0.1 amd64 platform OS: Linux I can't download covers with Cover Manager any more: any search with it (that I think uses Google) will give no results. Even for covers I downloaded with Juk of KDE 3.4.1, that I'm sure they are on the net. Even if I try to search with a more general question. Any other experiencing this problem? My solution now is to manually download a cover from Google and then load it in Juk. 371217 1 mpyne 2005-09-07 00:11:36 +0000 This is because of a change in the way KHTML works. JuK wasn't properly using KHTML so a change in KHTML exposed a bug in JuK's handling of the feature. I'm surprised it didn't crash. Anyways, the bug is fixed in /trunk, and I thought I backported the fix but it appears that I forgot. I will backport and the fix should work in 3.4.3 (and will also be in 3.5). 371219 2 mpyne 2005-09-07 00:12:39 +0000 SVN commit 457901 by mpyne: Backport fix for bug 112118 (JuK Google cover search doesn't work anymore) to KDE 3.4. Sorry about forgetting to do so earlier. BUG:112118 M +13 -1 googlefetcher.cpp --- branches/KDE/3.4/kdemultimedia/juk/googlefetcher.cpp #457900:457901 @@ -18,6 +18,8 @@ #include <dom/dom_exception.h> #include <dom/dom2_traversal.h> +#include <khtml_part.h> + #include <kapplication.h> #include <kstatusbar.h> #include <kmainwindow.h> @@ -85,8 +87,18 @@ // choice if we're going to screen-scrape Google. try { - DOM::HTMLDocument search; + KHTMLPart part; + + // Create empty document. + + part.begin(); + part.end(); + + DOM::HTMLDocument search = part.htmlDocument(); search.setAsync(false); // Grab the document before proceeding. + + kdDebug(65432) << "Performing Google Search: " << url << endl; + search.load(url.url()); DOM::HTMLElement body = search.body(); 384525 3 mpyne 2005-10-25 22:35:53 +0000 *** Bug 114979 has been marked as a duplicate of this bug. ***