108523 2005-07-04 08:27:28 +0000 "empty trash" sometimes stays inactive 2007-09-14 12:17:01 +0000 1 1 10 Unmaintained kmail general unspecified Gentoo Packages Linux RESOLVED FIXED NOR normal --- 0 matofesi pim-bugs-null 0 oldest_to_newest 355265 0 matofesi 2005-07-04 08:27:28 +0000 Version: (using KDE KDE 3.4.1) Installed from: Gentoo Packages I use message filtering with kmail and I have some filters that put messages received with POP3 directly into trash. When I receive mail and open trash I can see some messages and then use context menu to empty trash - everything is fine to this point. After emptying trash "empty trash" in context menu deactivates as there should be no messages in trash to remove. But then I receive messages from another account - this is some information eccount and all of its messages are filtered into trash. After that when I try to empty trash again (trash folder is the one that is opened for all the time) the "empty trash" in context menu is inactive - kmail didn't noticed that some messages have been put into trash using filters. 380241 1 matofesi 2005-10-09 17:40:46 +0000 I've just found out exactly when the "empty trash" stays disabled with some mail in trash. The problem occurs when the trash is empty and you select the trash - "empty trash" is disabled. If then you receive some mail that is filterd directly to trash, trash contains some mail but "empty trash" is still disabled - it looks like filtering should notify rest of kmail that it put some mails into trash. And BTW I currently use KDE 3.5 beta 1. 429504 2 matofesi 2006-04-10 09:50:48 +0000 And to make sure the report doesn't got forgotten - the same behaviour is still present in KDE 3.5.2. To confirm it you just need to create a filter in kmail that moves some incoming mail into trash and mark it as read (I'm not sure if the last part is necessary), then select trash folder, make sure it's empty, select another folder then trash again ("empty trash" in context menu shoud be inactive) and then download some mail that would be filtered directly to trash - even though trash contains some mail the "empty trash" stays inactive auntil you select another folder and then trash again. 429579 3 15543 matofesi 2006-04-10 15:25:44 +0000 Created attachment 15543 update "empty trash" menu to reflect trash status Ok. I did some ugly hacking and I think I can show the rough idea of what I would like to be done "the proper way" (probably somewhere in asynchroneous kmail mechanisms after messages really got deleted). For now the patch works fine for me - it calls updateFolderMenu() after fetching mail making sure everyting is updated even after filtering. To make things work properly it also disables mEmptyFolderAction in slotEmptyFolder. Now I can have messages filtered directly to trash that is selected and I the "Empty trash" menu changes it's state depending on the trash status (and it also works for "Move all to trash"). 444518 4 matofesi 2006-06-05 17:16:36 +0000 Just installed KDE 3.5.3 - bug is still there :( 458576 5 matofesi 2006-08-07 08:36:58 +0000 Just installed KDE 3.5.4 - bug is still there :( 477204 6 matofesi 2006-10-16 09:42:27 +0000 Just to let anyone (?) reading (??) this - 3.5.5 installed with bug still there. 477399 7 winter 2006-10-16 22:56:53 +0000 SVN commit 596184 by winterz: Fix Bug 108523: "empty trash" sometimes stays inactive. Patch provided by Maciej J . Woloszyk. Thanks Maciej! Patch approved by Ingo. BUGS: 108523 M +8 -0 kmmainwidget.cpp --- branches/KDE/3.5/kdepim/kmail/kmmainwidget.cpp #596183:596184 @@ -846,6 +846,10 @@ } } + // update folder menus in case some mail got filtered to trash/current folder + // and we can enable "empty trash/move all to trash" action etc. + updateFolderMenu(); + if ( !showNotification ) return; @@ -1013,6 +1017,10 @@ BroadcastStatus::instance()->setStatusMsg(i18n("Moved all messages to the trash")); updateMessageActions(); + + // Disable empty trash/move all to trash action - we've just deleted/moved all folder + // contents. + mEmptyFolderAction->setEnabled( false ); } 15543 2006-04-10 15:25:44 +0000 2006-04-10 15:25:44 +0000 update "empty trash" menu to reflect trash status kmail-update-empty_trash.patch text/plain 707 matofesi LS0tIGtkZXBpbS0zLjUuMi9rbWFpbC1vbGQva21tYWlud2lkZ2V0LmNwcAkyMDA2LTAzLTE3IDEx OjE1OjU0LjAwMDAwMDAwMCArMDEwMAorKysga2RlcGltLTMuNS4yL2ttYWlsL2ttbWFpbndpZGdl dC5jcHAJMjAwNi0wNC0xMCAxNToyMDowNC4wMDAwMDAwMDAgKzAyMDAKQEAgLTg0NSw2ICs4NDUs MTAgQEAKICAgICB9CiAgIH0KIAorICAvLyB1cGRhdGUgZm9sZGVyIG1lbnVzIGluIGNhc2Ugc29t ZSBtYWlsIGdvdCBmaWx0ZXJlZCB0byB0cmFzaC9jdXJyZW50IGZvbGRlcgorICAvLyBhbmQgd2Ug Y2FuIGVuYWJsZSAiZW1wdHkgdHJhc2gvbW92ZSBhbGwgdG8gdHJhc2giIGFjdGlvbiBldGMuCisg IHVwZGF0ZUZvbGRlck1lbnUoKTsKKwogICBpZiAoICFzaG93Tm90aWZpY2F0aW9uICkKICAgICBy ZXR1cm47CiAKQEAgLTEwMTIsNiArMTAxNiwxMCBAQAogICAgIEJyb2FkY2FzdFN0YXR1czo6aW5z dGFuY2UoKS0+c2V0U3RhdHVzTXNnKGkxOG4oIk1vdmVkIGFsbCBtZXNzYWdlcyB0byB0aGUgdHJh c2giKSk7CiAKICAgdXBkYXRlTWVzc2FnZUFjdGlvbnMoKTsKKworICAvLyBEaXNhYmxlIGVtcHR5 IHRyYXNoL21vdmUgYWxsIHRvIHRyYXNoIGFjdGlvbiAtIHdlJ3ZlIGp1c3QgZGVsZXRlZC9tb3Zl ZCBhbGwgZm9sZGVyCisgIC8vIGNvbnRlbnRzLgorICBtRW1wdHlGb2xkZXJBY3Rpb24tPnNldEVu YWJsZWQoIGZhbHNlICk7CiB9CiAKIAo=