108400 2005-07-01 14:43:33 +0000 XMLHttpRequest doesn't handle document charset 2005-09-25 16:52:55 +0000 1 1 2 Applications konqueror khtml unspecified Gentoo Packages Linux RESOLVED FIXED NOR normal --- 0 kdeer konqueror-bugs-null 0 oldest_to_newest 354690 0 kdeer 2005-07-01 14:43:33 +0000 Version: (using KDE KDE 3.4.1) Installed from: Gentoo Packages Compiler: gcc 3 OS: Linux When I am trying to load an html fragment via XMLHttpRequest() and display it via *.innerHTML = *.responseText it shows up, I believe, in Latin encoding. Which is not the case for Firefox, MSIE and Opera. You can check out the behaviour at http://hacker.klever.net/range/konqueror-charset-bug/ which loads http://hacker.klever.net/range/konqueror-charset-bug/to-load.html Both documents return Content-Type: text/html; charset=windows-1251 354807 1 thiago 2005-07-02 02:48:52 +0000 I can reproduce (trunk 424191). 357953 2 adawit 2005-07-15 00:58:56 +0000 The attached patch should fix the problem. On Friday 01 July 2005 20:48, Thiago Macieira wrote: [bugs.kde.org quoted mail] Created an attachment (id=11811) xmlhttprequest.diff 357969 3 thiago 2005-07-15 03:31:30 +0000 I can confirm it fixes the problem. If you'll be so kind, Dawit, commit it :-) 358072 4 kdeer 2005-07-15 13:42:40 +0000 Great, I've seen you working in the logs ;-) Hope it's okay if I eventually remove the files I've put on the web. 358088 5 adawit 2005-07-15 15:48:09 +0000 SVN commit 434817 by adawit: - Use the charset provided by the remote host through the HTTP headers. BUG: 108400@bugs.kde.org M +12 -0 xmlhttprequest.cpp --- trunk/KDE/kdelibs/khtml/ecma/xmlhttprequest.cpp #434816:434817 @@ -553,6 +553,18 @@ #endif if ( decoder == NULL ) { + int pos = responseHeaders.find("Content-Type:"); + if ( pos > -1 ) + { + int index = responseHeaders.find('\n', pos+13); + QString type = responseHeaders.mid(pos+13, index); + // qDebug("XMLHttpRequest::slotData: 'content-type = %s'", type.latin1()); + index = type.find (';'); + if (index > -1) + encoding = type.mid( index+1 ).remove(QRegExp("charset[ ]*=[ ]*", false)).stripWhiteSpace(); + // qDebug("XMLHttpRequest::slotData: 'encoding = %s'", encoding.latin1()); + } + decoder = new Decoder; if (!encoding.isNull()) decoder->setEncoding(encoding.latin1(), Decoder::EncodingFromHTTPHeader); 375948 6 anton.bugs 2005-09-25 16:52:53 +0000 guys, your patch doesn't work for me. Please double check. Cheers, Anton ps. I think you have to apply it "encoding" after if (!encoding.isNull()) decoder->setEncoding(encoding.latin1(), Decoder::EncodingFromHTTPHeader); In the "fixme" line. 11811 2005-07-15 00:58:56 +0000 2005-07-15 00:58:56 +0000 xmlhttprequest.diff xmlhttprequest.diff text/x-diff 913 adawit SW5kZXg6IHhtbGh0dHByZXF1ZXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB4bWxodHRwcmVxdWVzdC5j cHAJKHJldmlzaW9uIDQzNDY0MikKKysrIHhtbGh0dHByZXF1ZXN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNTUzLDYgKzU1MywxOCBAQAogI2VuZGlmCiAKICAgaWYgKCBkZWNvZGVyID09IE5VTEwg KSB7CisgICAgIGludCBwb3MgPSByZXNwb25zZUhlYWRlcnMuZmluZCgiQ29udGVudC1UeXBlOiIp OworICAgICBpZiAoIHBvcyA+IC0xICkKKyAgICAgeworICAgICAgICBpbnQgaW5kZXggPSByZXNw b25zZUhlYWRlcnMuZmluZCgnXG4nLCBwb3MrMTMpOworICAgICAgICBRU3RyaW5nIHR5cGUgPSBy ZXNwb25zZUhlYWRlcnMubWlkKHBvcysxMywgaW5kZXgpOworICAgICAgICAvLyBxRGVidWcoIlhN TEh0dHBSZXF1ZXN0OjpzbG90RGF0YTogJ2NvbnRlbnQtdHlwZSA9ICVzJyIsIHR5cGUubGF0aW4x KCkpOworICAgICAgICBpbmRleCA9IHR5cGUuZmluZCAoJzsnKTsKKyAgICAgICAgaWYgKGluZGV4 ID4gLTEpCisgICAgICAgICAgZW5jb2RpbmcgPSB0eXBlLm1pZCggaW5kZXgrMSApLnJlbW92ZShR UmVnRXhwKCJjaGFyc2V0WyBdKj1bIF0qIiwgZmFsc2UpKS5zdHJpcFdoaXRlU3BhY2UoKTsKKyAg ICAgICAgLy8gcURlYnVnKCJYTUxIdHRwUmVxdWVzdDo6c2xvdERhdGE6ICdlbmNvZGluZyA9ICVz JyIsIGVuY29kaW5nLmxhdGluMSgpKTsKKyAgICAgfQorCiAgICAgZGVjb2RlciA9IG5ldyBEZWNv ZGVyOwogICAgIGlmICghZW5jb2RpbmcuaXNOdWxsKCkpCiAgICAgICBkZWNvZGVyLT5zZXRFbmNv ZGluZyhlbmNvZGluZy5sYXRpbjEoKSwgRGVjb2Rlcjo6RW5jb2RpbmdGcm9tSFRUUEhlYWRlcik7 Cg==