105108 2005-05-04 21:38:32 +0000 [patch] DOM retrieval of text-shadow property omits commas 2009-11-08 20:29:01 +0000 1 1 2 Applications konqueror khtml 3.4 openSUSE Linux RESOLVED FIXED NOR normal --- 1 bugs_kde konqueror-bugs-null faure finex germain magic maksim 0 oldest_to_newest 339618 0 bugs_kde 2005-05-04 21:38:33 +0000 Version: (using KDE KDE 3.4.0) Installed from: SuSE RPMs OS: Linux When retrieving the text-shadow property value via DOM, any commas are omitted... e.g. this.style.textShadow turns style="text-shadow: red 2px 2px 2px, orange 4px 4px 2px" into red 2px 2px 2pxorange 4px 4px 2px and not the expected red 2px 2px 2px, orange 4px 4px 2px 339619 1 10901 bugs_kde 2005-05-04 21:39:35 +0000 Created attachment 10901 testcase Click on the text to see the bug 339629 2 faure 2005-05-04 22:19:06 +0000 Tricky. I thought it was easy to fix in CSSValueListImpl::cssText(), but not all valuelists are comma-separated, apparently. See new testcase, which shows that text-shadow may be comma separated, but text-decoration is space separated, and both things get stuffed into the same class, so I don't know how to differenciate them. I hope another developer will find out :) 339630 3 10902 faure 2005-05-04 22:20:56 +0000 Created attachment 10902 new testcase 339631 4 10903 faure 2005-05-04 22:22:19 +0000 Created attachment 10903 patch which adds a comma, but which breaks style.textDecoration 524385 5 20501 magic 2007-05-06 18:10:21 +0000 Created attachment 20501 should fix without breaking other properties tested with kde4, not on the 3.5 branch 525518 6 20555 magic 2007-05-12 22:36:40 +0000 Created attachment 20555 another patch using an enum instead of a DOMString This patch replaces my previous one; it's using a enum and a bitfielded member as discussed with SadEagle on irc. 592309 7 finex 2008-04-06 18:31:59 +0000 Has the patch been applied on KDE4 ? 597320 8 lemma 2008-04-27 10:35:31 +0000 Doesn't work for me, neither on 3.5.9 nor on trunk. 857773 9 germain 2009-11-08 07:00:37 +0000 not sure why this patch got forgotten... sorry Vincent ;-/ I'll modify it a bit to add spaces between properties, extend it to other relevant CSS lists I can think of, and commit the result. 858156 10 germain 2009-11-08 20:29:01 +0000 SVN commit 1046456 by ggarand: need to distinguish at least two types of CSS value lists : those that use the comma as a separator when flattened to a string, and those that use the space. initial patch by Vincent Ricard <magic@magicninja.org>, with input from dfaure and SadEagle, extended to apply to (hopefully) all relevant properties. BUG: 105108 M +1 -1 css/css_renderstyledeclarationimpl.cpp M +1 -1 css/css_svgcssparser.cpp M +7 -1 css/css_valueimpl.cpp M +8 -1 css/css_valueimpl.h M +3 -3 css/css_webfont.cpp M +5 -5 css/cssparser.cpp M +1 -1 svg/SVGFontFaceElement.cpp M +1 -1 svg/SVGFontFaceSrcElement.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1046456 10901 2005-05-04 21:39:35 +0000 2005-05-04 22:20:56 +0000 testcase text-shadow.htm text/html 369 bugs_kde PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+CjxodG1sPgo8aGVh ZD4KPG1ldGEgSFRUUC1FUVVJVj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNo YXJzZXQ9aXNvLTg4NTktMSI+Cjx0aXRsZT48L3RpdGxlPgo8L2hlYWQ+Cjxib2R5Pgo8aDEgc3R5 bGU9InRleHQtc2hhZG93OiByZWQgMnB4IDJweCAycHgsIG9yYW5nZSA0cHggNHB4IDJweCIgb25j bGljaz0iYWxlcnQodGhpcy5zdHlsZS50ZXh0U2hhZG93KSI+VGV4dC1TaGFkb3cgaXMgV29vIGFu ZCBZYXk8L2gxPgo8L2JvZHk+CjwvaHRtbD4K 10902 2005-05-04 22:20:56 +0000 2005-05-04 22:20:56 +0000 new testcase css.html text/html 547 faure PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+CjxodG1sPgo8aGVh ZD4KPG1ldGEgSFRUUC1FUVVJVj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNo YXJzZXQ9aXNvLTg4NTktMSI+Cjx0aXRsZT48L3RpdGxlPgo8L2hlYWQ+Cjxib2R5Pgo8aDEgaWQ9 J2knIHN0eWxlPSJ0ZXh0LWRlY29yYXRpb246IHVuZGVybGluZSBvdmVybGluZTsgdGV4dC1zaGFk b3c6IHJlZCAycHggMnB4IDJweCwgb3JhbmdlIDRweCA0cHggMnB4Ij50ZXh0PC9oMT4KPHAgaWQ9 J3AnPjwvcD4KPC9ib2R5Pgo8c2NyaXB0PgogIGkgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn aScpOwogIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdwJykuaW5uZXJUZXh0ID0gInRleHRTaGFk b3c9IiArIGkuc3R5bGUudGV4dFNoYWRvdyArICIgdGV4dERlY29yYXRpb249IiArIGkuc3R5bGUu dGV4dERlY29yYXRpb247Cjwvc2NyaXB0Pgo8L2h0bWw+Cg== 10903 2005-05-04 22:22:19 +0000 2005-05-04 22:22:19 +0000 patch which adds a comma, but which breaks style.textDecoration css_valueimpl.cpp.diff text/plain 499 faure SW5kZXg6IGNzc192YWx1ZWltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNzc192YWx1ZWltcGwuY3Bw CShyZXZpc2lvbiA0MDkyMTkpCisrKyBjc3NfdmFsdWVpbXBsLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDQ0LDcgKzQ0NCw5IEBACiAgICAgRE9NU3RyaW5nIHJlc3VsdCA9ICIiOwogCiAgICAgZm9y IChRUHRyTGlzdEl0ZXJhdG9yPENTU1ZhbHVlSW1wbD4gaXRlcmF0b3IobV92YWx1ZXMpOyBpdGVy YXRvci5jdXJyZW50KCk7ICsraXRlcmF0b3IpIHsKLQlyZXN1bHQgKz0gaXRlcmF0b3IuY3VycmVu dCgpLT5jc3NUZXh0KCk7CisgICAgICAgIGlmICggIXJlc3VsdC5pc0VtcHR5KCkgKQorICAgICAg ICAgICAgcmVzdWx0ICs9ICIsIjsKKyAgICAgICAgcmVzdWx0ICs9IGl0ZXJhdG9yLmN1cnJlbnQo KS0+Y3NzVGV4dCgpOwogICAgIH0KIAogICAgIHJldHVybiByZXN1bHQ7Cg== 20501 2007-05-06 18:10:21 +0000 2007-05-12 22:36:40 +0000 should fix without breaking other properties 105108.patch text/plain 1538 magic SW5kZXg6IGNzc3BhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY3NzcGFyc2VyLmNwcAkocsOpdmlz aW9uIDY2MTcxNikKKysrIGNzc3BhcnNlci5jcHAJKGNvcGllIGRlIHRyYXZhaWwpCkBAIC04Njcs NyArODY3LDcgQEAKICAgICAgICAgaWYgKGlkID09IENTU19WQUxfTk9ORSkgewogICAgICAgICAg ICAgdmFsaWRfcHJpbWl0aXZlID0gdHJ1ZTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAg IENTU1ZhbHVlTGlzdEltcGwgKmxpc3QgPSBuZXcgQ1NTVmFsdWVMaXN0SW1wbDsKKyAgICAgICAg ICAgIENTU1ZhbHVlTGlzdEltcGwgKmxpc3QgPSBuZXcgQ1NTVmFsdWVMaXN0SW1wbChET01TdHJp bmcoIiwiKSk7CiAgICAgICAgICAgICBib29sIGlzX3ZhbGlkID0gdHJ1ZTsKICAgICAgICAgICAg IHdoaWxlKCBpc192YWxpZCAmJiB2YWx1ZSApIHsKICAgICAgICAgICAgICAgICBzd2l0Y2ggKCB2 YWx1ZS0+aWQgKSB7CkluZGV4OiBjc3NfdmFsdWVpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjc3Nf dmFsdWVpbXBsLmNwcAkocsOpdmlzaW9uIDY2MTcxNikKKysrIGNzc192YWx1ZWltcGwuY3BwCShj b3BpZSBkZSB0cmF2YWlsKQpAQCAtNTE0LDcgKzUxNCw5IEBACiAgICAgRE9NU3RyaW5nIHJlc3Vs dCA9ICIiOwogCiAgICAgZm9yIChRM1B0ckxpc3RJdGVyYXRvcjxDU1NWYWx1ZUltcGw+IGl0ZXJh dG9yKG1fdmFsdWVzKTsgaXRlcmF0b3IuY3VycmVudCgpOyArK2l0ZXJhdG9yKSB7Ci0JcmVzdWx0 ICs9IGl0ZXJhdG9yLmN1cnJlbnQoKS0+Y3NzVGV4dCgpOworICAgICAgICBpZiAoICFyZXN1bHQu aXNFbXB0eSgpICYmICFtX3NlcGFyYXRvci5pc0VtcHR5KCkpCisgICAgICAgICAgICByZXN1bHQg Kz0gbV9zZXBhcmF0b3I7CisgICAgICAgIHJlc3VsdCArPSBpdGVyYXRvci5jdXJyZW50KCktPmNz c1RleHQoKTsKICAgICB9CiAKICAgICByZXR1cm4gcmVzdWx0OwpJbmRleDogY3NzX3ZhbHVlaW1w bC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGNzc192YWx1ZWltcGwuaAkocsOpdmlzaW9uIDY2MTcxNikKKysr IGNzc192YWx1ZWltcGwuaAkoY29waWUgZGUgdHJhdmFpbCkKQEAgLTE0MCw2ICsxNDAsNyBAQAog ewogcHVibGljOgogICAgIENTU1ZhbHVlTGlzdEltcGwoKSA6IENTU1ZhbHVlSW1wbCgpIHt9Cisg ICAgQ1NTVmFsdWVMaXN0SW1wbChjb25zdCBET01TdHJpbmcmIHNlcCkgOiBDU1NWYWx1ZUltcGwo KSwgbV9zZXBhcmF0b3Ioc2VwKSB7fQogCiAgICAgdmlydHVhbCB+Q1NTVmFsdWVMaXN0SW1wbCgp OwogCkBAIC0xNTUsNiArMTU2LDcgQEAKIAogcHJvdGVjdGVkOgogICAgIFEzUHRyTGlzdDxDU1NW YWx1ZUltcGw+IG1fdmFsdWVzOworICAgIERPTVN0cmluZyBtX3NlcGFyYXRvcjsKIH07CiAKIAo= 20555 2007-05-12 22:36:40 +0000 2007-05-12 22:36:40 +0000 another patch using an enum instead of a DOMString 105108.enum.patch text/plain 1845 magic SW5kZXg6IGNzcy9jc3NwYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNzcy9jc3NwYXJzZXIuY3Bw CShyw6l2aXNpb24gNjYzOTIwKQorKysgY3NzL2Nzc3BhcnNlci5jcHAJKGNvcGllIGRlIHRyYXZh aWwpCkBAIC04NjcsNyArODY3LDcgQEAKICAgICAgICAgaWYgKGlkID09IENTU19WQUxfTk9ORSkg ewogICAgICAgICAgICAgdmFsaWRfcHJpbWl0aXZlID0gdHJ1ZTsKICAgICAgICAgfSBlbHNlIHsK LSAgICAgICAgICAgIENTU1ZhbHVlTGlzdEltcGwgKmxpc3QgPSBuZXcgQ1NTVmFsdWVMaXN0SW1w bDsKKyAgICAgICAgICAgIENTU1ZhbHVlTGlzdEltcGwgKmxpc3QgPSBuZXcgQ1NTVmFsdWVMaXN0 SW1wbChDU1NWYWx1ZUxpc3RJbXBsOjpDb21tYSk7CiAgICAgICAgICAgICBib29sIGlzX3ZhbGlk ID0gdHJ1ZTsKICAgICAgICAgICAgIHdoaWxlKCBpc192YWxpZCAmJiB2YWx1ZSApIHsKICAgICAg ICAgICAgICAgICBzd2l0Y2ggKCB2YWx1ZS0+aWQgKSB7CkluZGV4OiBjc3MvY3NzX3ZhbHVlaW1w bC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gY3NzL2Nzc192YWx1ZWltcGwuY3BwCShyw6l2aXNpb24gNjYz OTIwKQorKysgY3NzL2Nzc192YWx1ZWltcGwuY3BwCShjb3BpZSBkZSB0cmF2YWlsKQpAQCAtNTE0 LDcgKzUxNCw5IEBACiAgICAgRE9NU3RyaW5nIHJlc3VsdCA9ICIiOwogCiAgICAgZm9yIChRM1B0 ckxpc3RJdGVyYXRvcjxDU1NWYWx1ZUltcGw+IGl0ZXJhdG9yKG1fdmFsdWVzKTsgaXRlcmF0b3Iu Y3VycmVudCgpOyArK2l0ZXJhdG9yKSB7Ci0JcmVzdWx0ICs9IGl0ZXJhdG9yLmN1cnJlbnQoKS0+ Y3NzVGV4dCgpOworICAgICAgICBpZiAoIXJlc3VsdC5pc0VtcHR5KCkgJiYgbV9zZXBhcmF0b3Ig PT0gQ29tbWEpCisgICAgICAgICAgICByZXN1bHQgKz0gIiwiOworICAgICAgICByZXN1bHQgKz0g aXRlcmF0b3IuY3VycmVudCgpLT5jc3NUZXh0KCk7CiAgICAgfQogCiAgICAgcmV0dXJuIHJlc3Vs dDsKSW5kZXg6IGNzcy9jc3NfdmFsdWVpbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY3NzL2Nzc192YWx1 ZWltcGwuaAkocsOpdmlzaW9uIDY2MzkyMCkKKysrIGNzcy9jc3NfdmFsdWVpbXBsLmgJKGNvcGll IGRlIHRyYXZhaWwpCkBAIC0xMzksOCArMTM5LDE0IEBACiBjbGFzcyBDU1NWYWx1ZUxpc3RJbXBs IDogcHVibGljIENTU1ZhbHVlSW1wbAogewogcHVibGljOgotICAgIENTU1ZhbHVlTGlzdEltcGwo KSA6IENTU1ZhbHVlSW1wbCgpIHt9CisgICAgZW51bSBTZXBhcmF0b3IgeworICAgICAgICBOb25l LAorICAgICAgICBDb21tYQorICAgIH07CiAKKyAgICBDU1NWYWx1ZUxpc3RJbXBsKCkgOiBDU1NW YWx1ZUltcGwoKSwgbV9zZXBhcmF0b3IoTm9uZSkge30KKyAgICBDU1NWYWx1ZUxpc3RJbXBsKFNl cGFyYXRvciBzZXApIDogQ1NTVmFsdWVJbXBsKCksIG1fc2VwYXJhdG9yKHNlcCkge30KKwogICAg IHZpcnR1YWwgfkNTU1ZhbHVlTGlzdEltcGwoKTsKIAogICAgIHVuc2lnbmVkIGxvbmcgbGVuZ3Ro KCkgY29uc3QgeyByZXR1cm4gbV92YWx1ZXMuY291bnQoKTsgfQpAQCAtMTU0LDYgKzE2MCw3IEBA CiAgICAgdmlydHVhbCBET006OkRPTVN0cmluZyBjc3NUZXh0KCkgY29uc3Q7CiAKIHByb3RlY3Rl ZDoKKyAgICBTZXBhcmF0b3IgbV9zZXBhcmF0b3I6MTsKICAgICBRM1B0ckxpc3Q8Q1NTVmFsdWVJ bXBsPiBtX3ZhbHVlczsKIH07CiAK