104895 2005-05-01 09:39:56 +0000 Screenshots are not rescaled when resizing window 2005-05-07 13:41:54 +0000 1 1 10 Unmaintained ksnapshot general unspecified Compiled Sources Linux RESOLVED FIXED NOR normal --- 0 karl rich 0 oldest_to_newest 338796 0 karl 2005-05-01 09:39:56 +0000 Version: (using KDE Devel) Installed from: Compiled sources When resizing (enlarging) the KSnapshow window, the screenshot thumbnail is not rescaled to fit the available space. It should. Also, the lower panel (the area over the horizontal line) is resized vertically. It should not, since it doesn't contain any text to fill the added vertical space. Only the upper panel should be resized. 338899 1 isaac 2005-05-01 17:32:11 +0000 > Also, the lower panel (the area over the horizontal line) is resized > vertically. It should not, since it doesn't contain any text to fill the > added vertical space. Only the upper panel should be resized. I agree, removing the widget named "spacer3" from ksnapshot/ksnapshotwidget.ui fixes it, leaving more space for the snapshot preview. 340108 2 10926 isaac 2005-05-07 11:51:34 +0000 Created attachment 10926 Patch for this bug This patch should "fix" this bug. As it is my first patch I should be carefully reviewed, I'm not sure if this is the best way to do it or even if I'm breaking anything else, but it's working here against latest SVN :) Best regards 340120 3 binner 2005-05-07 13:41:50 +0000 SVN commit 410274 by binner: Rescale screenshot preview when resizing window Patch by Isaac Clerencia <isaac@sindominio.net> BUG: 104895 M +9 -0 branches/KDE/3.4/kdegraphics/ksnapshot/ksnapshot.cpp M +3 -1 branches/KDE/3.4/kdegraphics/ksnapshot/ksnapshot.h --- branches/KDE/3.4/kdegraphics/ksnapshot/ksnapshot.cpp #410273:410274 @@ -114,6 +114,7 @@ } connect( &grabTimer, SIGNAL( timeout() ), this, SLOT( grabTimerDone() ) ); + connect( &updateTimer, SIGNAL( timeout() ), this, SLOT( updatePreview() ) ); QTimer::singleShot( 0, this, SLOT( updateCaption() ) ); KHelpMenu *helpMenu = new KHelpMenu(this, KGlobal::instance()->aboutData(), false); @@ -151,6 +152,14 @@ { } +void KSnapshot::resizeEvent( QResizeEvent *event) +{ + if( !updateTimer.isActive() ) + updateTimer.start(200, true); + else + updateTimer.changeInterval(200); +} + bool KSnapshot::save( const QString &filename ) { return save( KURL::fromPathOrURL( filename )); --- branches/KDE/3.4/kdegraphics/ksnapshot/ksnapshot.h #410273:410274 @@ -85,17 +85,18 @@ void reject() { close(); } virtual void closeEvent( QCloseEvent * e ); + void resizeEvent(QResizeEvent*); bool eventFilter( QObject*, QEvent* ); private slots: void grabTimerDone(); void slotDragSnapshot(); void updateCaption(); + void updatePreview(); void slotRegionGrabbed( const QPixmap & ); private: bool save( const KURL& url ); - void updatePreview(); void performGrab(); void autoincFilename(); int grabMode(); @@ -103,6 +104,7 @@ QPixmap snapshot; QTimer grabTimer; + QTimer updateTimer; QWidget* grabber; KURL filename; KSnapshotWidget *mainWidget; 10926 2005-05-07 11:51:34 +0000 2005-05-07 11:51:34 +0000 Patch for this bug ksnapshot.diff text/plain 1641 isaac SW5kZXg6IGtzbmFwc2hvdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga3NuYXBzaG90LmNwcAkocmV2aXNp b24gNDA5NzYxKQorKysga3NuYXBzaG90LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE0LDYgKzEx NCw3IEBACiAgICAgfQogCiAgICAgY29ubmVjdCggJmdyYWJUaW1lciwgU0lHTkFMKCB0aW1lb3V0 KCkgKSwgdGhpcywgU0xPVCggIGdyYWJUaW1lckRvbmUoKSApICk7CisgICAgY29ubmVjdCggJnVw ZGF0ZVRpbWVyLCBTSUdOQUwoIHRpbWVvdXQoKSApLCB0aGlzLCBTTE9UKCAgdXBkYXRlUHJldmll dygpICkgKTsKICAgICBRVGltZXI6OnNpbmdsZVNob3QoIDAsIHRoaXMsIFNMT1QoIHVwZGF0ZUNh cHRpb24oKSApICk7CiAKICAgICBLSGVscE1lbnUgKmhlbHBNZW51ID0gbmV3IEtIZWxwTWVudSh0 aGlzLCBLR2xvYmFsOjppbnN0YW5jZSgpLT5hYm91dERhdGEoKSwgZmFsc2UpOwpAQCAtMTUxLDYg KzE1MiwxNCBAQAogewogfQogCit2b2lkIEtTbmFwc2hvdDo6cmVzaXplRXZlbnQoIFFSZXNpemVF dmVudCAqZXZlbnQpCit7CisJaWYoICF1cGRhdGVUaW1lci5pc0FjdGl2ZSgpICkKKwkJdXBkYXRl VGltZXIuc3RhcnQoMjAwLCB0cnVlKTsKKwllbHNlCQorCQl1cGRhdGVUaW1lci5jaGFuZ2VJbnRl cnZhbCgyMDApOworfQorCiBib29sIEtTbmFwc2hvdDo6c2F2ZSggY29uc3QgUVN0cmluZyAmZmls ZW5hbWUgKQogewogICAgIHJldHVybiBzYXZlKCBLVVJMOjpmcm9tUGF0aE9yVVJMKCBmaWxlbmFt ZSApKTsKSW5kZXg6IGtzbmFwc2hvdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtzbmFwc2hvdC5oCShyZXZp c2lvbiA0MDk3NjEpCisrKyBrc25hcHNob3QuaAkod29ya2luZyBjb3B5KQpAQCAtODUsMTcgKzg1 LDE4IEBACiAgICAgdm9pZCByZWplY3QoKSB7IGNsb3NlKCk7IH0KIAogICAgIHZpcnR1YWwgdm9p ZCBjbG9zZUV2ZW50KCBRQ2xvc2VFdmVudCAqIGUgKTsKKyAgICB2b2lkIHJlc2l6ZUV2ZW50KFFS ZXNpemVFdmVudCopOwogICAgIGJvb2wgZXZlbnRGaWx0ZXIoIFFPYmplY3QqLCBRRXZlbnQqICk7 CiAgICAgCiBwcml2YXRlIHNsb3RzOgogICAgIHZvaWQgZ3JhYlRpbWVyRG9uZSgpOwogICAgIHZv aWQgc2xvdERyYWdTbmFwc2hvdCgpOwogICAgIHZvaWQgdXBkYXRlQ2FwdGlvbigpOworICAgIHZv aWQgdXBkYXRlUHJldmlldygpOwogICAgIHZvaWQgc2xvdFJlZ2lvbkdyYWJiZWQoIGNvbnN0IFFQ aXhtYXAgJiApOwogCiBwcml2YXRlOgogICAgIGJvb2wgc2F2ZSggY29uc3QgS1VSTCYgdXJsICk7 Ci0gICAgdm9pZCB1cGRhdGVQcmV2aWV3KCk7CiAgICAgdm9pZCBwZXJmb3JtR3JhYigpOwogICAg IHZvaWQgYXV0b2luY0ZpbGVuYW1lKCk7CiAgICAgaW50IGdyYWJNb2RlKCk7CkBAIC0xMDMsNiAr MTA0LDcgQEAKIAogICAgIFFQaXhtYXAgc25hcHNob3Q7CiAgICAgUVRpbWVyIGdyYWJUaW1lcjsK KyAgICBRVGltZXIgdXBkYXRlVGltZXI7CiAgICAgUVdpZGdldCogZ3JhYmJlcjsKICAgICBLVVJM IGZpbGVuYW1lOwogICAgIEtTbmFwc2hvdFdpZGdldCAqbWFpbldpZGdldDsK