103941 2005-04-15 11:05:35 +0000 Konqueror does not understand unchecked 'URLs expire after' while loading preferences (Maximum age of History entries=0) 2005-04-19 22:47:59 +0000 1 1 2 Applications konqueror general unspecified unspecified Linux RESOLVED FIXED NOR normal --- 0 piotr.budny+bugskde konqueror-bugs-null 0 oldest_to_newest 334718 0 piotr.budny+bugskde 2005-04-15 11:05:35 +0000 Version: (using KDE KDE 3.4.0) Installed from: Unlisted Binary Package Compiler: gcc-3.3.5-2 OS: Linux When I uncheck checkbox 'URLs expire after', konqueror saves in konquerorrc the state as Do not expire URLs: Maximum age of History entries=0, that's OK. But when I open the history preferences dialog again, the checkbox is checked, the number of days is enabled, and it's value is set to 1. When I do changes on this dialog (even not touching URLs expire after) and I click OK, the preferences dialog saves the new Maximum age to 1. Whilst it should read the state 0 as unckecked URLs expiration age (not to expire) and disabled spinbox. 335032 1 10671 piotr.budny+bugskde 2005-04-16 15:40:02 +0000 Created attachment 10671 Patch that fixes that bug I don't know if it is done right, keep in mind I'm the beginner as a developer in Qt/KDE 335965 2 pascal.letourneau 2005-04-19 22:47:59 +0000 CVS commit by pletourn: Allow the history to be disabled BUG:103941 M +2 -2 kcmhistory.cpp 1.16.2.2 --- kdebase/konqueror/sidebar/trees/history_module/kcmhistory.cpp #1.16.2.1:1.16.2.2 @@ -60,6 +60,6 @@ HistorySidebarConfig::HistorySidebarConf dialog = new KonqSidebarHistoryDlg(this); - dialog->spinEntries->setRange( 1, INT_MAX, 1, false ); - dialog->spinExpire->setRange( 1, INT_MAX, 1, false ); + dialog->spinEntries->setRange( 0, INT_MAX, 1, false ); + dialog->spinExpire->setRange( 0, INT_MAX, 1, false ); dialog->spinNewer->setRange( 0, INT_MAX, 1, false ); 10671 2005-04-16 15:40:02 +0000 2005-04-16 15:40:02 +0000 Patch that fixes that bug kcmhistory.cpp.diff text/plain 778 piotr.budny+bugskde LS0tIGtkZWJhc2UtMy40LjAva29ucXVlcm9yL3NpZGViYXIvdHJlZXMvaGlzdG9yeV9tb2R1bGUv a2NtaGlzdG9yeS5jcHB+CTIwMDUtMDItMjMgMTI6Mjc6MDEuMDAwMDAwMDAwICswMTAwCisrKyBr ZGViYXNlLTMuNC4wL2tvbnF1ZXJvci9zaWRlYmFyL3RyZWVzL2hpc3RvcnlfbW9kdWxlL2tjbWhp c3RvcnkuY3BwCTIwMDUtMDQtMTYgMTU6MjU6NDEuMDM5OTMzMTI4ICswMjAwCkBAIC0xMjAsNyAr MTIwLDcgQEAKICAgICBjb25maWcuc2V0R3JvdXAoIkhpc3RvcnlTZXR0aW5ncyIpOwogICAgIGRp YWxvZy0+c3BpbkV4cGlyZS0+c2V0VmFsdWUoIGNvbmZpZy5yZWFkTnVtRW50cnkoICJNYXhpbXVt IGFnZSBvZiBIaXN0b3J5IGVudHJpZXMiLCA5MCkgKTsKICAgICBkaWFsb2ctPnNwaW5FbnRyaWVz LT5zZXRWYWx1ZSggY29uZmlnLnJlYWROdW1FbnRyeSggIk1heGltdW0gb2YgSGlzdG9yeSBlbnRy aWVzIiwgNTAwICkgKTsKLSAgICBkaWFsb2ctPmNiRXhwaXJlLT5zZXRDaGVja2VkKCBkaWFsb2ct PnNwaW5FeHBpcmUtPnZhbHVlKCkgPiAwICk7CisgICAgZGlhbG9nLT5jYkV4cGlyZS0+c2V0Q2hl Y2tlZCggY29uZmlnLnJlYWROdW1FbnRyeSggIk1heGltdW0gYWdlIG9mIEhpc3RvcnkgZW50cmll cyIsIDkwKSA+IDAgKTsKIAogICAgIGRpYWxvZy0+c3Bpbk5ld2VyLT5zZXRWYWx1ZSggbV9zZXR0 aW5ncy0+bV92YWx1ZVlvdW5nZXJUaGFuICk7CiAgICAgZGlhbG9nLT5zcGluT2xkZXItPnNldFZh bHVlKCBtX3NldHRpbmdzLT5tX3ZhbHVlT2xkZXJUaGFuICk7Cg==