<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>100781</bug_id>
          
          <creation_ts>2005-03-04 01:18:56 +0000</creation_ts>
          <short_desc>Preview in Theme manager should not be scaled</short_desc>
          <delta_ts>2005-04-05 17:43:48 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>kcontrol</product>
          <component>kthememanager</component>
          <version>unspecified</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Malte S. Stretz">mss</reporter>
          <assigned_to name="Lukáš Tinkl">lukas</assigned_to>
          
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>320799</commentid>
    <comment_count>0</comment_count>
    <who name="Malte S. Stretz">mss</who>
    <bug_when>2005-03-04 01:18:56 +0000</bug_when>
    <thetext>Version:           0.4 (using KDE 3.4.0, Gentoo)
Compiler:          gcc version 3.3.5 (Gentoo Linux 3.3.5-r1, ssp-3.3.2-3, pie-8.7.7.1)
OS:                Linux (i686) release 2.6.10-gentoo-r4

On my 1280x1024 screen with a maximized KControl, the preview in the Theme Manager looks ugly as hell because it is scaled up to a size where everything is just blurred.

The preview should not be scaled, or only scaled down if the window is too small, but never up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331798</commentid>
    <comment_count>1</comment_count>
    <who name="Stephan Binner">binner</who>
    <bug_when>2005-04-04 23:52:34 +0000</bug_when>
    <thetext>I agree. But as it seems to be added intentionally (kthememanager.cpp#392) let&apos;s hear what Lukas says against removing the scaling.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332026</commentid>
    <comment_count>2</comment_count>
    <who name="Stephan Binner">binner</who>
    <bug_when>2005-04-05 17:43:48 +0000</bug_when>
    <thetext>CVS commit by binner: 

Don&apos;t scale up preview (#100781)
BUG:100781


  M +3 -1      kthememanager.cpp   1.21.2.1


--- kdebase/kcontrol/kthememanager/kthememanager.cpp  #1.21:1.21.2.1
@@ -390,4 +390,6 @@ void kthememanager::updatePreview( const
      kdDebug() &lt;&lt; &quot;Preview is in file: &quot; &lt;&lt; pixFile &lt;&lt; endl;
      QImage preview( pixFile, &quot;PNG&quot; );
+     if (preview.width()&gt;dlg-&gt;lbPreview-&gt;contentsRect().width() ||
+         preview.height()&gt;dlg-&gt;lbPreview-&gt;contentsRect().height() )
      preview = preview.smoothScale( dlg-&gt;lbPreview-&gt;contentsRect().size(), QImage::ScaleMin );
      QPixmap pix;
</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>