100733 2005-03-03 13:55:40 +0000 When you select an app from the down list, is executed,and should wait for the click 2009-01-02 20:30:28 +0000 1 1 10 Unmaintained kdesktop general unspecified unspecified Linux CLOSED FIXED NOR normal --- 1 mmodem00 faure adawit aseigo finex 0 oldest_to_newest 320567 0 mmodem00 2005-03-03 13:55:41 +0000 Version: 3.4.0 (using KDE 3.4.0, Mandrake Linux Cooker i586 - Cooker) Compiler: gcc version 3.4.3 (Mandrakelinux 10.2 3.4.3-3mdk) OS: Linux (i686) release 2.6.8.1-24mdk Folowing the steps, click in Kmenu -> Run Command, there if you click to show the list of runned apps and you select one, its executed imediatly, and shouldnt happen that, it should wait for the click to run the command. How can this be fixed? 320629 1 aseigo 2005-03-03 16:47:33 +0000 yay, this bug is back =/ 320653 2 faure 2005-03-03 18:20:52 +0000 I don't think this behavior was ever different. IIRC Dawit made it that way from the start, arguing that it saved a click (or a keypress). However I agree that this is a bug: what if I select an item from the history in order to "fix" that command line? Then it shouldn't submit immediately. 320850 3 adawit 2005-03-04 09:01:05 +0000 On Thursday 03 March 2005 12:20, David Faure wrote: > ------- Additional Comments From faure kde org 2005-03-03 18:20 ------- > I don't think this behavior was ever different. IIRC Dawit made it that way > from the start, arguing that it saved a click (or a keypress). However I > agree that this is a bug: what if I select an item from the history in > order to "fix" that command line? Then it shouldn't submit immediately. Actually, the problem is not in minicli. It is in KCompletionBox. Yes, it can be easily fixed in minicli, but the last time we did that people on the other side of the fence complained to no end so it was reverted since it changed the original behavior. However, we can easily solve this problem the same way we solved the problem selecting and item using the keyboard and pressing the Enter key. If you press Shift+Enter, the item is only selected ; so following the same scheme (for consistency sake) the following patch to KCompletionBox allows you to simply select the item using Shift+Click (can be made LeftButton click only if that is what is desired).... Created an attachment (id=9963) kcompletionbox.diff 320906 4 faure 2005-03-04 11:53:26 +0000 On Friday 04 March 2005 09:01, Dawit Alemayehu wrote: > Actually, the problem is not in minicli. It is in KCompletionBox. Yes, it can > be easily fixed in minicli, but the last time we did that people on the other > side of the fence complained to no end so it was reverted since it changed > the original behavior. Do you have a reference (bug number or mailing-list archive) to those "complaints"? Honestly I can't see how someone would defend this. I mean OK maybe for the keyboard case, but certainly not for the mouse case: clicking an item in a list never submitted the dialog, anywhere else, ever. Only the "pressing Return" case is sort of arguable. > However, we can easily solve this problem the same way > we solved the problem selecting and item using the keyboard and pressing the > Enter key. If you press Shift+Enter, the item is only selected ; so following > the same scheme (for consistency sake) the following patch to KCompletionBox > allows you to simply select the item using Shift+Click (can be made > LeftButton click only if that is what is desired).... Personally I disagree. This bug report would still be here even if Shift+Click did the job. Who would find this hidden secret? 320996 5 aseigo 2005-03-04 17:39:43 +0000 i agree with David completely. make Shift+Click the "select + execute" command. but it really makes no sense whatsoever to have the default "select + execute" here's the use case that i run into: i select something to run from the completion list and then want to change the user to run it is ... but... it's already executed. bleh. this makes the run dialog's other features _useless_ in combination with the autocompletion list. 321006 6 adawit 2005-03-04 18:16:36 +0000 I personally have no preference about this issue as it pretains to Minicli ; so please feel free to remove/comment out the signal/slot that causes this in Minicli... 321059 7 faure 2005-03-04 23:03:10 +0000 > I personally have no preference about this issue as it pretains to Minicli ; so please feel free to remove/comment out the signal/slot that causes this in Minicli... Thanks but which signal/slot? :) If I remove this connect then there's no way to submit with Return at all anymore (even when no completion is open). - connect( m_dlg->cbCommand, SIGNAL( activated( const QString& ) ), - m_dlg->pbRun, SLOT( animateClick() ) ); I guess it's something deeper in the completion popup that we need to deactivate... But I don't see how - I guess we need a new setTrapReturnKey or similar in KCompletionBox itself, since currently it only consumes Shift+Enter events? 321143 8 mmodem00 2005-03-05 05:11:53 +0000 Well i applyed the patch but didnt make any difference! 321147 9 adawit 2005-03-05 05:26:53 +0000 On Friday 04 March 2005 23:11, mmodem00@netvisao.pt wrote: > ------- You are receiving this mail because: ------- > You are on the CC list for the bug, or are watching someone who is. > > http://bugs.kde.org/show_bug.cgi?id=100733 > > > > > ------- Additional Comments From mmodem00 netvisao pt 2005-03-05 05:11 > ------- Well i applyed the patch but didnt make any difference! Did you make sure you make install in kdelibs/kdeui and restart KDE beforehand ? Otherwise the change will not take effect. Once you do that the Shift+Click should not execute the selection with that patch. However, it is a moot point now since I will post a new patch that changes the behavior as requested. Since previous discussions... 321149 10 mmodem00 2005-03-05 05:33:06 +0000 AH is needed to press in Shift with the click. Well but the correct behaviour wouldnt be with the need of pressing in the Shift key, should work onli with the mouse click, and with that, just after i click in a app from the drop down list, is executed without waiting for the click in the execute button. 321167 11 adawit 2005-03-05 08:22:42 +0000 Dave, Indeed KCompletionBox needed to be modified ; so here is a couple of patches for KCompletionBox and one for Minicli which should forever fix this problem... Created an attachment (id=9976) kcompletionbox.diff Created an attachment (id=9977) minicli.diff 321444 12 faure 2005-03-06 02:50:46 +0000 On Saturday 05 March 2005 08:22, Dawit Alemayehu wrote: > Indeed KCompletionBox needed to be modified ; so here is a couple of patches > for KCompletionBox and one for Minicli which should forever fix this > problem... Dawit: Thanks for the patches. I can confirm that they don't work though :/ kdesktop: [void KCompletionBox::setActivateOnSelect(bool)] false That's called fine, but the rest of the new code isn't hit, when I click on an item in the popup. 321461 13 adawit 2005-03-06 03:26:00 +0000 On Saturday 05 March 2005 20:50, David Faure wrote: > ------- You are receiving this mail because: ------- > You are on the CC list for the bug, or are watching someone who is. > > http://bugs.kde.org/show_bug.cgi?id=100733 > > > > > ------- Additional Comments From faure kde org 2005-03-06 02:50 ------- > > On Saturday 05 March 2005 08:22, Dawit Alemayehu wrote: > > Indeed KCompletionBox needed to be modified ; so here is a couple of > > patches for KCompletionBox and one for Minicli which should forever fix > > this problem... > > Dawit: Thanks for the patches. > I can confirm that they don't work though :/ > > kdesktop: [void KCompletionBox::setActivateOnSelect(bool)] false > That's called fine, but the rest of the new code isn't hit, when I click on > an item in the popup. The obvious question: did you do make install in kdelibs/kdeui ? It works fine for me. I am trapping the mouse click events if the emitSelected flag is set to false in KCompletionBox... 321474 14 mmodem00 2005-03-06 05:34:54 +0000 i still didnt applyed the patches. Arent this going to be uploaded to cvs? If so theres no need to put the patches in spec file, just update the source code, now i would like to when uploaded in cvs? 321531 15 faure 2005-03-06 14:35:28 +0000 On Sunday 06 March 2005 03:26, Dawit Alemayehu wrote: > The obvious question: did you do make install in kdelibs/kdeui ? How would I see the call to KCompletionBox::setActivateOnSelect(bool) if I hadn't? :) > It works fine for me. I am trapping the mouse click events if the emitSelected flag is set > to false in KCompletionBox... Ah, I see. There are two cases. 1) When I type something, completion box opens, I click an item -> indeed it works, minicli isn't closed. 2) But if I directly open the combo with the mouse, and then click on an item => minicli is closed. I believe this case should also let me edit the string I clicked on, no? I can confirm that your patch fixes 1) in any case - thanks for that. 321556 16 adawit 2005-03-06 16:54:37 +0000 CVS commit by adawit: - Do not execute when selecting an item from either the text completion box or the combobox's dropdown list box. Needs update of kdelibs/kdeui to work. BUG:100733 M +6 -2 minicli.cpp 1.191 --- kdebase/kdesktop/minicli.cpp #1.190:1.191 @@ -64,4 +64,5 @@ #include <kmimetype.h> #include <kurifilter.h> +#include <kcompletionbox.h> #include "minicli.moc" @@ -130,6 +131,4 @@ Minicli::Minicli( QWidget *parent, const connect( m_dlg->cbCommand, SIGNAL( textChanged( const QString& ) ), SLOT( slotCmdChanged(const QString&) ) ); - connect( m_dlg->cbCommand, SIGNAL( activated( const QString& ) ), - m_dlg->pbRun, SLOT( animateClick() ) ); // Advanced group box... @@ -213,4 +212,8 @@ void Minicli::loadConfig() m_dlg->cbCommand->setCompletionMode( (KGlobalSettings::Completion) mode ); + KCompletionBox* box = m_dlg->cbCommand->completionBox(); + if (box) + box->setActivateOnSelect( false ); + m_finalFilters = KURIFilter::self()->pluginNames(); m_finalFilters.remove("kuriikwsfilter"); 322488 17 mmodem00 2005-03-09 14:24:07 +0000 with this change, when building kdebase i get this error: In file included from libkdeinit_kdesktop_la.all_cpp.cpp:2: minicli.cpp: In member function `void Minicli::loadConfig()': minicli.cpp:219: error: 'class KCompletionBox' has no member named 'setActivateOnSelect' make[3]: ** [libkdeinit_kdesktop_la.all_cpp.lo] Erro 1 make[3]: Leaving directory So its impossible to build kdebase. -- Zé Linux user #378762 322672 18 adawit 2005-03-10 02:44:11 +0000 On Wednesday 09 March 2005 08:24, mmodem00@netvisao.pt wrote: [bugs.kde.org quoted mail] Update kdelibs/kdeui.... 322690 19 mmodem00 2005-03-10 03:42:26 +0000 eheehehhe, i compiled kdelibs, but i did forgot to install it, and i was already compiling new kdebase :) 692298 20 finex 2009-01-02 20:30:28 +0000 Bug closed. Kdesktop is no more mantained. 9963 2005-03-04 09:01:05 +0000 2005-03-04 09:01:05 +0000 kcompletionbox.diff kcompletionbox.diff text/x-diff 792 adawit SW5kZXg6IGtjb21wbGV0aW9uYm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9rZGUv a2RlbGlicy9rZGV1aS9rY29tcGxldGlvbmJveC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu ODMKZGlmZiAtdSAtcCAtYiAtQiAtcjEuODMga2NvbXBsZXRpb25ib3guY3BwCi0tLSBrY29tcGxl dGlvbmJveC5jcHAJOCBKYW4gMjAwNSAxNjoyMDo0NCAtMDAwMAkxLjgzCisrKyBrY29tcGxldGlv bmJveC5jcHAJNCBNYXIgMjAwNSAwNzo1NzozMiAtMDAwMApAQCAtMjM0LDYgKzIzMSwxNCBAQCBi b29sIEtDb21wbGV0aW9uQm94OjpldmVudEZpbHRlciggUU9iamVjCiAgICAgICAgIFFNb3VzZUV2 ZW50ICpldiA9IHN0YXRpY19jYXN0PFFNb3VzZUV2ZW50ICo+KCBlICk7CiAgICAgICAgIGlmICgg IXJlY3QoKS5jb250YWlucyggZXYtPnBvcygpICkpIC8vIHRoaXMgd2lkZ2V0CiAgICAgICAgICAg ICBoaWRlKCk7CisKKyAgICAgICAgaWYgKCBldi0+c3RhdGUoKSAmIFNoaWZ0QnV0dG9uICkKKyAg ICAgICAgeworICAgICAgICAgIGVtaXQgaGlnaGxpZ2h0ZWQoIGN1cnJlbnRUZXh0KCkgKTsKKyAg ICAgICAgICBoaWRlKCk7CisgICAgICAgICAgZXYtPmFjY2VwdCgpOyAgLy8gQ29uc3VtZSB0aGUg bW91c2UgY2xpY2sgZXZlbnQuLi4KKyAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQog ICAgIH0KIAogICAgIHJldHVybiBLTGlzdEJveDo6ZXZlbnRGaWx0ZXIoIG8sIGUgKTsK 9976 2005-03-05 08:22:42 +0000 2005-03-05 08:22:42 +0000 kcompletionbox.diff kcompletionbox.diff text/x-diff 3815 adawit SW5kZXg6IGtjb21wbGV0aW9uYm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9rZGUv a2RlbGlicy9rZGV1aS9rY29tcGxldGlvbmJveC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu ODMKZGlmZiAtdSAtcCAtYiAtQiAtcjEuODMga2NvbXBsZXRpb25ib3guY3BwCi0tLSBrY29tcGxl dGlvbmJveC5jcHAJOCBKYW4gMjAwNSAxNjoyMDo0NCAtMDAwMAkxLjgzCisrKyBrY29tcGxldGlv bmJveC5jcHAJNSBNYXIgMjAwNSAwNzoxODoyOCAtMDAwMApAQCAtMiw3ICsyLDcgQEAKIAogICAg Q29weXJpZ2h0IChjKSAyMDAwLDIwMDEsMjAwMiBDYXJzdGVuIFBmZWlmZmVyIDxwZmVpZmZlckBr ZGUub3JnPgogICAgQ29weXJpZ2h0IChjKSAyMDAwIFN0ZWZhbiBTY2hpbWFuc2tpIDwxU3RlaW5A Z214LmRlPgotICAgQ29weXJpZ2h0IChjKSAyMDAwLDIwMDEgRGF3aXQgQWxlbWF5ZWh1IDxhZGF3 aXRAa2RlLm9yZz4KKyAgIENvcHlyaWdodCAoYykgMjAwMCwyMDAxLDIwMDIsMjAwMywyMDA0IERh d2l0IEFsZW1heWVodSA8YWRhd2l0QGtkZS5vcmc+CiAKICAgIFRoaXMgbGlicmFyeSBpcyBmcmVl IHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAgIG1vZGlmeSBpdCB1 bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC00MSw2 ICs0MSw3IEBAIHB1YmxpYzoKICAgICBib29sIHRhYkhhbmRsaW5nOwogICAgIGJvb2wgZG93bl93 b3JrYXJvdW5kOwogICAgIGJvb2wgdXB3YXJkQm94OworICAgIGJvb2wgZW1pdFNlbGVjdGVkOwog fTsKIAogS0NvbXBsZXRpb25Cb3g6OktDb21wbGV0aW9uQm94KCBRV2lkZ2V0ICpwYXJlbnQsIGNv bnN0IGNoYXIgKm5hbWUgKQpAQCAtNTEsNiArNTIsNyBAQCBLQ29tcGxldGlvbkJveDo6S0NvbXBs ZXRpb25Cb3goIFFXaWRnZXQgCiAgICAgZC0+dGFiSGFuZGxpbmcgICAgID0gdHJ1ZTsKICAgICBk LT5kb3duX3dvcmthcm91bmQgPSBmYWxzZTsKICAgICBkLT51cHdhcmRCb3ggICAgICAgPSBmYWxz ZTsKKyAgICBkLT5lbWl0U2VsZWN0ZWQgICAgPSB0cnVlOwogCiAgICAgc2V0Q29sdW1uTW9kZSgg MSApOwogICAgIHNldExpbmVXaWR0aCggMSApOwpAQCAtMjM0LDYgKzIzMywxNCBAQCBib29sIEtD b21wbGV0aW9uQm94OjpldmVudEZpbHRlciggUU9iamVjCiAgICAgICAgIFFNb3VzZUV2ZW50ICpl diA9IHN0YXRpY19jYXN0PFFNb3VzZUV2ZW50ICo+KCBlICk7CiAgICAgICAgIGlmICggIXJlY3Qo KS5jb250YWlucyggZXYtPnBvcygpICkpIC8vIHRoaXMgd2lkZ2V0CiAgICAgICAgICAgICBoaWRl KCk7CisKKyAgICAgICAgaWYgKCAhZC0+ZW1pdFNlbGVjdGVkICkKKyAgICAgICAgeworICAgICAg ICAgIGVtaXQgaGlnaGxpZ2h0ZWQoIGN1cnJlbnRUZXh0KCkgKTsKKyAgICAgICAgICBoaWRlKCk7 CisgICAgICAgICAgZXYtPmFjY2VwdCgpOyAgLy8gQ29uc3VtZSB0aGUgbW91c2UgY2xpY2sgZXZl bnQuLi4KKyAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIHJl dHVybiBLTGlzdEJveDo6ZXZlbnRGaWx0ZXIoIG8sIGUgKTsKQEAgLTUzOSw2ICs1NDYsMTYgQEAg dm9pZCBLQ29tcGxldGlvbkJveDo6c2xvdEl0ZW1DbGlja2VkKCBRTAogICAgIH0KIH0KIAordm9p ZCBLQ29tcGxldGlvbkJveDo6c2V0QWN0aXZhdGVPblNlbGVjdChib29sIHN0YXRlKQoreworICAg IGQtPmVtaXRTZWxlY3RlZCA9IHN0YXRlOworfQorCitib29sIEtDb21wbGV0aW9uQm94OjphY3Rp dmF0ZU9uU2VsZWN0KCkgY29uc3QKK3sKKyAgICByZXR1cm4gZC0+ZW1pdFNlbGVjdGVkOworfQor CiB2b2lkIEtDb21wbGV0aW9uQm94Ojp2aXJ0dWFsX2hvb2soIGludCBpZCwgdm9pZCogZGF0YSAp CiB7IEtMaXN0Qm94Ojp2aXJ0dWFsX2hvb2soIGlkLCBkYXRhICk7IH0KIApJbmRleDoga2NvbXBs ZXRpb25ib3guaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9rZGUva2RlbGlicy9rZGV1aS9r Y29tcGxldGlvbmJveC5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjMxCmRpZmYgLXUgLXAgLWIg LUIgLXIxLjMxIGtjb21wbGV0aW9uYm94LmgKLS0tIGtjb21wbGV0aW9uYm94LmgJMTEgTm92IDIw MDQgMTQ6MzQ6MDYgLTAwMDAJMS4zMQorKysga2NvbXBsZXRpb25ib3guaAk1IE1hciAyMDA1IDA3 OjE4OjI4IC0wMDAwCkBAIC0yLDYgKzIsNyBAQAogCiAgICBDb3B5cmlnaHQgKGMpIDIwMDAgQ2Fy c3RlbiBQZmVpZmZlciA8cGZlaWZmZXJAa2RlLm9yZz4KICAgICAgICAgICAgICAgICAgMjAwMCBT dGVmYW4gU2NoaW1hbnNraSA8MVN0ZWluQGdteC5kZT4KKyAgICAgICAgICAgICAgICAgMjAwMCwy MDAxLDIwMDIsMjAwMywyMDA0IERhd2l0IEFsZW1heWVodSA8YWRhd2l0QGtkZS5vcmc+CiAKICAg IFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IKICAgIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdl bmVyYWwgUHVibGljCkBAIC00NCw2ICs0NSw3IEBAIGNsYXNzIEtERVVJX0VYUE9SVCBLQ29tcGxl dGlvbkJveCA6IHB1YmwKICAgICBRX09CSkVDVAogICAgIFFfUFJPUEVSVFkoIGJvb2wgaXNUYWJI YW5kbGluZyBSRUFEIGlzVGFiSGFuZGxpbmcgV1JJVEUgc2V0VGFiSGFuZGxpbmcgKQogICAgIFFf UFJPUEVSVFkoUVN0cmluZyBjYW5jZWxsZWRUZXh0IFJFQUQgY2FuY2VsbGVkVGV4dCBXUklURSBz ZXRDYW5jZWxsZWRUZXh0KQorICAgIFFfUFJPUEVSVFkoIGJvb2wgYWN0aXZhdGVPblNlbGVjdCBS RUFEIGFjdGl2YXRlT25TZWxlY3QgV1JJVEUgc2V0QWN0aXZhdGVPblNlbGVjdCApCiAKIHB1Ymxp YzoKICAgICAvKioKQEAgLTYxLDYgKzYzLDEzIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgUVNp emUgc2l6ZUhpbnQoKSBjb25zdDsKIAorICAgIC8qKgorICAgICAqIEByZXR1cm5zIHRydWUgaWYg c2VsZWN0aW5nIGFuIGl0ZW0gcmVzdWx0cyBpbiB0aGUgZW1pdGlvbiBvZiB0aGUgQHJlZiBzZWxl Y3RlZCBzaWduYWwuCisgICAgICoKKyAgICAgKiBAc2luY2UgMy40LjEKKyAgICAgKi8KKyAgICBi b29sIGFjdGl2YXRlT25TZWxlY3QoKSBjb25zdDsKKwogcHVibGljIHNsb3RzOgogICAgIC8qKgog ICAgICAqIFJldHVybnMgYSBsaXN0IG9mIGFsbCBpdGVtcyBjdXJyZW50bHkgaW4gdGhlIGJveC4K QEAgLTEzMSw2ICsxNDAsMTYgQEAgcHVibGljIHNsb3RzOgogICAgIFFTdHJpbmcgY2FuY2VsbGVk VGV4dCgpIGNvbnN0OwogCiAgICAgLyoqCisgICAgICogU2V0IHdoZXRoZXIgb3Igbm90IHRoZSBz ZWxlY3RlZCBzaWduYWwgc2hvdWxkIGJlIGVtaXR0ZWQgd2hlbiBhbgorICAgICAqIGl0ZW0gaXMg c2VsZWN0ZWQuIEJ5IGRlZmF1bHQgdGhlIEByZWYgc2VsZXZ0ZWQgc2lnbmFsIGlzIGVtaXR0ZWQu CisgICAgICoKKyAgICAgKiBAcGFyYW0gc3RhdGUgZmFsc2UgaWYgdGhlIHNpZ25hbCBzaG91bGQg bm90IGJlIGVtaXR0ZWQuCisgICAgICogQHNpbmNlIDMuNC4xCisgICAgICovCisgICAgdm9pZCBz ZXRBY3RpdmF0ZU9uU2VsZWN0KGJvb2wgc3RhdGUpOworCisKKyAgICAvKioKICAgICAgKiBNb3Zl cyB0aGUgc2VsZWN0aW9uIG9uZSBsaW5lIGRvd24gb3Igc2VsZWN0IHRoZSBmaXJzdCBpdGVtIGlm IG5vdGhpbmcgaXMgc2VsZWN0ZWQgeWV0LgogICAgICAqLwogICAgIHZvaWQgZG93bigpOwo= 9977 2005-03-05 08:22:42 +0000 2005-03-05 08:22:42 +0000 minicli.diff minicli.diff text/x-diff 858 adawit SW5kZXg6IG1pbmljbGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL2tkZS9rZGViYXNl L2tkZXNrdG9wL21pbmljbGkuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE5MApkaWZmIC11 IC1wIC1iIC1CIC1yMS4xOTAgbWluaWNsaS5jcHAKLS0tIG1pbmljbGkuY3BwCTI3IERlYyAyMDA0 IDE3OjUzOjU3IC0wMDAwCTEuMTkwCisrKyBtaW5pY2xpLmNwcAk1IE1hciAyMDA1IDA3OjE4OjUw IC0wMDAwCkBAIC02Myw2ICs2Myw3IEBACiAjaW5jbHVkZSA8a3N0ZGd1aWl0ZW0uaD4KICNpbmNs dWRlIDxrbWltZXR5cGUuaD4KICNpbmNsdWRlIDxrdXJpZmlsdGVyLmg+CisjaW5jbHVkZSA8a2Nv bXBsZXRpb25ib3guaD4KIAogI2luY2x1ZGUgIm1pbmljbGkubW9jIgogI2luY2x1ZGUgIm1pbmlj bGlfdWkuaCIKQEAgLTIxMiw2ICsyMTMsMTAgQEAgdm9pZCBNaW5pY2xpOjpsb2FkQ29uZmlnKCkK ICAgaW50IG1vZGUgPSBLRGVza3RvcFNldHRpbmdzOjpjb21wbGV0aW9uTW9kZSgpOwogICBtX2Rs Zy0+Y2JDb21tYW5kLT5zZXRDb21wbGV0aW9uTW9kZSggKEtHbG9iYWxTZXR0aW5nczo6Q29tcGxl dGlvbikgbW9kZSApOwogCisgIEtDb21wbGV0aW9uQm94KiBib3ggPSBtX2RsZy0+Y2JDb21tYW5k LT5jb21wbGV0aW9uQm94KCk7CisgIGlmIChib3gpCisgICAgYm94LT5zZXRBY3RpdmF0ZU9uU2Vs ZWN0KCBmYWxzZSApOworCiAgIG1fZmluYWxGaWx0ZXJzID0gS1VSSUZpbHRlcjo6c2VsZigpLT5w bHVnaW5OYW1lcygpOwogICBtX2ZpbmFsRmlsdGVycy5yZW1vdmUoImt1cmlpa3dzZmlsdGVyIik7 CiAK