Bug 148951 - Add Gentoo support for dial-up Dialog
Summary: Add Gentoo support for dial-up Dialog
Status: RESOLVED FIXED
Alias: None
Product: knetworkmanager
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist (vote)
Target Milestone: ---
Assignee: Will Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-18 03:54 UTC by Robert Buchholz
Modified: 2008-06-15 11:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
knetworkmanager-0.2-kppp.patch (1.29 KB, patch)
2007-08-18 03:55 UTC, Robert Buchholz 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Buchholz 2007-08-18 03:54:50 UTC 
Version:           0.2 (using KDE KDE 3.5.7)
Installed from:    Gentoo Packages
OS:                Linux

Please review the attached patch and commit to trunk.
Thanks!
Comment 1 Robert Buchholz 2007-08-18 03:55:25 UTC 
Created attachment 21426 [details]
knetworkmanager-0.2-kppp.patch
Comment 2 Pino Toscano 2007-08-18 11:35:16 UTC 
Since when KPPP is a Gentoo-specific tool?
Comment 3 Robert Buchholz 2007-08-18 12:02:17 UTC 
It is not. The default location of it however is.
Comment 4 Pino Toscano 2007-08-18 12:08:20 UTC 
You misunderstood my point - if you call the generic (and shipped with the KDE module kdenetwork) KPPP, is there much sense in checking which distro are you using?
Comment 5 Robert Buchholz 2007-08-18 13:38:47 UTC 
You are right there isn't much point because KPPP is not distribution-specific. But right now the dial-up selection has no unspecific default, which results in this: If KNETWORKMANAGER_DIALUP_CONFIG is not defined, there's no "Configure Dial-up Connections" button. So it needs to be defined to the executable.

This could also be changed to check for the existence of KPPP and default to that location if no --with-distro is given.

Please also check bug #140703 for a similar issue related to Fedora.
Comment 6 Will Stephenson 2008-06-15 11:02:40 UTC 
Patch was integrated in r705116