Bug 96211 - missing xml tag in the opml generated file
Summary: missing xml tag in the opml generated file
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: 1.0-beta8
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-03 12:31 UTC by Carlo Perassi
Modified: 2005-01-07 18:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlo Perassi 2005-01-03 12:31:00 UTC
Version:           1.0-beta8 (using KDE 3.3.2,  (3.1))
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-4)
OS:                Linux (i686) release 2.6.10

Referring to the "Examples" section of http://www.opml.org/spec, the first line of an opml file should be like
<?xml version="1.0" encoding="ISO-8859-1"?>
or
<?xml version='1.0' standalone='yes'?>
An "xml" line is missing.

(By the way, IMHO should be possible to "File, Import Feeds" from the net, not only from the local file system.)
Comment 1 Stanislav Karchebny 2005-01-04 15:07:48 UTC
I have a fix for <?xml ... in my CVS. Once the HEAD is unfrozen I'll commit.

And iirc, you can of course import opml from anywhere KIO can reach, including the net.
Comment 2 Stanislav Karchebny 2005-01-07 18:59:31 UTC
CVS commit by karchebny: 

* Add <?xml pi to feeds opml according to OPML spec at opml.org/spec
BUG: 96211


  M +3 -0      feedlist.cpp   1.7


--- kdepim/akregator/src/feedlist.cpp  #1.6:1.7
@@ -162,4 +162,7 @@ QDomDocument FeedList::toOPML() const
 {
     QDomDocument doc;
+    QDomProcessingInstruction pi = doc.createProcessingInstruction( "xml", "version=\"1.0\" encoding=\"UTF-8\"" );
+    doc.appendChild( pi );
+
     QDomElement root = doc.createElement( "opml" );
     root.setAttribute( "version", "1.0" );