Bug 90915 - konqueror calls kwallet too early
Summary: konqueror calls kwallet too early
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-07 18:07 UTC by Douglas J Hunley
Modified: 2004-11-09 13:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas J Hunley 2004-10-07 18:07:33 UTC
Version:            (using KDE KDE 3.3.0)
Installed from:    Compiled From Sources
Compiler:          gcc version 3.4.2
 
OS:                Linux

When visiting a website that requires I log in, after typing my credentials and hitting submit, I am immediately presented with the password prompt for my kwallet and then after that I'm given the choice of saving the credentials into the wallet or not.
Believe it or not, there are times where I don't want it stored. It makes more sense to ask the user 'do you want kwallet to store this info' first, and then if they say yes, open the kwallet (prompting for the password). The current behaviour is backwards
Comment 1 Douglas J Hunley 2004-10-07 18:09:12 UTC
hrm .. I didn't enter 'akregator' in any of the screens when submitting this bug .. I entered 'konqueror' and then chose 'plugins' .. I don't know what's up w/ that .. sorry
Comment 2 Teemu Rytilahti 2004-10-07 23:04:39 UTC
aww, forgot to change the product... (btw, I can't change the component in the same time I change the product, should this be possible?)
Comment 3 Nilesh Bansal 2004-10-08 16:08:06 UTC
Yes I support this, but this might be difficult as without opening the wallet how can you know what login/passwords are already saved there. 
Comment 4 George Staikos 2004-10-08 16:13:28 UTC
On Friday 08 October 2004 10:08, nilesh wrote:
> ------- Yes I support this, but this might be difficult as without opening
> the wallet how can you know what login/passwords are already saved there.

  You can easily know this.  There are hashes stored, and if you get a hit on 
the hash of your key, then you know there is a good chance it's there.

Comment 5 George Staikos 2004-11-05 13:22:41 UTC
CVS commit by staikos: 

So far it works well so I'm committing this rather complicated fix set.
Details:
1) Save to KWallet asynchronously from KHTML whenever saving a -new- entry.
2) When possibly saving a new entry, prompt the user if he wants to save before
   opening the wallet.
3) Fix several bugs in transaction handling and asynchronous handling in
   kwalletd.
4) KWalletClient ignores handles of 0.
5) KWalletD never returns handles of 0 except in case of "please wait" during
   asynchronous opens.  This may affect anyone using kwalletd directly via
   DCOP with openAsynchronous.  It fixes a big bug though.
6) Fix some cases where opening failed improperly.
7) Fix some minor issues with my last KHTML fixes.
CCBUG: 68684, 70789, 90915

One item left to fix in KHTML: dealing with possibly changing an existing
entry when the wallet isn't open yet.

All of these fixes should be backported together (basically all of kwalletd,
kwalletclient, and khtml changes).


  M +34 -27    khtml/khtml_part.cpp   1.1043
  M +3 -0      khtml/khtmlpart_p.h   1.59
  M +24 -25    khtml/html/html_formimpl.cpp   1.400
  M +161 -107  kio/misc/kwalletd/kwalletd.cpp   1.72
  M +1 -1      kio/misc/kwalletd/kwalletd.h   1.36
  M +3 -3      kwallet/client/kwallet.cc   1.45



Comment 6 Jens 2004-11-09 09:18:12 UTC
Thank you!
This fixes one of the minor annoyances that Konqueror had for me!

Can't wait for it to appear in KDE 3.3.x (if it will) :)

Jens
Comment 7 George Staikos 2004-11-09 13:14:47 UTC
CVS commit by staikos: 

Commit my patch as posted to kfm-devel, plus more:

1) KHTMLPart::wallet() is undeprecated, I just modified its behaviour slightly
  and since it's relatively unused, this should be fine.  It now returns NULL
  a little more often than previously, but it's 100% async.
2) KHTML is 100% KWallet asynchronous now.
3) Fixed a bug where KHTML wouldn't save form data in some circumstances.
4) KHTML now prompts to save before prompting for the wallet password if there
  is an existing comparable match in the wallet but the wallet is not open.
  (rare case that it is not open, but in any case it needs to be done for
   multiple completion support)

I believe this covers most of the important wallet issues now.

BUG: 70789, 90915


  M +1 -20     khtml_part.cpp   1.1049
  M +1 -1      khtml_part.h   1.268
  M +52 -40    html/html_formimpl.cpp   1.408
  M +2 -1      html/html_formimpl.h   1.160