Created attachment 7639 [details]
small fix for crashes after quit.

Every time I try to quit using the TrayIcon aKregator crashes.

I've also experienced regular crashes after using the TrayIcon to quit.

If this is the same problem, I've proposed a small patch.

CVS commit by rytilahti: 

Shutdown properly and crash no more, hopefully fixes #89172 too.
CCMAIL: 90671-done@bugs.kde.org
CCMAIL: 89172@bugs.kde.org


  M +3 -0      ChangeLog   1.66
  M +10 -10    src/akregator.cpp   1.65
  M +2 -1      src/akregator.h   1.26


--- kdenonbeta/akregator/src/akregator.cpp  #1.64:1.65
@@ -242,5 +242,5 @@ void aKregator::fileNew()
         w->loadPart();
         w->show();
-    };
+        }
 }
 
@@ -312,6 +311,5 @@ void aKregator::applyNewToolbarConfig()
 void aKregator::fileOpen()
 {
-    KURL url =
-        KFileDialog::getOpenURL( QString::null, QString::null, this );
+    KURL url = KFileDialog::getOpenURL( QString::null, QString::null, this );
 
     if (url.isEmpty() == false)
@@ -357,6 +355,6 @@ bool aKregator::queryExit()
         emit markAllFeedsRead();
 
+    static_cast<Akregator::aKregatorPart*>(m_part)->saveSettings();
 
-    Settings::writeConfig();
     return KParts::MainWindow::queryExit();
 }
@@ -406,14 +404,16 @@ bool aKregator::queryClose()
         KMessageBox::information(this, i18n( "<qt>Closing the main window will keep aKregator running in the system tray. Use 'Quit' from the 'File' menu to quit the application.<p><p><center><img source=\"systray_shot\"></center></p></qt>" ), i18n( "Docking in System Tray" ), "hideOnCloseInfo");
         hide();
-    }
     return false;
-
+    }
 }
 void aKregator::quitProgram()
 {
-     static_cast<Akregator::aKregatorPart*>(m_part)->saveSettings();
      m_quit = true;
-     close();
-     m_quit = false;
+     kapp->quit();
+     // what's this mess in here and is it needed for some reason? this change anyways fixes #90671 -tpr
+     //m_quit = true;
+     //close();
+     //m_quit = false;
+     //static_cast<Akregator::aKregatorPart*>(m_part)->saveSettings();
 }
 

--- kdenonbeta/akregator/src/akregator.h  #1.25:1.26
@@ -66,4 +66,5 @@ public:
     bool loadPart();
 
+    /** Loads standard feed file */
     void loadStandardFile();
 

--- kdenonbeta/akregator/ChangeLog  #1.65:1.66
@@ -16,4 +16,7 @@
        - added "Export Feeds" function to export the standard feed list -fo
        - Expiry support added -fo 
+      
+Bug fixes:
+#90671 - Shutdown properly hopefully fixes #89172 too -tpr
          
 Changes after 1.0b5:

Clean according to valgrind.