Bug 84314 - please add print command
Summary: please add print command
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: LO wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-01 15:39 UTC by Marco Montagnana
Modified: 2004-11-23 16:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Montagnana 2004-07-01 15:39:15 UTC
Version:           1.0-beta4 "PhantomsRSS" (using KDE 3.2.3, SuSE)
Compiler:          gcc version 3.3.1 (SuSE Linux)
OS:                Linux (i686) release 2.4.21-226-default

Hello.

I find it'd be useful sometimes to print a feed, especially in combined view. It should be easy to add a Print command, I guess... ;-)

Thanks for the great job. I find akregator to be "the" killer application under KDE since kmail. If only the kontact plugin worked... but I know you're working on this. :-)
Comment 1 Sashmit Bhaduri 2004-07-01 16:20:26 UTC
will do after a few betas.. we are freezing features for a beta or two in order to get a semibalance of stability.
Comment 2 Frank Osterfeld 2004-11-23 16:12:19 UTC
CVS commit by osterfeld: 

added print command for article viewer
BUG: 84314


  M +3 -2      ChangeLog   1.79
  M +1 -0      src/akregator_part.cpp   1.104
  M +4 -1      src/akregator_part.rc   1.29
  M +5 -0      src/akregator_view.cpp   1.158
  M +2 -0      src/akregator_view.h   1.68
  M +0 -6      src/pageviewer.cpp   1.14
  M +0 -2      src/pageviewer.h   1.10
  M +7 -0      src/viewer.cpp   1.25
  M +1 -0      src/viewer.h   1.15


--- kdenonbeta/akregator/ChangeLog  #1.78:1.79
@@ -9,8 +9,9 @@
        - Add icon to konqueror to show if page has a feed -tpr
 #85532 - Add feed summary -tpr
+#84314 - added print command for article viewer -fo 
+#92330 - Added possibility to set article status (read/unread/new) manually -fo
+       - Added basic "keep flag" support to prevent articles from expiring -fo
 
 Changes:
-       - Added possibility to set article status (read/unread/new) manually -fo
-       - Added basic "keep flag" support to prevent articles from expiring -fo
        - Add pageviewer actions into Go menu and print to file menu when in pageviewer mode -tpr
        - improve tabbed browsing: added back/forward buttons, improved context menus - fo

--- kdenonbeta/akregator/src/akregator_part.cpp  #1.103:1.104
@@ -65,4 +65,5 @@ void aKregatorPart::setupActions()
     new KAction(i18n("&Import Feeds..."), "", "", this, SLOT(fileImport()), actionCollection(), "file_import");
     new KAction(i18n("&Export Feeds..."), "", "", this, SLOT(fileExport()), actionCollection(), "file_export");
+    KStdAction::print(m_view, SLOT(slotPrint()), actionCollection(), "file_print");
 
     /* --- Feed/Feed Group popup menu */

--- kdenonbeta/akregator/src/akregator_part.rc  #1.28:1.29
@@ -1,4 +1,4 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui name="akregator_part" version="31">
+<kpartgui name="akregator_part" version="35">
 <MenuBar>
   <Menu name="file">
@@ -6,4 +6,6 @@
     <Action name="file_export"/>
     <Separator/> 
+    <Action name="file_print"/>
+    <Separator/> 
   </Menu>
 
@@ -62,4 +64,5 @@
   <Action name="feed_fetch_all"/>
   <Action name="feed_stop"/>
+  <Action name="file_print"/>
   <DefineGroup name="pageviewer_operations" />
   <Merge/>

--- kdenonbeta/akregator/src/akregator_view.cpp  #1.157:1.158
@@ -1343,4 +1343,9 @@ void aKregatorView::slotOpenCurrentArtic
 }
 
+void aKregatorView::slotPrint()
+{
+    m_articleViewer->slotPrint();
+}
+
 void aKregatorView::slotFeedURLDropped(KURL::List &urls, TreeNodeItem* after, FeedGroupItem* parent)
 {

--- kdenonbeta/akregator/src/akregator_view.h  #1.67:1.68
@@ -162,4 +162,6 @@ namespace Akregator
             void slotOpenCurrentArticleForegroundTab();
 
+            /** prints the content of the article viewer */
+            void slotPrint();
             /**
              * This slot is called when user renames a feed in feeds tree.

--- kdenonbeta/akregator/src/pageviewer.cpp  #1.13:1.14
@@ -252,10 +252,4 @@ void PageViewer::slotCancelled( const QS
 }
 
-// some code taken from KDevelop (lib/widgets/kdevhtmlpart.cpp)
-void PageViewer::slotPrint( )
-{
-    view()->print();
-}
-
 void PageViewer::slotPopupMenu(KXMLGUIClient*, const QPoint& p, const KURL& kurl, const KParts::URLArgs&, KParts::BrowserExtension::PopupFlags, mode_t)
 {

--- kdenonbeta/akregator/src/pageviewer.h  #1.9:1.10
@@ -51,6 +51,4 @@ namespace Akregator
             void slotReload();
             void slotStop();
-            void slotPrint();
-
 
         protected:

--- kdenonbeta/akregator/src/viewer.cpp  #1.24:1.25
@@ -134,4 +134,5 @@ void Viewer::slotPopupMenu(KXMLGUIClient
    else
    {
+       popup.insertItem(SmallIcon("fileprint"), i18n("Print..."), this, SLOT(slotPrint()));
         KAction *ac = action("setEncoding");
         if (ac)
@@ -188,4 +189,10 @@ void Viewer::slotScrollDown()
 }
 
+// some code taken from KDevelop (lib/widgets/kdevhtmlpart.cpp)
+void Viewer::slotPrint( )
+{
+    view()->print();
+}
+
 #include "viewer.moc"
 

--- kdenonbeta/akregator/src/viewer.h  #1.14:1.15
@@ -36,4 +36,5 @@ namespace Akregator
             void slotScrollUp(); 
             void slotScrollDown();
+            void slotPrint();
         
         signals: