Bug 82660 - Option per channel to load the webpage directly
Summary: Option per channel to load the webpage directly
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 85531 92512 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-06-01 21:07 UTC by Stian Haklev
Modified: 2007-01-10 21:30 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stian Haklev 2004-06-01 21:07:34 UTC
Version:           1.0beta2 (using KDE KDE 3.2.3)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Just got the latest beta2, and it looks good. Haven't tested if you fixed the unicode bit yet. Still waiting for nice stuff like a date field and reverse sorting (I think most people would prefer this). 

Anyhow, another request, maybe a bit strange - make it an option, on a channel basis, to instead of loading the page a posting refers to directly when selecting a headline, instead of showing the rss info. This is the default behaviour of the forumzilla plugin to Thunderbird that I used before, and it's very nice for some sites that literally only provide a few words of introduction, and force you to go to the website to read the whole thing. And also I subscribe to a channel where every listing contains a url of a new and interesting page, which this would be good for.

(Let me know if you need more info about how it should be implemented. And PS: Could you make ctrl+click open a link in the background also? middle-click not practical on a laptop touchpad.)

Stian
Comment 1 Stanislav Karchebny 2004-06-29 18:14:40 UTC
Could you please explain that in more detail? I feel dumb today.
Comment 2 MaxAuthority 2004-06-29 19:09:11 UTC
I think he meant (at least that's what I mean, and why I gave 5 votes for it), that most rss feeds only show a one-line (it at all) description of the content of the article, and you have to click "full story" in the kthml-view on the bottom right.

Therefore you should be able to say (on a per-channel basis), that the article should be automatically loaded in the khml-frame at the bottom right instead of the useless header and the "full story" link.
This would save you from the need to click "full story" to open the article in a new tab (or to middleclick the story in the article browser).

Hopefully it's clear now, I am not a native English-speaker either.
Otherwise please ask again, but this is a very simple but powerfull feature. You also wouldn't want to click "full story" in your e-mail client either.
Comment 3 Stanislav Karchebny 2004-06-30 23:03:54 UTC
Okay understood.
Comment 4 Teemu Rytilahti 2004-07-24 02:57:09 UTC
*** Bug 85531 has been marked as a duplicate of this bug. ***
Comment 5 Teemu Rytilahti 2004-07-24 05:32:49 UTC
I implemented this tonight to open a new tab when you press the item, but I don't think that's good idea. And I don't think we should display html pages in the articleviewer's small box, so that's not a choice.

I prefer using middle mouse button press on the item to open it in background tab or anything you want, but please elaborate more how this could be made usable. For me this looks like a mess, when you can't know does clicking the item open a tab or to display the content of the feed in the "small box".

But please, give me some comments about this..

PS. Developers, please don't reassign bugs to yourself even if you're working on it. But if you reassign, please add akregator-devel@lists.sourceforge.net to the CC list so every developer will be noticed when there's a new comment.
Comment 6 Teemu Rytilahti 2004-08-23 19:59:51 UTC
We've discussed about this on the irc channel and we decided not to implement this because of usability reasons.
Comment 7 Teemu Rytilahti 2004-11-23 21:14:10 UTC
*** Bug 92512 has been marked as a duplicate of this bug. ***
Comment 8 Mircea Bardac 2005-04-27 21:31:22 UTC
I fail to understand why there are usability issues with this. It would just be konqueror on 50% of the screen

'articleviewer's small box'? Where is it small? It is pretty big here on 1024x768.
Other than that, it's just *an option*, so it doesn't hurt. The articleviewer is totally useless for some channels and I'd rather not see the channels at all.

Improvement to this idea:
* use a different stylesheet (as many websites (blogs) provide alternate stylesheets (for printing, as an example)) probably a little bit altered (like hide pictures, change font size etc. - KHTML is versatile, as we all know it)
Comment 9 Teemu Rytilahti 2005-05-06 16:58:23 UTC
Actually this seems to be nice addition, got it wrong before.. :)
Comment 10 Teemu Rytilahti 2005-05-06 17:00:12 UTC
SVN commit 410054 by rytilahti:

Open the webpage directly to articleviewer if there's no description available. This will be here for testing and if it's found out cool then we could add an option and prolly some cleaning (use media/print stylesheet if available and such)

BUGS:82660


 M  +4 -1      trunk/KDE/kdepim/akregator/src/articleviewer.cpp  


--- trunk/KDE/kdepim/akregator/src/articleviewer.cpp #410053:410054
@@ -404,7 +404,10 @@
     m_viewMode = NormalView;
     disconnectFromNode(m_node);
     m_node = 0;
-    renderContent( formatArticle(article.feed(), article) );
+    if(article.description().isEmpty())
+        openURL(article.link());
+    else
+        renderContent( formatArticle(article.feed(), article) );
 }
 
 void ArticleViewer::slotSetFilter(const ArticleFilter& textFilter, const ArticleFilter& statusFilter)
Comment 11 Sashmit Bhaduri 2005-05-06 19:21:56 UTC
IMHO, this should be an option but not the default behavior.
Comment 12 Mircea Bardac 2005-05-08 12:21:48 UTC
"article.description().isEmpty()" is not enough to mark an article's content usefull. It should be an option since this doesn't cover all the cases when the content is only a bit more than nothing.

Thanks for reconsidering.
Comment 13 Frank Osterfeld 2005-05-12 23:58:30 UTC
SVN commit 412913 by osterfeld:

make "show linked website" configurable per feed and disable it by default
CCBUG: 82660


 M  +1 -1      trunk/KDE/kdepim/akregator/src/articleviewer.cpp  
 M  +15 -0     trunk/KDE/kdepim/akregator/src/feed.cpp  
 M  +5 -0      trunk/KDE/kdepim/akregator/src/feed.h  
 M  +13 -1     trunk/KDE/kdepim/akregator/src/propertiesdialog.cpp  
 M  +2 -0      trunk/KDE/kdepim/akregator/src/propertiesdialog.h  
 M  +26 -18    trunk/KDE/kdepim/akregator/src/propertieswidgetbase.ui