Version: (using KDE KDE 3.2.2) Installed from: SuSE RPMs OS: Linux Let's say I copy 1000 files from one directory to another, i.e. give KDE the task to do so. Now there are 500 files already in that target-directory and KDE asks me what to do. If I chose to skip them this is an additional property of the task I gave in the first place. I expect KDE to fulfill this task at a 100%, no matter if the first task, i.e. to copy, is only done in 50% of the files. This is simply because the additional task I set, i.e. to skip duplicates, adds another 50% to the overall task. However KDE tells me in the progress dialogue that only 50% of the task have been accomplished, which I find to be very confusing.
Confirmed
Created attachment 6246 [details] proposed patch Patch for review.
CVS commit by waba: Take skipped files into account in overall progress of copy job. (BR82493) CCMAIL:82493-done@bugs.kde.org M +3 -0 job.cpp 1.390 --- kdelibs/kio/kio/job.cpp #1.389:1.390 @@ -2801,4 +2801,5 @@ void CopyJob::slotResultCopyingFiles( Jo { skip( (*it).uSource ); + m_fileProcessedSize = (*it).size; files.remove( it ); // Move on to next file } @@ -2827,4 +2828,5 @@ void CopyJob::slotResultCopyingFiles( Jo // Very special case, see a few lines below // We are deleting the source of a symlink we successfully moved... ignore error + m_fileProcessedSize = (*it).size; files.remove( it ); } else { @@ -2989,4 +2991,5 @@ void CopyJob::slotResultConflictCopyingF // Move on to next file skip( (*it).uSource ); + m_processedSize += (*it).size; files.remove( it ); m_processedFiles++;
D/l http://scilabsoft.inria.fr/download/stable/scilab-3.0.bin.linux-i686.tar.gz and click on the archive in konqueror. Drag the directory to some destination, watch the copying dialogue. In the archive, some files are doubled, so konqueror will ask you what to do, tell it to overwrite automatically. Watch the progress-bar, it will not reach 100% but stop at 30% because the progress bar does not count the overwritten files. KDE 3.4, latest SuSE RPMs.
What about this issue on KDE4? Is it still valid?
some news about this?