Bug 76230 - Webpresence-plugin: Invisibility doesn't work
Summary: Webpresence-plugin: Invisibility doesn't work
Status: CONFIRMED
Alias: None
Product: kopete
Classification: Applications
Component: Web Presence Plugin (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-26 23:56 UTC by Bram Schoenmakers
Modified: 2021-03-09 22:41 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bram Schoenmakers 2004-02-26 23:56:45 UTC
Version:            (using KDE KDE 3.2.0)
Installed from:    Compiled From Sources
Compiler:          gcc 3.2 
OS:          Linux

When I'm invisible with MSN, I'm 'AWAY' and ICQ shows me even 'ONLINE' while invisible.
Comment 1 Stefan Gehn 2004-02-28 20:08:01 UTC
for icq that's normal because invisible is an additional flag on top of your normal status.
you can be
away + invisible
online + invisible
occupied + invisible
etc.
The problem with invisible is that if this status is assumed as "offline" then you won't be able to send messages.

Maybe KopeteOnlineStatus should get an Invisible status that is a mixture of offline and away (offline to everbody else but away to kopete internally).
Comment 2 Will Stephenson 2004-06-11 10:58:49 UTC
This will require that libkopete knows about Invisibility to fix, as Stefan says.  It may take a while to fix
Comment 3 Matt Rogers 2004-06-23 04:35:01 UTC
ok, MSN and Y! are shown correctly in the Web presence plugin. However, ICQ will take some more work. :/
Comment 4 Matt Rogers 2004-06-23 05:54:53 UTC
and gadu and jabber work now, but still not ICQ. I'll have to change how invisible is implemented.

(Will: I reassigned to myself since I'm going to have to fix ICQ)
Comment 5 Matt Rogers 2004-06-23 07:51:26 UTC
CVS commit by mattr: 

Add an Invisible status to KopeteOnlineStatus so that MSN, Yahoo, and any
other protocols that support being invisible will show as offline in the
web presence plugins. 

ICQ doesn't work yet, but I might be able to take care of that within the
next few days.

Kopete Developers: I didn't change Jabber or Gadu for this yet. I will get
to it, but feel free to leap frog me if I don't do it in a timely manner :-)

CCMAIL: 76230@bugs.kde.org
CCMAIL: kopete-devel@kde.org


  M +1 -0      kopete/kimifaceimpl.cpp   1.13
  M +3 -1      libkopete/kopeteonlinestatus.cpp   1.32
  M +8 -2      libkopete/kopeteonlinestatus.h   1.24
  M +1 -0      plugins/webpresence/webpresenceplugin.cpp   1.46
  M +1 -1      protocols/msn/msnprotocol.cpp   1.262
  M +1 -1      protocols/yahoo/yahooprotocol.cpp   1.74



Comment 6 Adeodato Simó 2004-06-25 17:31:45 UTC
This commit breaks MSN invisibility in the following way: the auto-away feature continues to do its job even if you are invisible! That is: go invisible, be inactive for 5min (or whatever the time for being marked auto-away is): you are now away, and you have become "visible" without having manually marked yourself as so. That, of course, shoudn't happen.
Comment 7 Matt Rogers 2004-06-25 17:36:33 UTC
Then that would be a bug that with MSN. Please file a seperate bug for that one.
Comment 8 Adeodato Simó 2004-06-25 18:06:03 UTC
Well, you changed this line from ::Away to ::Invisible. The comment states that ::Away is needed. I can't say but that your commit broke the MSN plugin.

HDN( KopeteOnlineStatus::Away,       3, this, 8, "msn_invisible", i18n( "Set &Invisible" ),     i18n( "Invisible" ) ), 
//We use away because we don't want to see this state changed when autoaway.

I'd suggest (from my ignorance, of course) to revert the change in msnprotocol.cpp and coordinate with the MSN plugin maintainer on how to fix this bug. (Perhaps this has already been done and the agreement was on "Fix #76230 and we'll fix the MSN invisibility issue when sbd. complains". If that's the case, I'll happily report the issue in a separate bugreport.)
Comment 9 Matt Rogers 2004-06-25 18:25:03 UTC
Yup, I changed that line. There needs to be a seperate bug filed for the auto-away issue. 
Comment 10 Till Gerken 2004-06-25 18:54:00 UTC
I don't think it's a problem with MSN as the auto-away feature simply requests the protocol to set the away status. The protocol can't distinguish whether this is an automatic thing and invisible shouldn't be changed or if it's a user who tries to go away from his invisible status.
Comment 11 Matt Rogers 2004-06-25 19:17:53 UTC
from what I understand of the way the away feature works, the bug is in MSN because of the way the weights are arranged. /me shrugs. 
Comment 12 Adeodato Simó 2004-06-25 20:17:56 UTC
The Yahoo! plugin is broken in the same way. IMHO it would be good if the issue was resolved globally, I mean, as a result of discussion between all developers affected and not locally in each plugin.

Again from my ignorance, now that ::Invisible exists globally, the auto-away plugin could check if the user is Invisible and do not trigger in that case.

I'll file a bug report later, or some other day, explaining it all.
Comment 13 Till Gerken 2004-06-25 22:46:47 UTC
I bet it's the same with Jabber and I think that the problem needs to be solved in the auto-away plugin.
Comment 14 Adeodato Simó 2004-06-26 01:11:52 UTC
OK, I've reported the bug against the auto-away plugin (bug#84019), I also think that's the right place to fix the issue.

Note that there was a lengthy discussion about it last year, which is stored in bug#62427.
Comment 15 Justin Zobel 2021-03-09 22:41:19 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.