Bug 75230 - OSD is updated when shoutcast/stream information changes
Summary: OSD is updated when shoutcast/stream information changes
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-14 15:45 UTC by Troy Dack
Modified: 2006-06-11 12:32 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Troy Dack 2004-02-14 15:45:55 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

When the track information for a shoutcast (or stream in general) changes have the updated information displayed using the OSD.

This already happens when the track changes whilst playing songs from the playlist.
Comment 1 Mark Kretschmann 2004-02-17 11:04:22 UTC
CVS commit by markey: 

"One bundle to rule them all!" - 
Removed TitleProxy::metaPacket, and made the proxy use a MetaBundle instead. I believe it's nicer to only use one kind of metadata class in the whole app. This also reduced some compile dependencies and made the code leaner.  Please forgive me, there are some slight regressions with the metaData handling, but I guess that can be sorted out.

Also, I've made the OSD show the current stream metadata (fixes BR #75230)

CCMAIL: 75230-done@bugs.kde.org


  M +2 -0      ChangeLog   1.108
  M +6 -3      amarok/Makefile.am   1.54
  M +14 -9     amarok/metabundle.h   1.9
  M +3 -0      amarok/osd.cpp   1.3
  M +6 -1      amarok/osd.h   1.4
  M +11 -9     amarok/playerapp.cpp   1.196
  M +1 -2      amarok/playerapp.h   1.90
  M +7 -40     amarok/playerwidget.cpp   1.116
  M +1 -5      amarok/playerwidget.h   1.46
  M +8 -9      amarok/playlistwidget.cpp   1.111
  M +1 -3      amarok/playlistwidget.h   1.46
  M +2 -0      amarok/engine/artsengine.cpp   1.36
  M +8 -1      amarok/titleproxy/Makefile.am   1.3
  M +16 -12    amarok/titleproxy/titleproxy.cpp   1.18
  M +48 -59    amarok/titleproxy/titleproxy.h   1.13



Comment 2 Stanislav Karchebny 2004-03-24 08:59:21 UTC
Seems to be regressed, doesn't update here again :\
Comment 3 Frederik Holljen 2004-03-24 09:27:16 UTC
Probably due to the changes in OSD handling and the engine observer stuff. I'll look into it.
Comment 4 Frederik Holljen 2004-03-24 11:22:22 UTC
Should work again now.