Bug 73571 - chatwindow style lost on upgrade
Summary: chatwindow style lost on upgrade
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-26 22:45 UTC by Neal Becker
Modified: 2004-02-18 14:44 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Becker 2004-01-26 22:45:17 UTC
Version:           0.8.0 RC1 (using KDE 3.2.0 RC1, compiled sources)
Compiler:          gcc version 3.3.2 20031022 (Red Hat Linux 3.3.2-1)
OS:          Linux (i686) release 2.4.22-1.2149.nptl

Attempting to open any aol chat gives:

An internal Kopete error occurred while parsing a message:
XSL document could not be parsed!
An internal Kopete error occurred while parsing a message:
XSL document could not be parsed!
Comment 1 Neal Becker 2004-01-26 22:46:00 UTC
I should mention, I've been using kopete for some time, and it just mysteriously stopped working.
Comment 2 Jason Keirstead 2004-01-26 23:35:58 UTC
Make sure you have an XSL style chosen. This seems to be a common cause of this bug due to some borked upgrading.
Comment 3 Neal Becker 2004-01-27 03:00:12 UTC
Subject: Re:  kopete xsl parse error

On Monday 26 January 2004 05:36 pm, Jason Keirstead wrote:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
> http://bugs.kde.org/show_bug.cgi?id=73571
>
>
>
>
> ------- Additional Comments From jason@keirstead.org  2004-01-26 23:35
> ------- Make sure you have an XSL style chosen. This seems to be a common
> cause of this bug due to some borked upgrading.

Thanks.  But, I don't know what that means.  Is this a setting in kopete?  Or, 
something to do with desktop style settings?

Comment 4 Richard Smith 2004-01-27 03:21:55 UTC
Subject: Re: [Kopete-devel]  kopete xsl parse error

On Tuesday 27 January 2004 2:00 am, Neal Becker wrote:
> Additional Comments From jason@keirstead.org  2004-01-26 23:35:
> > Make sure you have an XSL style chosen. This seems to be a common
> > cause of this bug due to some borked upgrading.
>
> Thanks.  But, I don't know what that means.  Is this a setting in kopete? 
> Or, something to do with desktop style settings?

It's a Kopete setting. Go to Kopete Configuration -> Appearance -> Chat Window 
and select a theme from the list.

Comment 5 Neal Becker 2004-01-27 03:32:26 UTC
Subject: Re:  kopete xsl parse error

On Monday 26 January 2004 09:22 pm, Richard Smith wrote:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
> http://bugs.kde.org/show_bug.cgi?id=73571
>
>
>
>
> ------- Additional Comments From kde@metafoo.co.uk  2004-01-27 03:21
> ------- Subject: Re: [Kopete-devel]  kopete xsl parse error
>
> On Tuesday 27 January 2004 2:00 am, Neal Becker wrote:
> > Additional Comments From jason@keirstead.org  2004-01-26 23:35:
> > > Make sure you have an XSL style chosen. This seems to be a common
> > > cause of this bug due to some borked upgrading.
> >
> > Thanks.  But, I don't know what that means.  Is this a setting in kopete?
> > Or, something to do with desktop style settings?
>
> It's a Kopete setting. Go to Kopete Configuration -> Appearance -> Chat
> Window and select a theme from the list.

Thanks.  Problem solved.

Comment 6 Richard Smith 2004-01-27 03:52:29 UTC
We should revert to the default style if none is configured, for whatever reason.
Comment 7 Martijn Klingens 2004-01-27 20:53:14 UTC
Subject: Re: [Kopete-devel]  kopete xsl parse error

On Tuesday 27 January 2004 03:32, Neal Becker wrote:
> Thanks.  Problem solved.

Next question (for kopete-devel mostly): why is it possible that the style 
gets lost completely? I mean, if the setting gets broken and it falls back to 
the Kopete default, that's bad but I could live. But somehow not even the 
Kopete default is picked up.

Jason, any idea?

Comment 8 Jason Keirstead 2004-01-27 21:00:18 UTC
There is one possibility for this I am unsure of.

At one point in development, I think the whole XSL string may have been saved in the config file, whereas now it is saving the path to the file relative to appdir.

Maybe what is happening is Kopete is reading in the old XSL string, looking of r afile that does not exist, and instead of falling back on the defaut, just bailing out. If this is the case, it can be fixed with a simple fallover check. If not, then something is getting messed up furing install that'd have to be looked at with kconf_update.

These are  wild guesses, I don't have source access ATM.
Comment 9 Neal D. Becker 2004-01-27 21:01:18 UTC
Subject: Re:  chatwindow style lost on upgrade

On Tuesday 27 January 2004 02:53 pm, Martijn Klingens wrote:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
> http://bugs.kde.org/show_bug.cgi?id=73571
>
>
>
>
> ------- Additional Comments From klingens@kde.org  2004-01-27 20:53 -------
> Subject: Re: [Kopete-devel]  kopete xsl parse error
>
> On Tuesday 27 January 2004 03:32, Neal Becker wrote:
> > Thanks.  Problem solved.
>
> Next question (for kopete-devel mostly): why is it possible that the style
> gets lost completely? I mean, if the setting gets broken and it falls back
> to the Kopete default, that's bad but I could live. But somehow not even
> the Kopete default is picked up.
>
> Jason, any idea?

FYI, I upgraded via konstruct.

Comment 10 Matt Rogers 2004-01-31 19:07:29 UTC
Subject: KDE_3_2_BRANCH: kdenetwork/kopete/libkopete/private

CVS commit by mattr: 

Add a check to make sure that the stylesheet exists before loading it.
Defaults back to the Kopete style is none is found. This could also be useful
if you have a custom style and then remove it. 

CCMAIL: 73571-done@bugs.kde.org


  M +3 -0      kopeteprefs.cpp   1.25.2.1


--- kdenetwork/kopete/libkopete/private/kopeteprefs.cpp  #1.25:1.25.2.1
@@ -90,4 +90,7 @@ void KopetePrefs::load()
         mShowTray = config->readBoolEntry( "Show Systemtray", true);
         mStyleSheet = config->readEntry("Stylesheet", locate("appdata",QString::fromLatin1("styles/Kopete.xsl") ) );
+        if ( !QFile::exists( mStyleSheet ) )
+                mStyleSheet = locate( "appdata", QString::fromLatin1("styles/Kopete.xsl") );
+
         mStyleContents = fileContents( mStyleSheet );
 


Comment 11 Duncan Mac-Vicar Prett 2004-02-18 14:44:02 UTC
his bug was hard to figure.

I noticed my brother got the problem after upgrading KDE's gentoo (notice KDE 
path changed from /usr/kde/3.1 to 3.1)

I checked my kopeterc and noticed opening the style selector didn't selected 
any style, but my chat windows works fine. So I noticed my kopeterc pointed 
to a stylesheet of a old KDE install I have in /home/kde (*sigh*)

My brother uninstalled old 3.1 thats why it had the problem. So yes, we are 
storing the entire absolute path. The selector makes a string comparision, 
but if you change KDE install path, it will fail, baceuse it compares 
absolute pathnames so it will not select any style.

When you save, the selector calls setStylesheet with a null value, which 
doesn't have a fallback to default until now (I added one). It would be nice 
to know how feasible is to use relative paths in the future. Thanks to the 
fallback it will work always now. All entry points are checked, but the use 
of absolute stysheet locations makes me feel we can do it cleaner.

Duncan