Bug 72844 - "Wrong" product kcmkabldapconfig in Report Bug wizard
Summary: "Wrong" product kcmkabldapconfig in Report Bug wizard
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kab3
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Tobias Koenig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-17 19:56 UTC by Malte S. Stretz
Modified: 2009-08-05 16:03 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S. Stretz 2004-01-17 19:56:54 UTC
Version:           unknown (using KDE 3.1.94 (CVS >= 20031206), Gentoo)
Compiler:          gcc version 3.2.3 20030422 (Gentoo Linux 1.4 3.2.3-r3, propolice)
OS:          Linux (i686) release 2.4.20-gentoo-r8

When one goes and selects Help->Report Bug in the Address Book, the wizard suggests kcmkabldapconfig as the product (even though I don't use any LDAP features). That should probably be kaddressbook.
Comment 1 Tobias Koenig 2004-01-23 20:14:18 UTC
Subject: kdepim/kaddressbook

CVS commit by tokoe: 

Fixed 2 bugs:
  - the changes in the settings are applyed to the program again
  - the KGlobal::activeInstance() isn't overwritten, that solves #72844

CCMAIL:72844-done@bugs.kde.org


  M +7 -11     kabcore.cpp   1.66
  M +0 -2      kabcore.h   1.29


--- kdepim/kaddressbook/kabcore.cpp  #1.65:1.66
@@ -78,6 +78,5 @@ KABCore::KABCore( KXMLGUIClient *client,
   : KAB::Core( client, parent, name ), mStatusBar( 0 ), mViewManager( 0 ),
     mExtensionManager( 0 ), mCategorySelectDialog( 0 ), mCategoryEditDialog( 0 ),
-    mConfigureDialog( 0 ), mLdapSearchDialog( 0 ), mReadWrite( readWrite ),
-    mModified( false )
+    mLdapSearchDialog( 0 ), mReadWrite( readWrite ), mModified( false )
 {
   mWidget = new QWidget( parent, name );
@@ -820,15 +819,12 @@ void KABCore::configure()
   saveSettings();
 
-  if ( !mConfigureDialog ) {
-    mConfigureDialog = new KCMultiDialog( mWidget );
-
-    connect( mConfigureDialog, SIGNAL( configCommitted() ),
+  KCMultiDialog dlg( mWidget, "", true );
+  connect( &dlg, SIGNAL( configCommitted() ),
              this, SLOT( configurationChanged() ) );
 
-    mConfigureDialog->addModule( "kabconfig.desktop" );
-    mConfigureDialog->addModule( "kabldapconfig.desktop" );
-  }
+  dlg.addModule( "kabconfig.desktop" );
+  dlg.addModule( "kabldapconfig.desktop" );
 
-  mConfigureDialog->show();
+  dlg.exec();
 }
 

--- kdepim/kaddressbook/kabcore.h  #1.28:1.29
@@ -47,5 +47,4 @@ class KAction;
 class KActionCollection;
 class KConfig;
-class KCMultiDialog;
 class KToggleAction;
 class KXMLGUIClient;
@@ -369,5 +368,4 @@ class KABCore : public KAB::Core
     QSplitter *mExtensionBarSplitter;
 
-    KCMultiDialog *mConfigureDialog;
     LDAPSearchDialog *mLdapSearchDialog;
     QDict<AddresseeEditorDialog> mEditorDict;


Comment 2 Tobias Koenig 2009-08-05 16:03:53 UTC
The development of the old KAddressBook will be discontinued for KDE 4.4.
Since the new application has the same name, but a completly new code base we close all bug reports against the old version and ask the submitters to resend there reports against the new product.