Bug 69480 - crash in kspread importing Open Office spreadsheet
Summary: crash in kspread importing Open Office spreadsheet
Status: RESOLVED FIXED
Alias: None
Product: calligrasheets
Classification: Applications
Component: filters (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: ---
Assignee: Ariya Hidayat
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-02 00:35 UTC by Kevin Gilbert
Modified: 2004-02-17 23:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Gilbert 2003-12-02 00:35:43 UTC 
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

Nothing more to add - except the fix :)

--- /usr/local/src/koffice-031128/filters/kspread/opencalc/opencalcimport.cc	2003-08-17 08:57:42.000000000 +0930
+++ usr/local/src/kde-snapshot-031128/koffice-031128/filters/kspread/opencalc/opencalcimport.cc	2003-12-02 08:42:43.000000000 +0930
@@ -203,9 +203,9 @@
 
   QDomNode node;
   if ( rowStyle )
-   node = rowStyle->firstChild();
-
-  kdDebug(30518) << "RowStyle: " << rowStyle << ", " << rowStyle->tagName() << endl;
+  {   node = rowStyle->firstChild();
+      kdDebug(30518) << "RowStyle: " << rowStyle << ", " << rowStyle->tagName() << endl;
+  }
 
   double height = -1.0;
   bool insertPageBreak = false;
Comment 1 Waldo Bastian 2004-02-17 23:00:14 UTC 
CVS commit by waba: 

Don't crash on the debug output. (BR69480)
Patch by Kev Gilbert
CCMAIL: 69480-done@bugs.kde.org


  M +4 -3      opencalcimport.cc   1.18.2.1


--- koffice/filters/kspread/opencalc/opencalcimport.cc  #1.18:1.18.2.1
@@ -204,7 +204,8 @@ bool OpenCalcImport::readRowFormat( QDom
   QDomNode node;
   if ( rowStyle )
+  {
    node = rowStyle->firstChild();
-
   kdDebug(30518) << "RowStyle: " << rowStyle << ", " << rowStyle->tagName() << endl;
+  }
 
   double height = -1.0;