Bug 68499 - Karbon freezes when opening karbon file (testcase)
Summary: Karbon freezes when opening karbon file (testcase)
Status: RESOLVED FIXED
Alias: None
Product: karbon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR major
Target Milestone: ---
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-18 14:21 UTC by Dik Takken
Modified: 2003-11-24 14:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
testcase (6.13 KB, application/x-karbon)
2003-11-18 14:21 UTC, Dik Takken
Details
patch for loading problem (2.80 KB, patch)
2003-11-23 16:18 UTC, Rob Buis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dik Takken 2003-11-18 14:21:24 UTC
Version:           1.2.94 (using KDE KDE 3.1.93)
Installed from:    Compiled From Sources
OS:          Linux

I was just working with Karbon and saved my progress every few minutes. Something went wrong, undo did not work correctly and I wanted to open a previous version. The first time karbon said the selected file did not exist. The second time I tried Karbon stopped responding and ate 100% CPU.

I attached the file below.
Comment 1 Dik Takken 2003-11-18 14:21:56 UTC
Created attachment 3271 [details]
testcase
Comment 2 Rob Buis 2003-11-19 16:57:04 UTC
I think I fixed this, can you check to make sure?
Comment 3 Dik Takken 2003-11-19 17:21:16 UTC
Check? How? Do you have a patch?
Comment 4 Rob Buis 2003-11-19 17:30:01 UTC
The fix I think solves this is in cvs. Do you have access or should I make a patch for you?
Comment 5 Dik Takken 2003-11-19 17:33:45 UTC
Please create a patch....
Comment 6 Rob Buis 2003-11-23 16:18:31 UTC
Created attachment 3360 [details]
patch for loading problem
Comment 7 Rob Buis 2003-11-24 11:41:11 UTC
Not sure if you did got the confirmation message :} Please let me know
if the patch fixes this bug.
Comment 8 Dik Takken 2003-11-24 13:04:20 UTC
Is this a patch against 1.2.93? When applying, it says:

[dik@dik karbon]$ patch -p0 < loadpatch.patch
patching file karbon_view.h
patching file karbon_view.cc
Hunk #1 succeeded at 135 (offset -1 lines).
Hunk #2 succeeded at 951 (offset -7 lines).
patching file karbon_part.h
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file karbon_part.cc

I re-compiled Karbon after applying this patch, and It does not seem to freeze anymore.  It still says the file does not exist though.
Comment 9 Rob Buis 2003-11-24 13:18:07 UTC
About file loading problem (using startup dialog right?), I did this fix :

http://webcvs.kde.org/cgi-bin/cvsweb.cgi/koffice/karbon/karbon_part.cc.diff?r1=1.149&r2=1.150

For the above patch, I screwed up karbon_part.h indeed.
Instead you need :

http://webcvs.kde.org/cgi-bin/cvsweb.cgi/koffice/karbon/karbon_part.h.diff?r1=1.75&r2=1.77

You can just save the diffs linked to above and apply them to the original sources.
Good luck!
Comment 10 Dik Takken 2003-11-24 14:02:12 UTC
It works! Thank you!
Comment 11 Rob Buis 2003-11-24 14:14:48 UTC
*** Bug has been marked as fixed ***.