Bug 68347 - Konqueror statusbar color differs with multiple tabs vs. a single tab
Summary: Konqueror statusbar color differs with multiple tabs vs. a single tab
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-16 08:13 UTC by Mario Tanev
Modified: 2008-07-26 10:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Multi-tab screenshot (103.24 KB, image/jpeg)
2003-11-16 08:14 UTC, Mario Tanev
Details
Single-tab screenshot (103.34 KB, image/jpeg)
2003-11-16 08:15 UTC, Mario Tanev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Tanev 2003-11-16 08:13:34 UTC
Version:           3.1.93 (using KDE 3.1.93 (CVS >= 20031111), Gentoo)
Compiler:          gcc version 3.3.2 20031022 (Gentoo Linux 3.3.2-r2, propolice)
OS:          Linux (i686) release 2.4.22

This is more of a design/usability issue. When konqueror operates more than one tab it uses its old ( pre-George Staikos SSL-info enhanced ) look and feel ( with the SSL-info present however ). 

Except for the green light and righthand-side checkbox, the colors also differ. I am not familiar with the righthand-side checkbox, it might have some special meaning in a multi-tab view that it doesn't have in a single tab view. But the green light and different colouring of the status bar? - I doubt it.

Please, take a look at the attached screenshots.

Thank you.
Comment 1 Mario Tanev 2003-11-16 08:14:22 UTC
Created attachment 3241 [details]
Multi-tab screenshot
Comment 2 Mario Tanev 2003-11-16 08:15:13 UTC
Created attachment 3242 [details]
Single-tab screenshot
Comment 3 Mario Tanev 2003-11-16 08:16:29 UTC
Note, I am not arguing in favor of either design ( although I do have a preference ), but what bothers me is the entirely different look and feel.
Comment 4 George Staikos 2003-11-16 16:53:43 UTC
Subject: Re:  New: Konqueror statusbar looks differently with multiple tabs vs. a single tab

On Sunday 16 November 2003 02:13, Mario Tanev wrote:
> This is more of a design/usability issue. When konqueror operates more than
> one tab it uses its old ( pre-George Staikos SSL-info enhanced ) look and
> feel ( with the SSL-info present however ).
>
> Except for the green light and righthand-side checkbox, the colors also
> differ. I am not familiar with the righthand-side checkbox, it might have
> some special meaning in a multi-tab view that it doesn't have in a single
> tab view. But the green light and different colouring of the status bar? -
> I doubt it.
>
> Please, take a look at the attached screenshots.

  Was this any different in the past?  Basically having two tabs means you 
have two views, which means you need those statusbar entries...

Comment 5 Mario Tanev 2003-11-16 18:02:19 UTC
Subject: Re:  Konqueror statusbar looks differently with multiple tabs vs. a single tab

Well, how about the statusbar color discrepancy?

Using plastik colors, the single-tab statusbar is grey while the multi-tab one 
is white. I have seen this with other color schemes.

Also, I will admit, I am not sure what the green light is for.



On Sunday 16 November 2003 07:53, you wrote:
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>
> http://bugs.kde.org/show_bug.cgi?id=68347
>
>
>
>
> ------- Additional Comments From staikos@kde.org  2003-11-16 16:53 -------
> Subject: Re:  New: Konqueror statusbar looks differently with multiple tabs
> vs. a single tab
>
> On Sunday 16 November 2003 02:13, Mario Tanev wrote:
> > This is more of a design/usability issue. When konqueror operates more
> > than one tab it uses its old ( pre-George Staikos SSL-info enhanced )
> > look and feel ( with the SSL-info present however ).
> >
> > Except for the green light and righthand-side checkbox, the colors also
> > differ. I am not familiar with the righthand-side checkbox, it might have
> > some special meaning in a multi-tab view that it doesn't have in a single
> > tab view. But the green light and different colouring of the status bar?
> > - I doubt it.
> >
> > Please, take a look at the attached screenshots.
>
>   Was this any different in the past?  Basically having two tabs means you
> have two views, which means you need those statusbar entries...

Comment 6 Stephan Binner 2003-11-16 20:11:18 UTC
The green light shows which view (Try Windows/Split View) is active (which granted doesn't make much sense with tabs with only one view each) and the checkbox links views (also works with tabs).
Comment 7 Stephan Binner 2003-11-20 17:15:29 UTC
This difference seems to be wanted (konq_frame.cc#272). Any reason why it has to be different, David?
Comment 8 David Faure 2003-11-20 17:35:09 UTC
Subject: Re:  Konqueror statusbar color differs with multiple tabs vs. a single tab

> This difference seems to be wanted (konq_frame.cc#272). Any reason why it has to be different, David?
To see which one is the active view.

Comment 9 David Faure 2003-11-20 17:40:06 UTC
Subject: Re:  Konqueror statusbar color differs with multiple tabs vs. a single tab

OK the bug is that the code that activates the "splitted views" look,
with checkbox + different color + green light,
is getting activated by having multiple tabs. This is wrong.
It should only be activated for splitted views - i.e. for views which
are more than one inside a given tab.

Comment 10 Stephan Binner 2003-11-20 17:42:27 UTC
Not differ between active and inactive view, but letting code speak:

--- konq_frame.cc       14 Oct 2003 19:57:46 -0000      1.186
+++ konq_frame.cc       20 Nov 2003 16:41:52 -0000
@@ -269,7 +269,7 @@ void KonqFrameStatusBar::updateActiveSta
     const QColorGroup& activeCg = kapp->palette().active();
     QBrush bg = activeCg.brush ( QColorGroup::Background );
     pal.setBrush( QColorGroup::Background,
-                  m_led->isShown() ? ( hasFocus ? activeCg.midlight()
+                  m_led->isShown() ? ( hasFocus ? bg
                                        : activeCg.mid() ) // active/inactive
                   : bg ); // only one view
Comment 11 Stephan Binner 2003-11-20 17:44:45 UTC
About comment 9, why shouldn't you be able to link tabs together?
Comment 12 David Faure 2003-11-20 17:49:18 UTC
Subject: Re:  Konqueror statusbar color differs with multiple tabs vs. a single tab

> About comment 9, why shouldn't you be able to link tabs together?

OK keep the link checkbox if you want.... It's only the "active view" indicators
(green light and different statusbar color) that should be fixed - to not be triggered
in the "single view in tab" case.

Comment 13 Mario Tanev 2003-12-01 01:42:37 UTC
Subject: Re:  Konqueror statusbar color differs with multiple tabs vs. a single tab

Also,

I just noticed that in single-tab, single-view file-browsing mode, the 
status-bar contains the green light and the link-box.

Comment 14 Mario Tanev 2004-05-15 20:38:10 UTC
This continues to happen in KDE-CVS.
Comment 15 Richard Fujimoto 2004-06-13 20:13:44 UTC
Still happening in 3.3 Alpha 1
Comment 16 Jaime Torres 2008-07-12 11:29:26 UTC
In konqueror 4 svn trunk r828814 the statusbars have the same color. The active view is known by the green dot or the blue line in the borders of the view.
Comment 17 Jaime Torres 2008-07-26 10:35:25 UTC
In konqueror 4 the active window is know by the green dot and the blue line in the borders of the view.