Created attachment 3142 [details]
image showing the inbox state after incorrect threading

Subject: Re:  New: kmail: Threading too aggressive? Irrelevant messages are threaded

On Tuesday 11 November 2003 05:51, Amit Shah wrote:

> I use gmx's pop service; they send a message each day about which mails
> were put into the spam folder in the mailbox(on their server).
>
> When my local kmail inbox has some mails and this spam report comes in, all
> of the existing mails are threaded inside the gmx-spam mail, and they're
> completely irrelevant. I'm pasting the headers of the gmx mail and some of
> the mails that were tagged as its children here:

Thanks for the detailed bug report. :)

> ---- parent: gmx mail ----
> From: "GMX Spamschutz" <mailings@gmx.net>
> To: "GMX Kundennummer <my gmx number>: ;
> Subject: 33 neue Mails in Ihrem Spamverdacht-Ordner
> Date: Tue, 11 Nov 2003 04:40:39 +0000
> Content-Type: text/plain;
> 

Subject: Re:  kmail: Threading too aggressive? Irrelevant messages are threaded

On Tuesday 11 Nov 2003 12:21, Till Adam wrote:
> Thanks for the detailed bug report. :)

heh, thanks.

[snipped mail headers]

> Do those mails really not have a Message-Id header? That would be rather

Yes; those were the entire headers.

> broken. Still, if that's the reason than the threading algorithm needs to
> handle that more gracefully. Same when switching of threading by subject,
> I presume?

Today when both were enabled (threading as well as thread by subject), I got 
the same behavior as reported yesterday. When I disabled the thread by 
subject option, the mails got sorted properly. On re-enabling the option, 
the mails stayed sorted the way they were, so didn't observe the weird 
threading behavior even then. I'll disable the thread by subject and send a 
dummy message w/o Message-ID to myself to check if that's where the problem 
lies.

> Till

Amit.

Subject: kdepim/kmail

CVS commit by tilladam: 

Don't thread messages without an In-Reply-To header below messages without
a message id header (*sigh*) just because "" happens to equal "".

Amit, thanks for the test case.

CCMAIL: 67850-done@bugs.kde.org


  M +41 -38    kmheaders.cpp   1.589


--- kdepim/kmail/kmheaders.cpp  #1.588:1.589
@@ -1160,4 +1160,5 @@ void KMHeaders::msgAdded(int id)
     mItems[id] = hi;
 
+    if ( !msgId.isEmpty() )
     mSortCacheItems.replace(msgId, sci);
     /* Add to the list of potential parents for subject threading. But only if
@@ -1186,4 +1187,5 @@ void KMHeaders::msgAdded(int id)
     // The message we just added might be a better parent for one of the as of
     // yet imperfectly threaded messages. Let's find out.
+    if ( !msgId.isEmpty() ) {
     QPtrListIterator<KMHeaderItem> it(mImperfectlyThreadedList);
     KMHeaderItem *cur;
@@ -1228,4 +1230,5 @@ void KMHeaders::msgAdded(int id)
           mItems[tryMe]->sortCacheItem()->updateSortFile( sortStream, mFolder );
           fclose (sortStream);
+          }
         }
       }

Subject: Re:  kmail: Threading too aggressive? Irrelevant messages are threaded

On Friday 14 Nov 2003 20:48, Till Adam wrote:
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- Status|UNCONFIRMED                 |RESOLVED
>          Resolution|                            |FIXED

Thanks, Till :-)