Bug 64729 - filter menu in knode is empty
Summary: filter menu in knode is empty
Status: RESOLVED FIXED
Alias: None
Product: knode
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-22 14:44 UTC by Eggert Ehmke
Modified: 2003-09-28 23:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eggert Ehmke 2003-09-22 14:44:33 UTC
Version:           0.7.6 (using KDE 3.1.9)
Compiler:          gcc version 3.3 20030226 (prerelease) (SuSE Linux)
OS:          Linux (i686) release 2.6.0-test5-bk4

Clicking on the Filter button, or selecting the "View/Filter" menu, only an empty submenu is shown. It used to have entries like "all/unread/new/thread with own...". These should be there by default.
Comment 1 Roberto Teixeira 2003-09-28 23:53:03 UTC
Subject: kdepim/knode

CVS commit by maragato: 

Make knode load filters from the local datadir only if they exist there.

CCMAIL: 64729-done@bugs.kde.org


  M +4 -2      knarticlefilter.cpp   1.27
  M +4 -1      knfiltermanager.cpp   1.31


--- kdepim/knode/knarticlefilter.cpp  #1.26:1.27
@@ -77,5 +77,6 @@ bool KNArticleFilter::loadInfo()
 {
   if (i_d!=-1) {
-    QString fname(locateLocal("data","knode/") + QString("filters/%1.fltr").arg(i_d));
+    QString fname(locate("data",QString( "knode/filters/%1.fltr" ).arg(i_d) ) );
+
     if (fname.isNull())
       return false;
@@ -96,5 +97,6 @@ bool KNArticleFilter::loadInfo()
 void KNArticleFilter::load()
 {
-  QString fname(locateLocal("data","knode/") + QString("filters/%1.fltr").arg(i_d));
+  QString fname(locate("data",QString( "knode/filters/%1.fltr").arg(i_d) ) );
+
   if (fname.isNull())
     return;

--- kdepim/knode/knfiltermanager.cpp  #1.30:1.31
@@ -21,4 +21,5 @@
 #include <kstandarddirs.h>
 #include <ksimpleconfig.h>
+#include <kdebug.h>
 
 #include "utilities.h"
@@ -109,5 +110,6 @@ void KNFilterManager::prepareShutdown()
 void KNFilterManager::loadFilters()
 {
-  QString fname(locateLocal("data","knode/")+"filters/filters.rc");
+  QString fname(locate("data","knode/filters/filters.rc") );
+
   if (!fname.isNull()) {
     KSimpleConfig conf(fname,true);