Bug 64051 - Malformed Url error, out of nowhere
Summary: Malformed Url error, out of nowhere
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: Web Presence Plugin (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-11 01:45 UTC by davidsmind
Modified: 2006-11-05 20:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description davidsmind 2003-09-11 01:45:50 UTC
Version:           0.7.91>=20030909 (using KDE 3.1.9)
Compiler:          gcc version 3.3.1 20030904 (Gentoo Linux 3.3.1-r1, propolice)
OS:          Linux (i686) release 2.6.0-test5

every once and a while...for apparently no reason, I get a error message that looks like the following

Message box title bar: "ERROR - kopete"
Message box: messagebox_critical.png is shown to the left of text that states "Malformed URL" and underneath is an OK button.

I have no real clue as to what this error is refering to, if it is a ligitamite error, it should be more understandable.
Comment 1 Olivier Goffart 2003-09-11 09:33:38 UTC
Some other people already reported this problem.  
I personaly never seen it. 
 
have you any idea where that happens? 
There are no "Malformed URL" string in the whole kopete sources 
 
Comment 2 Tom Wesley 2003-09-11 09:36:50 UTC
I had this issue, but I believe it was kget retrying a download.  At least 
since I emptied its queue I have not received the error. 
 
Tom 
Comment 3 Andy Goossens 2003-09-11 23:17:38 UTC
Looks like a bug in KDE HEAD or so... 
Comment 4 Matt Rogers 2003-09-20 21:39:38 UTC
i'm not seeing the error either. Please reopen if you can give us a way to reliably 
reproduce it 
Comment 5 Matt Rogers 2003-09-20 21:40:06 UTC
grrr, oops. reopening so i can close it with the right reason. 
Comment 6 Matt Rogers 2003-09-20 21:40:28 UTC
this is what I meant the first time. 
Comment 7 jamie dalgetty 2003-10-04 03:28:26 UTC
I get this same error after upgrading from 0.7 to 0.7.2. (texstar) 
I also cannot login to my icq since the upgrade. 
 
i am running 3.1.3 
Comment 8 Bram Schoenmakers 2003-12-29 18:48:24 UTC
In KDE 3.1.94 (Kopete 0.7.4) the error remains. Everytime when I change status (at least on ICQ and MSN) I get this error after a few seconds.
Comment 9 Olivier Goffart 2003-12-29 19:01:00 UTC
Are you using the webpresence plugin ?
Comment 10 Bram Schoenmakers 2003-12-29 19:52:05 UTC
Stupid me, I think that plugin caused this error. But isn't it possible to surpress this error?
Comment 11 Olivier Goffart 2003-12-29 22:37:56 UTC
In fact i don't know, it's just a supposition (a guess)
Comment 12 Matt Rogers 2003-12-30 05:35:06 UTC
Subject: Re:  Malformed Url error, out of nowhere

no, it's an error in KIO and cannot be suppressed.

Comment 13 Martijn Klingens 2003-12-30 12:07:54 UTC
Subject: Re: [Kopete-devel]  Malformed Url error, out of nowhere

On Tuesday 30 December 2003 05:35, Matt Rogers wrote:
> no, it's an error in KIO and cannot be suppressed.

Actually, why can't it? I mean, where does the error come from in the first 
place? I'd say we're simply feeding KIO with some bogus data and that for 
sure _can_ be fixed on our side.

Comment 14 Will Stephenson 2003-12-30 13:00:12 UTC
Subject: Re: [Kopete-devel]  Malformed Url error, out of nowhere

I'll have a look at it.

Comment 15 Matt Rogers 2003-12-30 16:06:31 UTC
I should have already fixed an error like this in CVS. I wonder if I missed a case
Comment 16 Matt Rogers 2003-12-30 16:29:45 UTC
Subject: Re:  Malformed Url error, out of nowhere

> On Tuesday 30 December 2003 05:35, Matt Rogers wrote:
> > no, it's an error in KIO and cannot be suppressed.
>
> Actually, why can't it? I mean, where does the error come from in the first
> place? I'd say we're simply feeding KIO with some bogus data and that for
> sure _can_ be fixed on our side.

I should clarify: The code that causes this error is in Kopete, but we can't 
suppress the messagebox that is popped up when we cause this error. Anyways, 
I fixed something like this in CVS already.

Comment 17 Casey Allen Shobe 2003-12-31 02:30:28 UTC
So test for the file's existence before attempting to use it, and put in a sensible default.  Do not allow the default to be changed without verifying that the input location is valid (perhaps make it be browsed for?).
Comment 18 Guy 2004-01-06 19:28:59 UTC
Ok, so am I missing something? Is there a fix for this? The client works ok, but the error is annoying.
Comment 19 Casey Allen Shobe 2004-01-06 22:37:04 UTC
To workaround it, just make sure the file specified in the configuration for the web presence plugin is valid.

This shouldn't be resolved, though.
Comment 20 Matt Rogers 2004-02-04 02:36:55 UTC
Subject: kdenetwork/kopete/plugins/webpresence

CVS commit by mattr: 

Fix bug 64051. Make sure the that url specified is actually valid before
trying to upload the file. Also moved some stuff around so that if there's
an error, no unnecessary processing occurs.

CCMAIL: 64051@bugs.kde.org


  M +8 -8      webpresenceplugin.cpp   1.44


--- kdenetwork/kopete/plugins/webpresence/webpresenceplugin.cpp  #1.43:1.44
@@ -137,13 +137,15 @@ void WebPresencePlugin::slotWriteFile()
         bool error = false;
         // generate the (temporary) XML file representing the current contactlist
-        KTempFile* xml = generateFile();
-        xml->setAutoDelete( true );
-
-        if ( url.isEmpty() )
+        KURL dest( url );
+        if ( url.isEmpty() || !dest.isValid() )
         {
-                kdDebug(14309) << "url is empty. NOT UPDATING!" << endl;
+                kdDebug(14309) << "url is empty or not valid. NOT UPDATING!" << endl;
                 error = true;
         }
 
+        if ( !error )
+        {
+                KTempFile* xml = generateFile();
+                xml->setAutoDelete( true );
         kdDebug(14309) << k_funcinfo << " " << xml->name() << endl;
 
@@ -165,9 +167,7 @@ void WebPresencePlugin::slotWriteFile()
                 delete xml; // might make debugging harder!
         }
-        if ( !error )
-        {
+
                 // upload it to the specified URL
                 KURL src( m_output->name() );
-                KURL dest( url );
                 KIO::FileCopyJob *job = KIO::file_copy( src, dest, -1, true, false, false );
                 connect( job, SIGNAL( result( KIO::Job * ) ),


Comment 21 Matt Rogers 2004-02-04 02:37:41 UTC
Subject: KDE_3_2_BRANCH: kdenetwork/kopete/plugins/webpresence

CVS commit by mattr: 

Backport the patch that fixes bug 64051.

CCMAIL: 64051-done@bugs.kde.org


  M +8 -8      webpresenceplugin.cpp   1.41.2.2


--- kdenetwork/kopete/plugins/webpresence/webpresenceplugin.cpp  #1.41.2.1:1.41.2.2
@@ -137,13 +137,15 @@ void WebPresencePlugin::slotWriteFile()
         bool error = false;
         // generate the (temporary) XML file representing the current contactlist
-        KTempFile* xml = generateFile();
-        xml->setAutoDelete( true );
-
-        if ( url.isEmpty() )
+        KURL dest( url );
+        if ( url.isEmpty() || !dest.isValid() )
         {
-                kdDebug(14309) << "url is empty. NOT UPDATING!" << endl;
+                kdDebug(14309) << "url is empty or not valid. NOT UPDATING!" << endl;
                 error = true;
         }
 
+        if ( !error )
+        {
+                KTempFile* xml = generateFile();
+                xml->setAutoDelete( true );
         kdDebug(14309) << k_funcinfo << " " << xml->name() << endl;
 
@@ -165,9 +167,7 @@ void WebPresencePlugin::slotWriteFile()
                 delete xml; // might make debugging harder!
         }
-        if ( !error )
-        {
+
                 // upload it to the specified URL
                 KURL src( m_output->name() );
-                KURL dest( url );
                 KIO::FileCopyJob *job = KIO::file_copy( src, dest, -1, true, false, false );
                 connect( job, SIGNAL( result( KIO::Job * ) ),