Bug 60000 - Bad JPEG decoding in Konqueror
Summary: Bad JPEG decoding in Konqueror
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-18 18:04 UTC by Mitchell Mebane
Modified: 2003-06-26 23:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Comparison of JPEG decoding between Konqueror and Mozilla (138.56 KB, image/png)
2003-06-18 18:06 UTC, Mitchell Mebane
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mitchell Mebane 2003-06-18 18:04:51 UTC
Version:            (using KDE KDE 3.1.2)
Installed from:    Gentoo Packages
Compiler:          3.2.2 CFLAGS="-march=pentium4 -Os -pipe -fomit-frame-pointer -fPIC -mfpmath=sse,387"
OS:          Linux

I recently noticed that Konqueror isn't decoding some JPEGs properly. Some parts are blocky where they are supposed to be smooth. 
 
I am currently using KDE 3.1.2. I have tested 3.1.1 and 3.1.2. Both exhibit the bug.
 
One picture I have found that demonstrates this problem can be found at 
 
http://www.emutalk.net/showthread.php?s=&threadid=12952 
 
as the second picture in the thread. 
 
Mozilla renders the image correctly.
Comment 1 Mitchell Mebane 2003-06-18 18:06:06 UTC
Created attachment 1837 [details]
Comparison of JPEG decoding between Konqueror and Mozilla

On the left is Mozilla 1.3, on the right, Konqueror 3.1.2.

Notice how the top part of Mario's hat looks blocky in Konq, but not in
Mozilla. GIMP and KView both render the image correctly, the same as Mozilla.
Comment 2 Dirk Mueller 2003-06-18 19:01:49 UTC
Subject: kdelibs/khtml/misc

CVS commit by mueller: 

enable fancy upsampling again, because otherwise people think that Konqueror is buggy.
Ok, its 10% slower.. but who cares?
CCMAIL: 60000-done@bugs.kde.org


  M +1 -1      loader_jpeg.cpp   1.11


--- kdelibs/khtml/misc/loader_jpeg.cpp  #1.10:1.11
@@ -310,5 +310,5 @@ int KJPEGFormat::decode(QImage& image, Q
     {
         cinfo.buffered_image = TRUE;
-        cinfo.do_fancy_upsampling = FALSE;
+        cinfo.do_fancy_upsampling = TRUE;
         cinfo.do_block_smoothing = FALSE;
         cinfo.dct_method = JDCT_FASTEST;