Bug 58767 - spellchecking doesn't work for non-English document
Summary: spellchecking doesn't work for non-English document
Status: RESOLVED FIXED
Alias: None
Product: kile
Classification: Applications
Component: general (show other bugs)
Version: 1.5
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Jeroen Wijnhout
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-21 23:18 UTC by mrudolf
Modified: 2003-07-30 18:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
testspell.tex (146 bytes, text/x-tex)
2003-07-15 14:10 UTC, mrudolf
Details
patch for kspell library (6.31 KB, text/plain)
2003-07-17 21:20 UTC, Jeroen Wijnhout
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mrudolf 2003-05-21 23:18:59 UTC
Version:            (using KDE KDE 3.1.1a)
OS:          Linux

Spellchecking doesn't work for non-English document. I tried it on ISO-8859-2 text with Polish ispell and it marks incorrect text and replaces it incorrectly as well.

Same document in KEdit is spelled/corrected well, so maybe it has something to do with charset handling?
Comment 1 Jeroen Wijnhout 2003-05-23 19:44:23 UTC
Ok, spell checking seems to be buggy, I'll move it up on the TODO list.
Comment 2 Jeroen Wijnhout 2003-07-13 18:09:40 UTC
Could you check the CVS version? We switched to katepart, there could be a
difference. Otherwise send me a file for which spell-checking fails.
Comment 3 mrudolf 2003-07-13 21:08:12 UTC
Subject: Re:  spellchecking doesn't work for non-English document

Jeroen Wijnhout,   nie 13. lipca 2003 18:09:
>------- You are receiving this mail because: -------
>You reported the bug, or are watching the reporter.
>
>http://bugs.kde.org/show_bug.cgi?id=58767
>
>
>
>
>------- Additional Comments From wijnhout@science.uva.nl  2003-07-13 18:09
> ------- Could you check the CVS version? We switched to katepart, there
> could be a difference. Otherwise send me a file for which spell-checking
> fails.
Will try and report tomorrow.

Thanks
Comment 4 mrudolf 2003-07-15 14:10:34 UTC
Subject: Re:  spellchecking doesn't work for non-English document

Jeroen Wijnhout,   nie 13. lipca 2003 18:09:
>------- Additional Comments From wijnhout@science.uva.nl  2003-07-13 18:09
> ------- Could you check the CVS version? We switched to katepart, there
> could be a difference. Otherwise send me a file for which spell-checking
> fails.

In the attached document, "documentclass", "pt" and "maketitle"  are shown 
as incorrect.
\section is interpreted as "ction" and shown as incorrect, with "action" 
being suggested.




Created an attachment (id=2007)
testspell.tex
Comment 5 Jeroen Wijnhout 2003-07-15 14:46:32 UTC
Subject: Re:  spellchecking doesn't work for non-English document

On Tuesday 15 July 2003 14:10, you wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=58767
>
>
>
>
> ------- Additional Comments From mrudolf@mercury.ci.uw.edu.pl  2003-07-15
> 14:10 ------- Subject: Re:  spellchecking doesn't work for non-English
> document
>
> Jeroen Wijnhout,   nie 13. lipca 2003 18:09:
> >------- Additional Comments From wijnhout@science.uva.nl  2003-07-13 18:09
> > ------- Could you check the CVS version? We switched to katepart, there
> > could be a difference. Otherwise send me a file for which spell-checking
> > fails.
>
> In the attached document, "documentclass", "pt" and "maketitle"  are shown
> as incorrect.
> \section is interpreted as "ction" and shown as incorrect, with "action"
> being suggested.
>
>
>
>
> Created an attachment (id=2007)
>  --> (http://bugs.kde.org/attachment.cgi?id=2007&action=view)
> testspell.tex

I'm about to pull my hair out, because, this works for me...

So this file doesn't work correctly with kile but it does with kate?

This is the version of ispell I used (ispell -v)
@(#) International Ispell Version 3.1.20 (but really Aspell .33.7.1 alpha)

best,
Jeroen

Comment 6 mrudolf 2003-07-15 15:38:12 UTC
Subject: Re:  spellchecking doesn't work for non-English document

Jeroen Wijnhout,   wto 15. lipca 2003 14:46:

>I'm about to pull my hair out, because, this works for me...
Don't do it. Kate is broken as well, it even ignores spellchecker settings  
in Settings window (f. e. language selected).
(It seems that there were some changes in API, as I reported same problem 
with Quanta and it was fixed by its author).

>This is the version of ispell I used (ispell -v)
>@(#) International Ispell Version 3.1.20 (but really Aspell .33.7.1 alpha)
Ok, I think that things are broken for Ispell and work for Aspell. Maybe it 
simply means that Ispell support is (unofficially) dropped (I remember 
seeing  suggestions to do it on kde-devel).
It would be a pity, as AFAIK Ispell is still optimal solution for many 
non-English languages.

Comment 7 Jeroen Wijnhout 2003-07-16 10:28:39 UTC
Subject: Re:  spellchecking doesn't work for non-English document

On Tuesday 15 July 2003 15:38, you wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=58767
>
>
>
>
> ------- Additional Comments From mrudolf@mercury.ci.uw.edu.pl  2003-07-15
> 15:38 ------- Subject: Re:  spellchecking doesn't work for non-English
> document
>
> Jeroen Wijnhout,   wto 15. lipca 2003 14:46:
> >I'm about to pull my hair out, because, this works for me...
>
> Don't do it. Kate is broken as well, it even ignores spellchecker settings
> in Settings window (f. e. language selected).
> (It seems that there were some changes in API, as I reported same problem
> with Quanta and it was fixed by its author).

The Quanta author claims he didn't fix it (he wanted to know the solution as 
well). Anyway the problem lies in the kspell library. It doesn't pass the -t 
(and -h) switches to ispell.  Most installations of ispell have autodetection 
on, this means ispell autodetects TeX or HTML tags and ignores automatically. 

Apparently your installation doesn't. Type ispell in  a command-line
and type
\tst
if it complains, your ispell doesn't autodetect. Try ispell -t, now ispell 
should ignore \tst.

There is a workaround, but it is ugly and slow. It is better to change the 
kspell library.

> >This is the version of ispell I used (ispell -v)
> >@(#) International Ispell Version 3.1.20 (but really Aspell .33.7.1 alpha)
>
> Ok, I think that things are broken for Ispell and work for Aspell. Maybe it
> simply means that Ispell support is (unofficially) dropped (I remember
> seeing  suggestions to do it on kde-devel).
> It would be a pity, as AFAIK Ispell is still optimal solution for many
> non-English languages.

ispell is still supported (I took a peek at the code)

best,
Jeroen


Comment 8 mrudolf 2003-07-16 11:08:49 UTC
Subject: Re:  spellchecking doesn't work for non-English document

Jeroen Wijnhout,   
Comment 9 Reinhold Kainhofer 2003-07-16 11:23:03 UTC
Same thing here on a Debian sid machine with German ispell (no autodetection it 
seems... ). Even worse than the latex commands is that things like sch"on (beautiful in 
German), which contain Umlauts, are treated as two words! Using the -t option to ispell 
correctly identifies the word as correct. 
 
If this is really a bug in kspell, I think you should assign it to the kspell developers, 
otherwise they will not know about all the trouble people are having with the spell 
checker. 
Comment 10 Jeroen Wijnhout 2003-07-16 11:32:07 UTC
Subject: Re:  spellchecking doesn't work for non-English document

On Wednesday 16 July 2003 11:23, you wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=58767
>
>
>
>
> ------- Additional Comments From reinhold@kainhofer.com  2003-07-16 11:23
> ------- Same thing here on a Debian sid machine with German ispell (no
> autodetection it seems... ). Even worse than the latex commands is that
> things like sch"on (beautiful in German), which contain Umlauts, are
> treated as two words! Using the -t option to ispell correctly identifies
> the word as correct.
>
> If this is really a bug in kspell, I think you should assign it to the
> kspell developers, otherwise they will not know about all the trouble
> people are having with the spell checker.

Ok, I will contact the kspell maintainer.

thanks,
Jeroen

Comment 11 Jeroen Wijnhout 2003-07-17 21:20:12 UTC
Created attachment 2020 [details]
patch for kspell library

I've created a patch for the kspell library that allows you to select the mode
for i/aspell (via the configuration dialog).

Recompile Kile and kdelibs (kspell is in kdelibs/kdeui), that should fix this
bug.
Comment 12 mrudolf 2003-07-17 23:35:48 UTC
Subject: Re:  spellchecking doesn't work for non-English document

Jeroen Wijnhout,   czw 17. lipca 2003 21:20:


>I've created a patch for the kspell library that allows you to select the
> mode for i/aspell (via the configuration dialog).
Good idea! Alas, I probably won't check it in the near future, as I don't 
have KDE CVS running.

Maybe it is possible to backport it to KDE 3.1.x tree?
Comment 13 Jeroen Wijnhout 2003-07-18 09:28:24 UTC
Subject: Re:  spellchecking doesn't work for non-English document

On Thursday 17 July 2003 23:35, you wrote:
> Jeroen Wijnhout,   czw 17. lipca 2003 21:20:
> >I've created a patch for the kspell library that allows you to select the
> > mode for i/aspell (via the configuration dialog).
>
> Good idea! Alas, I probably won't check it in the near future, as I don't
> have KDE CVS running.

You can just compile KDE libs and link Kile with these libs. I can send you 
the patch and help you to compile if you want to test this (I'm eager to find 
out if the patch solves the problem).

> Maybe it is possible to backport it to KDE 3.1.x tree?

This would be possible, but I don't want to become the new maintainer of 
kspell (it is unmaintained as far as I know).

best,
Jeroen


Comment 14 Jeroen Wijnhout 2003-07-22 20:43:31 UTC
Should be fixed in CVS (but you'll have to link with the current CVS version of
kdelibs).
Comment 15 Jeroen Wijnhout 2003-07-30 18:16:49 UTC
Confirmed the fix using a RedHat system which showed the bug before the fix.