Version: (using KDE KDE 3.1) Installed from: Compiled From Sources Some suggestions to improver the user interface, and clean up the code, of the Java and JavaScript policy pages: (1) When adding an explicit host/domain via the New... button, have the default accept/reject setting in the dialogue the reverse of the global setting (i.e. if the global setting is Reject then the default in the dialogue should be Accept, and vice versa). This is the logical thing to do given that in most cases the entry being made will be an exception to the global setting. (2) Track the selection in the list view, enable or disable the Change... and Delete buttons as appropriate instead of popping up an error dialogue if the button is clicked and there is no selected item. Can eliminate several lines of code and four messages needing to be I18Ned. (3) Convert the common policy dialogue to use KDialogBase, and disable the OK button if the line edit is blank (no host/domain entered). Again eliminates several lines of code and an I18N message.
Created attachment 1621 [details] Patch for Java/JS control module
Thinks... these two pages are so similar with much code duplication. Could they be merged into a common class to do most of the work, subclassed for each page to implement the differences?
Leo, I think at least part of this is your code, so you might want to know of this.
ok, I looked at your suggestions and think they are reasonable. I also looked at your patch. However, I noticed that exactly your proposal (minus your changes to PolicyDlg) has already been implemented on the branch by Laurent Montel (who I notified about this): http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdebase/kcontrol/konqhtml/jsopts.cpp.diff?r1=1.32&r2=1.32.2.1 http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdebase/kcontrol/konqhtml/jsopts.h.diff?r1=1.9&r2=1.9.2.1 http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdebase/kcontrol/konqhtml/javaopts.cpp.diff?r1=1.31.2.1&r2=1.31.2.2 http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdebase/kcontrol/konqhtml/javaopts.h.diff?r1=1.4&r2=1.4.2.1 Laurent: Why is this on the branch and not in head? Would you take charge of forward porting your changes which essentially resemble the proposals of this bug's patch except for (3), and then only apply the policydlg.* specific parts from patch 1621, please? Actually I'd do it myself but I'm really overburdened at the moment, and won't be able to dedicate any time to KDE development until late July. I don't even have a recent KDE HEAD lying around. fwiw, confirming.
Laurent: are your commits in branch merged into HEAD? It looks like the dialogs in HEAD are a different codebase. It seems (2) and (3) is already implemented there, however (1) is not. Leo, is that your code?
I haven't done anything to the code since christmas. However, on a quick check I noticed that the toggling of the listview's buttons doesn't react on keyboard input. And yes, (1) is pending. I'll merge it after feature freeze (as this is a bug, not a wishlist item).
Subject: kdebase/kcontrol/konqhtml CVS commit by savernik: Finally fixed issue (1) of bug 58750. Thank you for your contribution. CCMAIL: 58750-done@bugs.kde.org M +8 -6 javaopts.cpp 1.48 M +6 -2 javaopts.h 1.8 M +8 -5 jsopts.cpp 1.49 M +7 -2 jsopts.h 1.15 M +9 -6 pluginopts.cpp 1.38 M +6 -2 pluginopts.h 1.11