Bug 57978 - some problems with adding an IRC channel
Summary: some problems with adding an IRC channel
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: IRC Plugin (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-01 20:39 UTC by Cp Hennessy
Modified: 2003-08-02 10:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cp Hennessy 2003-05-01 20:39:32 UTC
Version:           0.6.90cvs >= 20030326 (using KDE 3.1.9)
Compiler:          gcc version 3.2
OS:          Linux (i686) release 2.4.21-pre4

Hi here are some problems when I try to add a channel to IRC :

1) why is it called "Add Contact" and not "Add Channel" ?
    Maybe a compromise could be "Add Contact/Channel" ?

2) When I select the account to use why does it change color
 as if it is selected BUT does not add a "tick" mark to the
  checkbox ?

3) In the dialog used to search for channels, it is a bit confusing
  to have both "Channel or nickname" and "Search channels for"

4) The tab order is the reverse of what it should be

5) If I enter something in "Search for channels for" and hit return
  it seems to activate the "Next" key but really a return in this field
  should activate the "Search" button.

6) No hourglass when searching.

Thanks.
Comment 1 Olivier Goffart 2003-05-12 18:14:16 UTC
> 1) why is it called "Add Contact" and not "Add Channel" ?  
 
simply because it is Kopete standard. 
 
I don't like myself the idea that Channel are considered like Contact by kopete, but this 
is like that, and that's the way it is 
 
> 2) When I select the account to use why does it change color  
> as if it is selected BUT does not add a "tick" mark to the  
>  checkbox ?  
  
It is the QT way with checkbox in list. 
just click on the checkbox. 
 
Maybe should we hardcode this in kopete? 
 
> 3) In the dialog used to search for channels, it is a bit confusing  
> to have both "Channel or nickname" and "Search channels for"  
 
I don't see what is confusing here. 
IRC allow to search for channel, but not for users 
  
> 4) The tab order is the reverse of what it should be  
 
Which tab order? What is not in the right order? 
 
>  5) If I enter something in "Search for channels for" and hit return  
> it seems to activate the "Next" key but really a return in this field  
> should activate the "Search" button.  
 
I will see if i can fix that 
  
> 6) No hourglass when searching.  
  
TODO :-) 
 
Comment 2 Olivier Goffart 2003-05-12 18:22:29 UTC
Subject: kdenonbeta/kopete/protocols/irc

CVS commit by ogoffart: 

>  5) If I enter something in "Search for channels for" and hit return  
> it seems to activate the "Next" key but really a return in this field  
> should activate the "Search" button.  

Fixed

CCMAIL: 57978@bugs.kde.org


  M +1 -0      ircaddcontactpage.cpp   1.26


--- kdenonbeta/kopete/protocols/irc/ircaddcontactpage.cpp  #1.25:1.26
@@ -63,4 +63,5 @@ IRCAddContactPage::IRCAddContactPage( QW
 
         connect( ircdata->searchButton, SIGNAL( clicked() ), this, SLOT( slotSearch() ) );
+        connect( ircdata->searchText, SIGNAL( returnPressed() ), this, SLOT( slotSearch() ) );
         connect( ircdata->searchResults, SIGNAL( selectionChanged( QListViewItem*)), this,
                 SLOT( slotSelectionChanged( QListViewItem *) ) );


Comment 3 Cp Hennessy 2003-05-26 12:12:37 UTC
> > 3) In the dialog used to search for channels, it is a bit confusing 
> > to have both "Channel or nickname" and "Search channels for" 
> 
> I don't see what is confusing here. 
> IRC allow to search for channel, but not for users 
 
Sorry, my problem was not so clear, I don't use IRC very much but 
I do not understand what the difference is between "Channel or nickname" 
and "Search channels for" fields ? 
OK, the search for a channel is OK, but in what way does the field above this 
affect the search ? 
 
> > 4) The tab order is the reverse of what it should be 
> 
> Which tab order? What is not in the right order? 
If you place the cursor in the "Channel or nickname" field and hit the tab key 
the focus moves to the "Next" button rather than the "Search channels for"  
field. i.e. tabbing brings the focus in an anti-clockwise direction rather than the 
more normal clockwise direction. 
Actually the "Next" button is selected several times in the sequence before 
the focus returns to the original focus. 
 
> 
> > 6) No hourglass when searching. 
> 
> TODO :-) 
 
Great :) 
Comment 4 Jason Keirstead 2003-05-27 01:48:28 UTC
It searches the channel name and also the topic if available 
Comment 5 Michel Hermier 2003-08-02 10:31:53 UTC
No comment for a long time, and seems fixed in current cvs. Only stays the 
hourblass if it's really needed, someone should open a bug entry for it.