Version: (using KDE KDE 3.1) Installed from: Compiled From Sources Usability bug: the "Properties" dialog allows the user to change the icon for a directory, even when that directory (and hence its .directory file) is not writeable by the current user. This button should be disabled, or not even present---it should be presented as an ordinary icon, like files.
fixed long ago. thanks.
ack, sorry, not fixed.
confirming for 3.4.0. You can't actually change the icon, but you shouldn't be given the impression that you can change the icon.
This is the error message given with kde4: "Could not save properties. You do not have sufficient access to write to /bin/.directory."
while this hasn't been "fixed" in KDE 3.9.5, as soon as you try to actually apply a new icon, you receive the message: "Could not save properties. You do not have sufficient access to write to /home/guest/.directory." and although I agree that it may be a bit confusing at first, I this the message given should be sufficient to explain why it isn't a viable option.
I can confirm this for 3.5.9 and trunk r803905. Maybe this should be made a wish or WONTFIX in case this is the intended behaviour.
This is a kdelibs bug. This could be modified, for example, in the KFilePropsPlugin constructor, near the connect( iconButton, ....) There are three options: * Only disable it when the user has no possibility to enable write rights in the .directory file, ie: The user is not the owner, nor is part of the group and the other rights does not contains write right. * Be afraid of the changes in the permissions tab when the directory is writable. * Do not fix it.
Still current for 4.2
(In reply to comment #8) > Still current for 4.2 But no need to change Version, please.
Pino, I'm a little confused. Isn't useful information to know that a bug is still relevant, and can be reproduced against the 4.x series.
the version field is the original version the report was against, and should generally remain static.
I'm preparing a rather simple initial implementation about this. With simple initial permissions checks. IIRC, Dolphin now uses a "local database" for storing directory view configuration is the directory is not writable. So, even if that case, the icon button could be enabled and the icon value saved to that local writable database. @Peter: is this right ?
Created attachment 34169 [details] Simple initial patch We need to discuss about the possibility of writing "local" .directory files for folders without write permissions and any other possible situations. I also thought about using KDirWatcher to monitor (external) permissions changes and update the icon button status
I don't like the use of NetAccess (nested event loop). If you have a KFileItem already as input, just use its mostLocalUrl() member function. I'm not sure we really need to distinguish between "the .directory file exists, do we have write permissions to modify it", and "it doesn't exist, can we write into the parent dir". If it exists and is readonly, we can always delete+recreate it, if we have write permissions in the parent dir ;-) So the last test (directory is writable) is enough (and saves us from all the "KFileItem internalItem" code).
SVN commit 1096074 by dfaure: Don't show an icon button if the icon cannot be changed (directory or .desktop file not writable). (This looks better than disabling the button as the patch in the BR suggested; this way we still see the icon in full colors, rather than grayed out) CCBUG: 56857 M +18 -3 kpropertiesdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1096074
SVN commit 1096076 by dfaure: Don't show an icon button if the icon cannot be changed (directory or .desktop file not writable). KDE-3.1 bug from 2003, fixed for 4.4.1 in 2010, it's never too late ;) BUG: 56857 M +18 -3 kpropertiesdialog.cpp M +1 -0 kpropertiesdialog_p.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1096076
Bad fix. At the moment user must open a Create dialog twice: - first for creating a desktop file for example - and then for changing an icon Because the default path is in the system directory ( /usr/share/kde4/templates/.source/Program.desktop )