Bug 56766 - Printing job name CUPS and kword - not always correct! (mostly KDE print system)
Summary: Printing job name CUPS and kword - not always correct! (mostly KDE print system)
Status: RESOLVED FIXED
Alias: None
Product: kword
Classification: Miscellaneous
Component: general (show other bugs)
Version: 1.5 or before
Platform: Slackware Linux
: NOR normal
Target Milestone: ---
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-02 22:52 UTC by Wilfried Bytebier
Modified: 2003-04-02 23:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wilfried Bytebier 2003-04-02 22:52:33 UTC
Version:           1.2.1 (using KDE KDE 3.1)
Installed from:    Slackware Packages
Compiler:          gcc version 3.2.2 
OS:          Linux

If a document is printed in kword (haven't tested other applications yet), the print-job name in kprint is mostly "KDE print system".  The only time when the document name is show here, is when the file is saved for the first time and then printed.  If the document is closed and then opened again, the job-name is again "KDE print system".

How to reproduce this:
1. Open kword
2. Type some text
3. Print ---> job name = "KDE print system"
4. save as <document name>
5. Print ---> job name = <document name>
6. Close kword
7. Use conqueror to open the document
8. Print ---> job name = "KDE print system"
9. save as <document name>
10. Print ---> job name = "KDE print system"
11. save
12. Print ---> job name = "KDE print system"


The only time when the document-name is used as the job-name for the printing system is when the first time a document is saved with save-as.
Comment 1 David Faure 2003-04-02 23:43:00 UTC
Subject: koffice/lib/kofficecore

CVS commit by faure: 

Fix for: the print-job name in kprint is mostly "KDE print system".
We were trying to get the title from the document info page, but due to an
empty vs null confusion, the fallback to the filename didn't happen.
Now it uses the filename if the title is empty.
CCMAIL: 56766-done@bugs.kde.org


  M +1 -1      koMainWindow.cc   1.297


--- koffice/lib/kofficecore/koMainWindow.cc  #1.296:1.297
@@ -1095,5 +1095,5 @@ void KoMainWindow::print(bool quick) {
     }
 
-    if ( title.isNull() )
+    if ( title.isEmpty() )
         title = fileName;
     printer.setDocName( title );