That's why colors are configurable. There are no defaults which fit to every color 
scheme. 

Hi,

I agree with John. I guess most people will have a white background as default. 
So the default colors for the protocol view (s. constructor in 
protocolview.cpp) should take that into account.

Christian

But of course Stephan is also right, that it's more a wish than a bug since
the colors are configurable.

Christian

*UPDATE* 
 
Good new default colors are hard to find, because the colors are used as 
background color in the file view and as foreground color in the protocol view. 
Maybe we should make three new color configurations?? 
Until then, I think the following colors should be more readable: 
 
Conflict = 255, 130,  130 
Local Change = 130, 130, 255 
Remote Change = 70, 210, 70 
 
What do you think? 
 
Christian 

It not such a great idea to use the same color as both foreground and background -- it pretty 
much guarantees that text somewhere will be unreadable. A smarter algorithm would be to 
check the lightness of the default background color, and assign the foreground color 
appropriately -- if the default background color is dark, use a light foreground color, and 
vice-versa. Then use a lightened or darkened version of the same color when it's used as 
background in the file view. 

Subject: kdesdk/cervisia

CVS commit by cloose: 

Fix BR #56042 (*HACK*): 
Hopefully better default colors for "conflict", "local change" and "remote change"
against a white background.

(see comment #5 under BR #56042 to find out how to really fix this bug)

CCMAIL: 56042@bugs.kde.org


  M +5 -0      ChangeLog   1.69
  M +3 -3      protocolview.cpp   1.16
  M +3 -3      settingsdlg.cpp   1.19
  M +3 -3      updateview.cpp   1.38


--- kdesdk/cervisia/ChangeLog  #1.68:1.69
@@ -1,2 +1,7 @@
+2003-04-18  Christian Loose  <christian.loose@hamburg.de>
+
+        * Fix BR 56042: Better default colors for white
+          background
+
 2003-02-28  Christian Loose  <christian.loose@hamburg.de>
 

--- kdesdk/cervisia/protocolview.cpp  #1.15:1.16
@@ -42,9 +42,9 @@ ProtocolView::ProtocolView(const QCStrin
     
     config->setGroup("Colors");
-    QColor defaultColor = QColor(255, 100, 100);
+    QColor defaultColor = QColor(255, 130, 130);
     conflictColor=config->readColorEntry("Conflict",&defaultColor);
-    defaultColor=QColor(190, 190, 237);
+    defaultColor=QColor(130, 130, 255);
     localChangeColor=config->readColorEntry("LocalChange",&defaultColor);
-    defaultColor=QColor(255, 240, 190);
+    defaultColor=QColor(70, 210, 70);
     remoteChangeColor=config->readColorEntry("RemoteChange",&defaultColor);
     

--- kdesdk/cervisia/settingsdlg.cpp  #1.18:1.19
@@ -257,9 +257,9 @@ void SettingsDialog::readSettings()
 
     config->setGroup("Colors");
-    QColor defaultColor = QColor(255, 100, 100);
+    QColor defaultColor = QColor(255, 130, 130);
     conflictbutton->setColor(config->readColorEntry("Conflict",&defaultColor));
-    defaultColor=QColor(190, 190, 237);
+    defaultColor=QColor(130, 130, 255);
     localchangebutton->setColor(config->readColorEntry("LocalChange",&defaultColor));
-    defaultColor=QColor(255, 240, 190);
+    defaultColor=QColor(70, 210, 70);
     remotechangebutton->setColor(config->readColorEntry("RemoteChange",&defaultColor));
 

--- kdesdk/cervisia/updateview.cpp  #1.37:1.38
@@ -1122,11 +1122,11 @@ void UpdateView::updateColors()
     config->setGroup("Colors");
 
-    QColor defaultColor = QColor(255, 100, 100);
+    QColor defaultColor = QColor(255, 130, 130);
     m_conflictColor = config->readColorEntry("Conflict", &defaultColor);
 
-    defaultColor = QColor(190, 190, 237);
+    defaultColor = QColor(130, 130, 255);
     m_localChangeColor = config->readColorEntry("LocalChange", &defaultColor);
 
-    defaultColor = QColor(255, 240, 190);
+    defaultColor = QColor(70, 210, 70);
     m_remoteChangeColor = config->readColorEntry("RemoteChange", &defaultColor);
 }

Shouldn't this one be closed? 

No, this isn't really fixed yet. I just changed the default colors to something 
more readable but the problem still exists.

See comment #4 for an explanation of the problem and comment #5 for a 
reasonable solution.

Christian

Subject: kdesdk/cervisia

CVS commit by woebbe: 

Fix/Implement FR 56042:

Use the configured colors as foreground colors in the file AND protocol view 
and a bold font to improve readability of the text for modified, added and 
removed files.

CCMAIL: 56042-done@bugs.kde.org


  M +8 -0      ChangeLog   1.94
  M +2 -2      protocolview.cpp   1.22
  M +18 -3     updateview.cpp   1.47


--- kdesdk/cervisia/ChangeLog  #1.93:1.94
@@ -1,2 +1,10 @@
+2003-08-02  Andr