Version: 1.1 (using KDE 3.1.0) Installed from: compiled sources Compiler: gcc version 2.95.3 20010315 (release) OS: Linux (i686) release 2.4.19 If I save in a read-write editor, the read-only views don't update. This makes it so that I have to close them, and re-open new ones, in order to see the updates. I wish the views would update when the changes are saved.
Subject: kdebase/konqueror/keditbookmarks CVS commit by lypanov: fix non updating ro views on save in rw view thanks for the bug report, was wondering if there was a bug here :) CCMAIL:54783-done@bugs.kde.org M +5 -1 mymanager.cpp 1.11 M +7 -3 toplevel.cpp 1.164 --- kdebase/konqueror/keditbookmarks/mymanager.cpp #1.10:1.11 @@ -22,5 +22,7 @@ #include <kdebug.h> #include <kapplication.h> + #include <dcopref.h> +#include <dcopclient.h> #include <kbookmarkmanager.h> @@ -32,4 +34,6 @@ #include "mymanager.h" +// DESIGN - file too small. solve, somehow, umm... but how... + CurrentMgr *CurrentMgr::s_mgr = 0; @@ -51,5 +55,5 @@ void CurrentMgr::notifyManagers() { QCString objId("KBookmarkManager-"); objId += mgr()->path().utf8(); - DCOPRef("*", objId).send("notifyCompleteChange", QString::fromLatin1(kapp->name())); + DCOPRef("*", objId).send("notifyCompleteChange", QString::fromLatin1(kapp->dcopClient()->appId())); } --- kdebase/konqueror/keditbookmarks/toplevel.cpp #1.163:1.164 @@ -26,4 +26,5 @@ #include <kstdaction.h> #include <kaction.h> +#include <dcopclient.h> #include <kkeydialog.h> @@ -376,9 +377,12 @@ void KEBApp::slotDocumentRestored() { void KEBApp::slotBookmarksChanged(const QString &, const QString &caller) { - // this is called when someone changes bookmarks in konqueror.... - kdDebug() << "FIXME: " << caller << " == " << kapp->name() << "?" << endl; + /* + kdDebug() << "caller == " << caller << ", " + << "kapp->name() == " << kapp->name() << ", " + << "kapp->dcopClient()->appId() == " << kapp->dcopClient()->appId() << endl; + */ // TODO umm.. what happens if a readonly gets a update for a non-readonly??? // the non-readonly maybe has a pretty much random kapp->name() ??? umm... - if ((caller != kapp->name()) && !m_modified) { + if ((caller.latin1() != kapp->dcopClient()->appId()) && !m_modified) { kdDebug() << "KEBApp::slotBookmarksChanged" << endl; // DESIGN - is this logic really unique?