Bug 54709 - Improper link handling in chat window
Summary: Improper link handling in chat window
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-16 09:02 UTC by Matt Jones
Modified: 2003-02-16 13:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Jones 2003-02-16 09:02:37 UTC
Version:           CVS Trunk (using KDE KDE 3.1)
Installed from:    Gentoo Packages
Compiler:          gcc 3.2.1 
OS:          Linux

When clicking a link in a chat window, the system ignores the html (or whatever mimetype) default application.  This is a simple fix, so I added a patch below.

--- libkopete/ui/chatview.cpp   2003-02-16 03:03:36.000000000 -0500
+++ /home/mjones/chatview.cpp   2003-02-16 03:03:29.000000000 -0500
@@ -29,6 +29,7 @@ete $ diff -Naur protocols/oscar/oscaruserinfo.h ~/kopete-build/

 #include <kiconloader.h>ff -Naur protocols/oscar/oscaruserinfo.h ~/oscaruserinfo
 #include <kapplication.h>
+#include <krun.h>
 #include <kconfig.h>
 #include <kdebug.h>
 #include <kdialog.h>
@@ -494,11 +495,7 @@
 {
        kdDebug(14010) << k_funcinfo << "url=" << url.url() << endl;

-       // FIXME: Doesn't KRun do the mime type check automagically for us? - Martijn
-       if( url.protocol() == QString::fromLatin1( "mailto" ) )
-               kapp->invokeMailer( url.url() );
-       else
-               kapp->invokeBrowser( url.url() );
+       new KRun( url );
 }
Comment 1 Martijn Klingens 2003-02-16 12:58:17 UTC
Subject: Re: [Kopete-devel]  New: Improper link handling in chat window

Looks like Stefan just committed a fix for this, but forgot to close the bug 
:)

Stefan: this one is safe to backport to 0.6.1 btw so Matthew doesn't have to 
wait for Kopete 0.7 ;)

Comment 2 Stefan Gehn 2003-02-16 13:17:48 UTC
And again this shows that I shouldn't work on several things at once ;)