Subject: KDE_3_1_BRANCH: kdegames/kbackgammon

CVS commit by staikos: 

arghgh

Unbreak kbackgammon.  Please be careful when doing "cleanups".  Make sure that
nothing actually breaks.

CCMAIL: 53586-done@bugs.kde.org


  M +9 -1      engines/nextgen/kbgng.cpp   1.4.4.1
  M +2 -2      kbg.cpp   1.24.2.2


--- kdegames/kbackgammon/kbg.cpp  #1.24.2.1:1.24.2.2
@@ -122,5 +122,5 @@ KBg::KBg(QWidget *parent, const char *na
 
         KStdGameAction::roll(this, SLOT(roll()), actionCollection())->setEnabled(false);
-        KStdGameAction::endTurn(this, SLOT(done()), actionCollection())->setEnabled(false);
+        KStdGameAction::endTurn(this, SLOT(done()), actionCollection(), "move_endturn")->setEnabled(false);
         (new KAction(i18n("Double Cube"), QIconSet(kapp->iconLoader()->loadIcon
                                                    (PROG_NAME "-double.xpm", KIcon::Toolbar)),

--- kdegames/kbackgammon/engines/nextgen/kbgng.cpp  #1.4:1.4.4.1
@@ -215,4 +215,7 @@ void KBgEngineNg::slotPlayerJoinedGame(K
 void KBgEngineNg::slotCreatePlayer(KPlayer *&p, int rtti, int io, bool v, KGame *g)
 {
+    Q_UNUSED(rtti)
+    Q_UNUSED(g)
+    Q_UNUSED(io)
     emit infoText(i18n("creating player. virtual=%1").arg(v));
     p = createPlayer(1);
@@ -319,4 +322,5 @@ void KBgEngineNg::redo()
 void KBgEngineNg::handleMove(QString *s)
 {
+    Q_UNUSED(s)
     // TODO
 }
@@ -335,4 +339,5 @@ void KBgEngineNg::roll()
 void KBgEngineNg::rollDice(const int w)
 {
+    Q_UNUSED(w)
     // empty
 }
@@ -527,4 +532,5 @@ void KBgEngineNg::slotPropertyChanged(KG
 void KBgEngineNg::slotPropertyChanged(KGamePropertyBase *p, KGame *me)
 {
+    Q_UNUSED(me)
     switch (p->id()) {
 
@@ -561,4 +567,6 @@ void KBgEngineNg::changeName()
 void KBgEngineNg::slotNetworkData(int msgid, const QByteArray &msg, Q_UINT32 r, Q_UINT32 s)
 {
+    Q_UNUSED(r);
+    Q_UNUSED(s);
     switch (msgid) {
 

Subject: Re:  crashes when drag-and-drop to move piece is finished

Thanks mate!

Btw, is the HEAD branch open again for development?



Cheers,
Jens 

On Thursday 13 February 2003 04:48 am, you wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=53586
> staikos@kde.org changed:
>
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- Status|UNCONFIRMED                 |RESOLVED
>          Resolution|                            |FIXED
>
>
>
> ------- Additional Comments From staikos@kde.org  2003-02-13 04:48 -------
> Subject: KDE_3_1_BRANCH: kdegames/kbackgammon
>
> CVS commit by staikos:
>
> arghgh
>
> Unbreak kbackgammon.  Please be careful when doing "cleanups".  Make sure
> that nothing actually breaks.
>
> CCMAIL: 53586-done@bugs.kde.org
>
>
>   M +9 -1      engines/nextgen/kbgng.cpp   1.4.4.1
>   M +2 -2      kbg.cpp   1.24.2.2
>
>
> --- kdegames/kbackgammon/kbg.cpp  #1.24.2.1:1.24.2.2
> @@ -122,5 +122,5 @@ KBg::KBg(QWidget *parent, const char *na
>
>          KStdGameAction::roll(this, SLOT(roll()),
> actionCollection())->setEnabled(false); -       
> KStdGameAction::endTurn(this, SLOT(done()),
> actionCollection())->setEnabled(false); +       
> KStdGameAction::endTurn(this, SLOT(done()), actionCollection(),
> "move_endturn")->setEnabled(false); (new KAction(i18n("Double Cube"),
> QIconSet(kapp->iconLoader()->loadIcon (PROG_NAME "-double.xpm",
> KIcon::Toolbar)),
>
> --- kdegames/kbackgammon/engines/nextgen/kbgng.cpp  #1.4:1.4.4.1
> @@ -215,4 +215,7 @@ void KBgEngineNg::slotPlayerJoinedGame(K
>  void KBgEngineNg::slotCreatePlayer(KPlayer *&p, int rtti, int io, bool v,
> KGame *g) {
> +    Q_UNUSED(rtti)
> +    Q_UNUSED(g)
> +    Q_UNUSED(io)
>      emit infoText(i18n("creating player. virtual=%1").arg(v));
>      p = createPlayer(1);
> @@ -319,4 +322,5 @@ void KBgEngineNg::redo()
>  void KBgEngineNg::handleMove(QString *s)
>  {
> +    Q_UNUSED(s)
>      // TODO
>  }
> @@ -335,4 +339,5 @@ void KBgEngineNg::roll()
>  void KBgEngineNg::rollDice(const int w)
>  {
> +    Q_UNUSED(w)
>      // empty
>  }
> @@ -527,4 +532,5 @@ void KBgEngineNg::slotPropertyChanged(KG
>  void KBgEngineNg::slotPropertyChanged(KGamePropertyBase *p, KGame *me)
>  {
> +    Q_UNUSED(me)
>      switch (p->id()) {
>
> @@ -561,4 +567,6 @@ void KBgEngineNg::changeName()
>  void KBgEngineNg::slotNetworkData(int msgid, const QByteArray &msg,
> Q_UINT32 r, Q_UINT32 s) {
> +    Q_UNUSED(r);
> +    Q_UNUSED(s);
>      switch (msgid) {

just to be sure: you're not talking of my "cleanups" (ie more use of standard 
actions) in head ? your fix seems to be for the 3.1 branch only, right ? the 
problem should not exist in head ...

see you,
Nicolas Hadacek

Subject: Re:  crashes when drag-and-drop to move piece is finished

I don't know if it was you who did the cleanup and when, but the introduction 
of the standard actions did indeed cause the problem: whoever did it missed 
one reference to one of the old actions.

But regardless, I am glad somebody did the original cleanup (thanks Nicolaus) 
and somebody did the fix (thanks George). From now on I'll take better care 
of the code (I am now settled into a new job and will have more time again).


Jens

On Saturday 15 February 2003 09:03 pm, you wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=53586
>
>
>
>
> ------- Additional Comments From hadacek@kde.org  2003-02-15 21:03 -------
> just to be sure: you're not talking of my "cleanups" (ie more use of
> standard actions) in head ? your fix seems to be for the 3.1 branch only,
> right ? the problem should not exist in head ...
>
> see you,
> Nicolas Hadacek