Bug 53147 - collapsing tree view using keyboard '-' or left arrow in file browser leaves remnants displayed
Summary: collapsing tree view using keyboard '-' or left arrow in file browser leaves ...
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: 3.0.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 53148 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-01-18 22:28 UTC by Richard Parry
Modified: 2003-04-05 18:19 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Bug in the konqueror file tree view during ftp browse (42.42 KB, image/png)
2003-03-03 16:18 UTC, Jarosław Staniek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Parry 2003-01-18 22:28:29 UTC
Version:           3.0.3 (using KDE 3.0.3)
Installed from:    SuSE
Compiler:          gcc version 3.2
OS:          Linux (i686) release 2.4.19-4GB

Here is an example of how I reproduce the behaviour.

Using konqueror as a file browser with a tree view, and looking at the root directory. All directories are shown with a + symbol next to them with "usr" and "var" the last two. Now expand "usr" - it doesn't matter how, e.g. click on the + symbol, or navigate with keyboard and use the '+' key or right arrow key.

Now collapse "usr" by using either the '-' key or left arrow; "usr" will collapse, and "var" will be listed just below as you would expect. But, below the entry for "var", the remains of the expanded view of "usr" are still visible.

Note: collapsing the tree view using the mouse works OK.
Comment 1 Stephan Binner 2003-01-19 13:34:15 UTC
*** Bug 53148 has been marked as a duplicate of this bug. ***
Comment 2 Jarosław Staniek 2003-03-03 16:18:53 UTC
Created attachment 1090 [details]
Bug in the konqueror file tree view during ftp browse

I confirm reported behaviour/bug. Even using mouse pointer to expand/collapse
directories, I am able to duplicate the bug. See attached screenshot, for
KDE3.1.0 on i386 Suse7.3 and I will refer to this shot:

For me, during use of ftp tree view (but IMO local file browsing can be bugly
too), I click [-] box for expanding/open glibc-2.3.1 dir; below it, we have
rpm-3.0.6 dir. After expanding 'glibc' dir, the contents-children of 'glibc'
node appeared visually not as its children but at the same level in tree as
have 'glibc' dir node. More, collapsing 'glibc' node after mentioned bad
behaviour, does not imply hiding contents of 'glibc'. So, if we expand 'glibc'
again - new "copy" of the child nodes will be added at the end of already
displayed nodes.

During that tests, expanding/collapsing other nodes works ok, so in that
situation I think - only the 'glibc' dir node is in inconsistent state. I do
not know if it is Qt QListView bug or KDE subclass bug (as Qt programmer Ive
never encountered that bug).

Jarek
Comment 3 Pascal Létourneau 2003-04-05 18:19:08 UTC
Subject: kdelibs/kdeui

CVS commit by pletourn: 


Misplaced setUpdatesEnable().
Reviewed by David Faure.
CCMAIL: 53147-done@bugs.kde.org


  M +0 -5      klistview.cpp   1.197


--- kdelibs/kdeui/klistview.cpp  #1.196:1.197
@@ -1430,6 +1430,4 @@ void KListView::fileManagerKeyPressEvent
     if (item==0) return;
 
-    setUpdatesEnabled(false);
-
     QListViewItem* repaintItem1 = item;
     QListViewItem* repaintItem2 = 0L;
@@ -1641,5 +1639,4 @@ void KListView::fileManagerKeyPressEvent
              if (d->selectedBySimpleMove)
                 nextItem->setSelected(true);
-             setUpdatesEnabled(true);
              ensureItemVisible(nextItem);
              setCurrentItem(nextItem);
@@ -1676,5 +1673,4 @@ void KListView::fileManagerKeyPressEvent
              if (d->selectedBySimpleMove)
                 nextItem->setSelected(true);
-             setUpdatesEnabled(true);
              ensureItemVisible(nextItem);
              setCurrentItem(nextItem);
@@ -1721,5 +1717,4 @@ void KListView::fileManagerKeyPressEvent
     }
 
-    setUpdatesEnabled(true);
     if (visItem)
        ensureItemVisible(visItem);